feat(agent-config): plugin tabs and add-plugin dialog [18/21] by gusfcarvalho · Pull Request #339 · compliance-framework/ui

gusfcarvalho · 2026-10-05T10:52:26Z

Part 18 of 21 of the stacked split of #318 (agent remote configuration). Every layer adds the final version of its files from #318, and only imports from layers below it, so each layer passes make reviewable on its own. Nothing is reachable in the app until layer 20 wires the Configuration tab in.

What

Plugin tabs in the Effective view, the add-plugin action/dialog (gated on what reporting instances support) and AgentConfigEffectiveView.

Tests

Specs for the Effective view and plugin library version.

Size exception

This PR is over the 1k-line limit (about 1,100 lines, package-lock excluded) and carries the size-exception label. Fixes from the stack's review (plugin lookups by own name, Add plugin refusing names the saved overlay defines, Add plugin and the Effective view waiting for every instance file with a Retry) change components this layer introduces, and their regression spec (PluginTabsWorkspace.spec.ts) needs those components, so neither can move to another layer.

🤖 Generated with Claude Code

coderabbitai · 2026-10-05T10:52:34Z

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 2972ba05-ed6f-4293-a3cb-9ef011ea71c4

📥 Commits

Reviewing files that changed from the base of the PR and between feadb4f and c5da8fa.

📒 Files selected for processing (7)

src/components/agents/config/AgentConfigEffectiveView.vue
src/components/agents/config/PluginTabs.vue
src/components/agents/config/__tests__/AgentConfigEffectiveView.spec.ts
src/components/agents/config/__tests__/PluginLibVersion.spec.ts
src/components/agents/config/__tests__/PluginTabsWorkspace.spec.ts
src/components/agents/config/editor/AddPluginAction.vue
src/components/agents/config/editor/AddPluginDialog.vue

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Copilot review overview

🟡 Changes recommended

Plugin-name collisions and inherited-property lookups can produce incorrect configuration behavior, and the add-plugin flow lacks coverage.

Review effort: Balanced
Findings: 3 · 1

Open (4)

Use own-property checks for plugin map lookups · New
Use own-property checks for pending plugin lookups · New
Include all desired overlay plugins in collision detection · New
Add component tests for plugin addition and tab selection · New

What changed in this PR

Adds the Effective configuration view’s plugin tabs, plugin metadata, and gated add-plugin workflow.

Changes:

Adds tabbed plugin summaries and pending-state indicators.
Adds access-aware plugin creation and validation.
Adds Effective view and plugin library badge tests.

File	Description
`PluginTabs.vue`	Implements plugin tabs and add-plugin flow.
`AddPluginDialog.vue`	Adds plugin input and access validation.
`AddPluginAction.vue`	Adds access-gated action button.
`AgentConfigEffectiveView.vue`	Composes Effective configuration summaries.
`PluginLibVersion.spec.ts`	Tests plugin library badges.
`AgentConfigEffectiveView.spec.ts`	Tests Effective view rendering and sanitization.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+      const basePlugin = props.base?.plugins?.[name];
+      if (v === null && basePlugin && !(name in eff)) {


+  const effDraft = ws?.draft.effectiveDraft.value.plugins ?? {};
+  if (card.pendingNew) {
+    hints.push({ key: 'new', label: 'new', severity: 'info' });
+  } else if (pending && !card.removed && !effDraft[card.name]) {


+const existingPluginNames = computed(() => {
+  const names = new Set(props.cards.map((c) => c.name));
+  for (const b of ws?.bases.value ?? [])
+    Object.keys(b.plugins ?? {}).forEach((n) => names.add(n));
+  return Array.from(names);
+});


+    <AddPluginDialog
+      v-if="canAddPlugin"
+      v-model:visible="addPluginOpen"
+      :existing="existingPluginNames"
+      @add="addPlugin"


ianmiell

ccf-review: APPROVE

1 Should-fix.

Stack (gh stack 343): #322 → #323 → #324 → #325 → #326 → #327 → #328 → #329 → #330 → #331 → #332 → #333 → #334 → #335 → #336 → #337 → #338 → #339 → #340 → #341 → #342

ianmiell · 2026-10-06T07:32:34Z

+        >
+          {{ scheduleError }}
+        </p>
+        <p v-else-if="schedule" class="mt-1 text-xs text-gray-500">


[Should-fix] UI-COMP-001 · Component convention not followed

Introduced in #339. text-gray-400/text-gray-500 with no dark: variant; 745 of 823 such class attributes in the repo pair them with dark:text-slate-*.

Why: Mixed patterns make components harder to maintain; there are no auto-imports.
Fix: Add the matching dark:text-slate-400/dark:text-slate-500 variant, as the neighbouring components do.

_{ccf-review · edbd0ded8977 · rules@6be9e11b8bc6}

ianmiell

ccf-review: APPROVE

no findings.

Stack (gh stack 343): #322 → #323 → #324 → #325 → #326 → #327 → #328 → #329 → #330 → #331 → #332 → #333 → #334 → #335 → #336 → #337 → #338 → #339 → #340 → #341 → #342

Layer 18 of 21 in the stacked split of #318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

… a defined plugin - the tab's removal hint and the "Removed by overlay" card read plugins as own properties (getOwn), so a plugin named "constructor" is matched like any other - Add plugin refuses every name the saved overlay or the draft defines (non-null), not only the shown cards and loaded files: adding writes the whole plugin and replaced a saved definition this instance does not run yet - Add plugin waits, with the reason, until every reporting instance's file is loaded; the Effective view says files are loading, or names the ones that failed with a Retry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:52

gusfcarvalho added this pull request to stack #343 October 5, 2026 10:52

gusfcarvalho mentioned this pull request Oct 5, 2026

feat: agent remote configuration (overlay, apply modes, safeguards) #318

Closed

Copilot started reviewing on behalf of gusfcarvalho October 5, 2026 10:56 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

gusfcarvalho force-pushed the agent-config/18-plugin-tabs branch from cae8b8b to dede9da Compare October 5, 2026 16:32

ianmiell previously approved these changes Oct 6, 2026

View reviewed changes

ianmiell mentioned this pull request Oct 6, 2026

test(agents): integration specs for the Configuration tab [21/21] #342

Merged

ccf-lisa Bot dismissed ianmiell’s stale review via 94d25b0 October 6, 2026 09:40

ccf-lisa Bot force-pushed the agent-config/18-plugin-tabs branch from dede9da to 94d25b0 Compare October 6, 2026 09:40

ccf-lisa Bot force-pushed the agent-config/18-plugin-tabs branch from 94d25b0 to 735e6b9 Compare October 6, 2026 11:38

gusfcarvalho added the size-exception PR intentionally exceeds the 1k-line size limit; reasoning in the description label Oct 6, 2026

ccf-lisa Bot force-pushed the agent-config/18-plugin-tabs branch from 735e6b9 to 19a6e4a Compare October 6, 2026 11:51

ianmiell previously approved these changes Oct 6, 2026

View reviewed changes

This was referenced Oct 6, 2026

feat(agent-config): configuration history and revert [19/21] #340

Merged

feat(agents): Configuration tab on the Agents page [20/21] #341

Merged

ccf-lisa Bot dismissed ianmiell’s stale review via 9557aa9 October 6, 2026 13:32

ccf-lisa Bot force-pushed the agent-config/18-plugin-tabs branch from 19a6e4a to 9557aa9 Compare October 6, 2026 13:32

ccf-lisa Bot force-pushed the agent-config/18-plugin-tabs branch from 9557aa9 to 922bc91 Compare October 6, 2026 14:20

ccf-lisa Bot force-pushed the agent-config/18-plugin-tabs branch from 922bc91 to 5637b3c Compare October 6, 2026 14:38

gusfcarvalho and others added 2 commits October 6, 2026 12:14

feat(agent-config): plugin tabs and add-plugin dialog

0af67f3

Layer 18 of 21 in the stacked split of #318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

gusfcarvalho force-pushed the agent-config/18-plugin-tabs branch from 5637b3c to c5da8fa Compare October 6, 2026 15:14

gusfcarvalho merged commit f2d30b7 into main Oct 6, 2026
4 checks passed

gusfcarvalho deleted the agent-config/18-plugin-tabs branch October 6, 2026 16:57

Navigation Menu

Repository navigation

feat(agent-config): plugin tabs and add-plugin dialog [18/21] - #339

feat(agent-config): plugin tabs and add-plugin dialog [18/21]#339
gusfcarvalho merged 2 commits into
agent-config/17-plugin-cardfrom
agent-config/18-plugin-tabs

gusfcarvalho commented Oct 5, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 5, 2026 •

edited

Loading

Review limit reached

Uh oh!

Copilot AI left a comment

Uh oh!

ianmiell left a comment

Uh oh!

ianmiell Oct 6, 2026

Uh oh!

ianmiell left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		const basePlugin = props.base?.plugins?.[name];
		if (v === null && basePlugin && !(name in eff)) {

Conversation

gusfcarvalho commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Tests

Size exception

Uh oh!

coderabbitai Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

ianmiell left a comment

Choose a reason for hiding this comment

ccf-review: APPROVE

Uh oh!

ianmiell Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

ianmiell left a comment

Choose a reason for hiding this comment

ccf-review: APPROVE

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gusfcarvalho commented Oct 5, 2026 •

edited

Loading

coderabbitai Bot commented Oct 5, 2026 •

edited

Loading