feat(agent-config): agent config API client, configure permission and review helpers [9/21]

[gusfcarvalho]

Part 9 of 21 of the stacked split of #318 (agent remote configuration). Every layer adds the final version of its files from #318, and only imports from layers below it, so each layer passes make reviewable on its own. Nothing is reachable in the app until layer 20 wires the Configuration tab in.

What

The agent-config API client (useAgentConfigApi) on the axios layer, a jsonBody request transform that sends overlay keys verbatim (no camel/kebab conversion), the agent:configure permission action, usePermissions().loaded, and the review-row helpers used by the workspace and save preview.

Tests

Specs for the API client and the axios transform.

🤖 Generated with Claude Code

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 45a0b589-6f2b-475d-9386-b9809fa6c5c5

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[ianmiell]

ccf-review: APPROVE

no findings.

Stack (gh stack 343): #322 → #323 → #324 → #325 → #326 → #327 → #328 → #329 → #330 → #331 → #332 → #333 → #334 → #335 → #336 → #337 → #338 → #339 → #340 → #341 → #342

[gusfcarvalho]

ccf-review: would REQUEST_CHANGES

Submitted as COMMENT: GitHub does not let a PR's author request changes on or approve it.

1 Must-fix.

Stack (gh stack 343): #322 → #323 → #324 → #325 → #326 → #327 → #328 → #329 → #330 → #331 → #332 → #333 → #334 → #335 → #336 → #337 → #338 → #339 → #340 → #341 → #342

[gusfcarvalho]

[Must-fix] Follow the API's bounded instance list (companion of api#476)

Reviewer decision on compliance-framework/api#476: the instance list is paginated before merge. GET /api/admin/agents/{id}/instances today returns every instance with its full summary columns (warnings, unsafe, plugins, remote-config). That can exceed 1 GiB for one agent, and listInstances loads it in full whenever an agent is opened.

New API contract (being implemented on api#476/#483):

• query page (default 1) and limit (default 25, max 25); data holds that page's instance summaries, same order as today (last seen first);
• meta: desired-revision, counts (still over all instances: total, fresh, stale, in-sync, out-of-sync, pending, rejected, failed, unknown), plus page, limit, total, total-pages;
• GET …/instances/{instanceId} is unchanged.

Why: The API change breaks this client's assumption that the list carries full per-instance lists; landing one side without the other breaks the Configuration tab.
Fix: What the UI needs to do (this PR and the ones above it in the stack):

1. feat(agent-config): agent config API client, configure permission and review helpers [9/21] #330 useAgentConfigApi.ts: listInstances(agentId, { page, limit }) sends the query and returns { items, meta } with the new meta fields. Update InstancesMeta/InstancesList in api-types.ts and the useAgentConfigApi.spec.ts cases (query params, meta shape).
2. Fleet-wide numbers come from meta.counts, not from the loaded rows: summarizeSync and the instance count (useAgentConfig.ts, AgentConfigTab.vue instance-count).
3. Code that needs every instance: field access (field-access.ts, which uses each instance's remoteConfig and plugins), the warnings aggregation in useConfigWorkspace.ts, and the save-preview instance list. Load all pages through one helper (for example listAllInstances: sequential pages until page === total-pages) with a hard cap on pages. Past the cap, show that the view covers only part of the fleet; do not silently compute over a partial set.
4. The instance picker (AgentConfigTab.vue, v-if="state.instances.value.length > 1") pages through the list instead of rendering every row.
5. Update fixtures, the integration specs (test(agents): integration specs for the Configuration tab [21/21] #342) and the conformance or field-access tests that build instance lists.
   Merge only together with api#476/#483; landing either side alone breaks the Configuration tab.
   Severity basis: no rule matched; decision tree: wrong behaviour or missing companion change.

_{ccf-review · 4142df644d96 · rules@992d25d050e9}