feat(agent-config): inline scalar and map field editing [15/21] - #336
Open
gusfcarvalho wants to merge 1 commit into
Open
gusfcarvalho wants to merge 1 commit into
gusfcarvalho wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Map additions bypass per-key access controls, and empty-value handling can use an incomplete set of instance bases.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds inline agent-configuration editing components for the future Effective view.
Changes:
- Adds scalar/map editors with access, pending, and undo indicators.
- Adds empty/null handling and agent flag summaries.
- Tests empty string map behavior.
| File | Description |
|---|---|
scalar.ts |
Defines scalar editor kinds. |
PendingPill.vue |
Displays pending changes and undo. |
nullKeys.ts |
Detects invalid null object values. |
MapFieldEditor.vue |
Edits plugin config and label maps. |
InlineScalarEditor.vue |
Edits scalar configuration values. |
emptyValue.ts |
Implements empty string inheritance behavior. |
EditableField.vue |
Wraps fields with editing and access controls. |
AccessIcon.vue |
Displays field-access indicators. |
emptyValue.spec.ts |
Tests empty-value behavior. |
ConfigFlagsSummary.vue |
Summarizes editable agent flags. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| :warn-keys="field === 'config'" | ||
| :test-id="`${field}-${plugin}`" | ||
| @set="setValue" | ||
| @add="(k, v) => draft.set(p(k), v)" |
Comment on lines
+124
to
+126
| const bases = [ws.placeholderBase.value, ...ws.bases.value]; | ||
| /** Some instance's file defines this key: emptying it inherits the file value. */ | ||
| const inAnyBase = definedInAnyBase(bases, props.ptr); |
Comment on lines
+80
to
+82
| function setValue(k: string, v: string) { | ||
| setStringKey(draft, [ctx.placeholderBase.value, ...ctx.bases.value], p(k), v); | ||
| } |
gusfcarvalho
force-pushed
the
agent-config/15-inline-editing
branch
from
October 5, 2026 16:32
5fc2700 to
2c70aaa
Compare
This was referenced Oct 6, 2026
Layer 15 of 21 in the stacked split of #318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
agent-config/15-inline-editing
branch
from
October 6, 2026 09:40
2c70aaa to
d200150
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 15 of 21 of the stacked split of #318 (agent remote configuration). Every layer adds the final version of its files from #318, and only imports from layers below it, so each layer passes
make reviewableon its own. Nothing is reachable in the app until layer 20 wires the Configuration tab in.What
Inline editing in the Effective view: scalar editor, editable field wrapper, map field editor, access/pending indicators, empty/null value helpers, and the config flags summary.
Tests
emptyValue.spec.ts; inline editing end to end is covered byInlineEditing.spec.tsin layer 21.🤖 Generated with Claude Code