Repository navigation
feat(agent-config): instance status classification and test fixtures [6/21] - #327
Merged
gusfcarvalho merged 4 commits intoOct 6, 2026
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Out-of-sync revisions are misclassified, and truncated-instance fixtures incorrectly retain their dropped base configuration.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Adds agent-instance status classification and reusable remote-configuration fixtures.
Changes:
- Derives UI status badges and synchronization summaries.
- Adds classification tests.
- Adds shared API fixtures for later layers.
| File | Description |
|---|---|
src/utils/agent-config/instance-status.ts |
Classifies instance states and summarizes synchronization. |
src/utils/agent-config/__tests__/instance-status.spec.ts |
Tests status classification and summaries. |
src/composables/agent-config/__tests__/fixtures.ts |
Provides shared configuration API fixtures. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| base.remote_config = clone(s.remoteConfig ?? remoteConfigSafe); | ||
| return { | ||
| ...s, | ||
| base, |
Comment on lines
+106
to
+107
| if (inst.status === 'applied' && inst.syncStatus === 'out-of-sync') | ||
| return pending; |
gusfcarvalho
force-pushed
the
agent-config/06-instance-status
branch
from
October 5, 2026 16:32
a540834 to
f670604
Compare
This was referenced Oct 6, 2026
Merged
ccf-lisa
Bot
force-pushed
the
agent-config/06-instance-status
branch
2 times, most recently
from
October 6, 2026 11:38
c4b4402 to
ce862c2
Compare
This was referenced Oct 6, 2026
This was referenced Oct 6, 2026
Merged
This was referenced Oct 6, 2026
ccf-lisa
Bot
force-pushed
the
agent-config/06-instance-status
branch
from
October 6, 2026 13:32
ce862c2 to
029ddaa
Compare
Layer 6 of 21 in the stacked split of #318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The one-shot, truncated-report and file-warnings badge tooltips read TOOLTIPS['agents.config.instance.*'], per docs/TOOLTIPS.md (UI-COMP-001). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The instance list becomes paginated (api#476/#483), so the loaded rows may be part of the fleet. summarizeSync takes meta.counts for the fleet-wide numbers (total, in sync / expected, stale, not reporting) and marks the summary partial when fewer rows are loaded than counts.total: report-only (rows only) is then unknown, and the problem chips cover the loaded rows. instancesMixed.meta carries the page fields. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
agent-config/06-instance-status
branch
from
October 6, 2026 14:20
029ddaa to
274a926
Compare
…summary The API counts sync status for every instance, stale ones included, so taking inSync / expected from meta.counts showed an offline agent as "In sync: 1/1". With every row loaded (the normal case, and always a single instance) the summary is computed from the rows as before, with only the total from counts; the counts are used only when the list is partial, where they are the only fleet-wide numbers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 6 of 21 of the stacked split of #318 (agent remote configuration). Every layer adds the final version of its files from #318, and only imports from layers below it, so each layer passes
make reviewableon its own. Nothing is reachable in the app until layer 20 wires the Configuration tab in.What
Classifies reporting instances (in sync / pending / drifted / stale / unsupported) and adds the shared API fixtures used by the composable and component specs above this layer.
Tests
instance-status.spec.ts.🤖 Generated with Claude Code