feat(agent-config): pending changes bar, review-and-save and raw overlay dialogs [14/21] - #335
Open
gusfcarvalho wants to merge 2 commits into
Open
gusfcarvalho wants to merge 2 commits into
gusfcarvalho wants to merge 2 commits into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gusfcarvalho
force-pushed
the
agent-config/14-workspace-dialogs
branch
from
October 5, 2026 16:32
c3bb0d1 to
f21dbd7
Compare
This was referenced Oct 6, 2026
ianmiell
requested changes
Oct 6, 2026
This was referenced Oct 6, 2026
ccf-lisa
Bot
force-pushed
the
agent-config/14-workspace-dialogs
branch
from
October 6, 2026 09:40
f21dbd7 to
742a7b7
Compare
ccf-lisa
Bot
force-pushed
the
agent-config/14-workspace-dialogs
branch
from
October 6, 2026 11:38
742a7b7 to
8ed3831
Compare
This was referenced Oct 6, 2026
Merged
This was referenced Oct 6, 2026
ccf-lisa
Bot
force-pushed
the
agent-config/14-workspace-dialogs
branch
from
October 6, 2026 13:32
8ed3831 to
c10231b
Compare
ccf-lisa
Bot
force-pushed
the
agent-config/14-workspace-dialogs
branch
from
October 6, 2026 14:20
c10231b to
7def97e
Compare
ccf-lisa
Bot
force-pushed
the
agent-config/14-workspace-dialogs
branch
from
October 6, 2026 14:38
7def97e to
6bf288c
Compare
…lay dialogs Layer 14 of 21 in the stacked split of #318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Escape no longer closes the dialog (inside the editor it only leaves the editor), and Cancel or x ask before discarding text that differs from what the dialog opened with: the tab unmounts the dialog on close, so the edits would be lost. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gusfcarvalho
force-pushed
the
agent-config/14-workspace-dialogs
branch
from
October 6, 2026 15:14
6bf288c to
807a4ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 14 of 21 of the stacked split of #318 (agent remote configuration). Every layer adds the final version of its files from #318, and only imports from layers below it, so each layer passes
make reviewableon its own. Nothing is reachable in the app until layer 20 wires the Configuration tab in.What
Workspace dialogs: the pending-changes bar, review-and-save dialog and the raw overlay (JSON/YAML) dialog.
Tests
RawOverlayDialog.spec.ts; pending changes and review-and-save are covered byPendingChanges.spec.tsin layer 21.🤖 Generated with Claude Code