Skip to content

feat(agent-config): overlay draft, draft registry and preview composables [8/21] - #329

Merged
gusfcarvalho merged 1 commit into
agent-config/07-policy-datafrom
agent-config/08-overlay-draft
Oct 6, 2026
Merged

gusfcarvalho merged 1 commit into
agent-config/07-policy-datafrom
agent-config/08-overlay-draft

Conversation

@gusfcarvalho

Copy link
Copy Markdown
Contributor

Part 8 of 21 of the stacked split of #318 (agent remote configuration). Every layer adds the final version of its files from #318, and only imports from layers below it, so each layer passes make reviewable on its own. Nothing is reachable in the app until layer 20 wires the Configuration tab in.

What

The client-side overlay draft (useOverlayDraft), a per-agent draft registry, the editor context injection key and the server preview composable (usePreview).

Tests

Specs for the draft and the preview.

🤖 Generated with Claude Code

Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:52
@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 9c559aad-9a6a-4484-a342-27a7a4414010
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Preview state can cross agent boundaries, and conflict discard retains a stale review comment.

Review effort: Balanced
Findings: 1 High severity · 1 Medium severity

Open (2)
What changed in this PR

Adds foundational composables for agent configuration editing and preview validation.

Changes:

  • Adds persistent per-agent overlay drafts and rebase operations.
  • Adds debounced server previews and editor injection context.
  • Adds draft and preview unit tests.
File Description
usePreview.ts Implements debounced preview requests.
useOverlayDraft.ts Manages overlay editing, diffs, and rebasing.
editorContext.ts Defines editor injection contracts.
draftRegistry.ts Stores session-scoped drafts.
usePreview.spec.ts Tests preview scheduling and cancellation.
useOverlayDraft.spec.ts Tests drafts, rebasing, and registry behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

}, LIVE_PREVIEW_DEBOUNCE_MS);
}

watch([overlay, canPreview], schedule, { immediate: true });
Comment on lines +258 to +260
} else {
overlay.value = clone(theirs);
}
ianmiell
ianmiell previously approved these changes Oct 6, 2026

@ianmiell ianmiell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ccf-review: APPROVE

no findings.

Stack (gh stack 343): #322 → #323 → #324 → #325 → #326 → #327 → #328 → #329 → #330 → #331 → #332 → #333 → #334 → #335 → #336 → #337 → #338 → #339 → #340 → #341 → #342

…bles

Layer 8 of 21 in the stacked split of #318.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ccf-lisa
ccf-lisa Bot force-pushed the agent-config/08-overlay-draft branch from a640013 to 5955335 Compare October 6, 2026 14:38
@gusfcarvalho
gusfcarvalho merged commit 2f6ac7b into main Oct 6, 2026
7 checks passed
@gusfcarvalho
gusfcarvalho deleted the agent-config/08-overlay-draft branch October 6, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants