feat(agent-config): field editor building blocks, header and instance picker [12/21] by gusfcarvalho · Pull Request #333 · compliance-framework/ui

gusfcarvalho · 2026-10-05T10:52:11Z

Part 12 of 21 of the stacked split of #318 (agent remote configuration). Every layer adds the final version of its files from #318, and only imports from layers below it, so each layer passes make reviewable on its own. Nothing is reachable in the app until layer 20 wires the Configuration tab in.

What

Field editor building blocks (useEditor, field hints/issues, key-value editor, policy sources editor), the configuration header and the instance picker.

Tests

KeyValueEditor.spec.ts; the rest is covered by the integration specs in layer 21.

🤖 Generated with Claude Code

coderabbitai · 2026-10-05T10:52:19Z

Important

🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: a638033f-06c7-4a08-8e47-77cd25ab09ce

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Copilot

Copilot review overview

🟡 Changes recommended

Composite-field errors can be hidden, stale refreshes can conceal the selected instance, and policy trust messaging can be inaccurate.

Review effort: Balanced
Findings: 3

Open (3)

Expand instance list when selected instance becomes stale · New
Correctly aggregate source safety across affected instances · New
Include descendant pointers when collecting field issues · New

What changed in this PR

Adds reusable agent-configuration editors, status headers, and instance-selection components.

Changes:

Adds field hints, issue display, policy-source, and key-value editors.
Adds configuration header and stale-aware instance picker.
Adds key-value editor tests.

File	Description
`useEditor.ts`	Provides shared editor helpers and hints.
`PolicySourcesEditor.vue`	Edits ordered policy sources.
`KeyValueEditor.vue`	Edits key-value configuration fields.
`FieldIssues.vue`	Displays field validation issues.
`FieldHints.vue`	Displays shields, differences, and reset actions.
`AgentInstancePicker.vue`	Selects fresh or stale instances.
`AgentConfigHeader.vue`	Shows revision and synchronization status.
`KeyValueEditor.spec.ts`	Tests key trimming and validation.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+watch(
+  () => props.selectedId,
+  (id) => {
+    if (staleItems.value.some((i) => i.inst.instanceId === id))
+      showStale.value = true;
+  },
+  { immediate: true },
+);


+          >trusted on {{ hint(entry)!.safe }}/{{ hint(entry)!.total }} instances
+          · {{ hint(entry)!.label }}</span


+    return getAt(draft.effectiveDraft.value, ptr);
+  }
+  function issuesAt(ptr: string) {
+    return draft.issues.value.filter((i) => i.ptr === ptr);


ianmiell

ccf-review: APPROVE

3 Should-fix.

Stack (gh stack 343): #322 → #323 → #324 → #325 → #326 → #327 → #328 → #329 → #330 → #331 → #332 → #333 → #334 → #335 → #336 → #337 → #338 → #339 → #340 → #341 → #342

ianmiell · 2026-10-06T07:32:19Z

+        class="text-xs font-medium tracking-wide text-gray-500 uppercase dark:text-slate-400"
+        >Policies</span
+      >
+      <span v-if="!overridden" class="text-[0.7rem] text-gray-400"


[Should-fix] UI-COMP-001 · Component convention not followed

Introduced in #333. text-gray-400/text-gray-500 with no dark: variant; 745 of 823 such class attributes in the repo pair them with dark:text-slate-*.

Why: Mixed patterns make components harder to maintain; there are no auto-imports.
Fix: Add the matching dark:text-slate-400/dark:text-slate-500 variant, as the neighbouring components do.

_{ccf-review · a410bf38ee03 · rules@6be9e11b8bc6}

ianmiell

ccf-review: APPROVE

no findings.

Stack (gh stack 343): #322 → #323 → #324 → #325 → #326 → #327 → #328 → #329 → #330 → #331 → #332 → #333 → #334 → #335 → #336 → #337 → #338 → #339 → #340 → #341 → #342

… picker Layer 12 of 21 in the stacked split of #318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

KeyValueEditor's key-case warning and the "Reset to file value" tooltip (KeyValueEditor, FieldHints) read TOOLTIPS['agents.config.*'], per docs/TOOLTIPS.md (UI-COMP-001). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…ers part of the fleet - AgentInstancePicker renders 25 instances a page (fresh first, stale ones when shown) with Previous / Next, and opens on the selected instance's page - AgentConfigHeader says "Showing N of M instances" when the loaded rows are part of the fleet; its numbers come from the API's counts (instanceCount is the fleet total) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…fleet counts On a partial instance list the in-sync ratio is the API's fleet-wide counts, which include stale instances: the header now reads "In sync: X/Y instances (incl. stale, from the API's fleet counts)". A complete list shows the row-based ratio as before (2/4 for the fixture fleet). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI balanced review requested due to automatic review settings October 5, 2026 10:52

gusfcarvalho added this pull request to stack #343 October 5, 2026 10:52

gusfcarvalho mentioned this pull request Oct 5, 2026

feat: agent remote configuration (overlay, apply modes, safeguards) #318

Closed

Copilot started reviewing on behalf of gusfcarvalho October 5, 2026 10:55 View session

Copilot AI reviewed Oct 5, 2026

View reviewed changes

gusfcarvalho force-pushed the agent-config/12-field-editors branch from d6d04e3 to ea13bf8 Compare October 5, 2026 16:32

ianmiell previously approved these changes Oct 6, 2026

View reviewed changes

This was referenced Oct 6, 2026

feat(agent-config): save preview with diff rows and safety tags [13/21] #334

Merged

feat(agent-config): plugin tabs and add-plugin dialog [18/21] #339

Open

test(agents): integration specs for the Configuration tab [21/21] #342

Open

ccf-lisa Bot dismissed ianmiell’s stale review via 8d5a418 October 6, 2026 09:40

ccf-lisa Bot force-pushed the agent-config/12-field-editors branch from ea13bf8 to 8d5a418 Compare October 6, 2026 09:40

ccf-lisa Bot force-pushed the agent-config/12-field-editors branch from 8d5a418 to 68f3681 Compare October 6, 2026 11:38

ianmiell previously approved these changes Oct 6, 2026

View reviewed changes

ianmiell mentioned this pull request Oct 6, 2026

feat(agent-config): inline scalar and map field editing [15/21] #336

Open

ccf-lisa Bot dismissed ianmiell’s stale review via 5e274af October 6, 2026 13:32

ccf-lisa Bot force-pushed the agent-config/12-field-editors branch from 68f3681 to 5e274af Compare October 6, 2026 13:32

ccf-lisa Bot force-pushed the agent-config/12-field-editors branch from 5e274af to 04aa5db Compare October 6, 2026 14:20

gusfcarvalho and others added 4 commits October 6, 2026 11:24

feat(agent-config): field editor building blocks, header and instance…

44fd16c

… picker Layer 12 of 21 in the stacked split of #318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(agent-config): editor tooltips live in tooltips.ts

6c4c938

KeyValueEditor's key-case warning and the "Reset to file value" tooltip (KeyValueEditor, FieldHints) read TOOLTIPS['agents.config.*'], per docs/TOOLTIPS.md (UI-COMP-001). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

ccf-lisa Bot force-pushed the agent-config/12-field-editors branch from 04aa5db to ec210f9 Compare October 6, 2026 14:38

gusfcarvalho merged commit 95a9d65 into main Oct 6, 2026
7 checks passed

gusfcarvalho deleted the agent-config/12-field-editors branch October 6, 2026 15:14

Navigation Menu

feat(agent-config): field editor building blocks, header and instance picker [12/21] - #333

feat(agent-config): field editor building blocks, header and instance picker [12/21]#333
gusfcarvalho merged 4 commits into
agent-config/11-shared-uifrom
agent-config/12-field-editors

gusfcarvalho commented Oct 5, 2026

Uh oh!

coderabbitai Bot commented Oct 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

ianmiell left a comment

Uh oh!

Uh oh!

Uh oh!

ianmiell Oct 6, 2026

Uh oh!

ianmiell left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		>trusted on {{ hint(entry)!.safe }}/{{ hint(entry)!.total }} instances
		· {{ hint(entry)!.label }}</span

Conversation

gusfcarvalho commented Oct 5, 2026

What

Tests

Uh oh!

coderabbitai Bot commented Oct 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

ianmiell left a comment

Choose a reason for hiding this comment

ccf-review: APPROVE

Uh oh!

Uh oh!

Uh oh!

ianmiell Oct 6, 2026

Choose a reason for hiding this comment

Uh oh!

ianmiell left a comment

Choose a reason for hiding this comment

ccf-review: APPROVE

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Oct 5, 2026 •

edited

Loading