feat(agent-config): save preview with diff rows and safety tags [13/21] - #334
Open
gusfcarvalho wants to merge 1 commit into
Open
gusfcarvalho wants to merge 1 commit into
gusfcarvalho wants to merge 1 commit into
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Review effort: Balanced
Findings: 4
Open (4)
What changed in this PR
Adds reusable save-preview components for agent configuration overlays, ahead of later Configuration-tab integration.
Changes:
- Adds per-instance diffs, validation feedback, and save controls.
- Introduces diff rows and safety badges.
- Adds save-preview component tests.
| File | Description |
|---|---|
| src/components/agents/config/editor/SavePreviewPanel.vue | Updated as part of this pull request. |
| src/components/agents/config/editor/SafetyTag.vue | Updated as part of this pull request. |
| src/components/agents/config/editor/DiffRows.vue | Updated as part of this pull request. |
| src/components/agents/config/__tests__/SavePreviewPanel.spec.ts | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| </tr> | ||
| <tr | ||
| v-for="row in rows" | ||
| :key="row.path" |
Comment on lines
+61
to
+62
| const t = truncate(p.value); | ||
| const full = truncate(p.value, Number.MAX_SAFE_INTEGER).text; |
Comment on lines
+342
to
+345
| const topErrors = computed<FieldError[]>(() => [ | ||
| ...props.preview.overlayErrors, | ||
| ...(props.saveErrors?.overlay ?? []), | ||
| ]); |
Comment on lines
+405
to
+406
| diffOriginal.value = typeof row.before === 'string' ? row.before : ''; | ||
| diffModified.value = typeof row.after === 'string' ? row.after : ''; |
Layer 13 of 21 in the stacked split of #318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gusfcarvalho
force-pushed
the
agent-config/13-save-preview
branch
from
October 5, 2026 16:32
961f200 to
d1578a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 13 of 21 of the stacked split of #318 (agent remote configuration). Every layer adds the final version of its files from #318, and only imports from layers below it, so each layer passes
make reviewableon its own. Nothing is reachable in the app until layer 20 wires the Configuration tab in.What
The save preview: review rows, safety tags, diff rows and
SavePreviewPanel(YAML and merge diff of the overlay against the effective config).Tests
SavePreviewPanel.spec.ts.🤖 Generated with Claude Code