Repository navigation
feat(agent-config): plugin summary card [17/21] - #338
Merged
gusfcarvalho merged 3 commits intoOct 6, 2026
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Plugin actions and field validation feedback have unresolved functional issues.
Review effort: Balanced
Findings: 3
Open (3)
What changed in this PR
Adds the per-plugin summary card for agent remote configuration, ahead of app integration in layer 20.
Changes:
- Composes field editors, policy sources, policy data, status badges, and plugin actions.
- Adds policy-data interaction tests and a card display smoke test.
| File | Description |
|---|---|
| src/components/agents/config/PluginSummaryCard.vue | Adds the plugin summary and editing card. |
| src/components/agents/config/__tests__/PolicyDataSection.spec.ts | Tests structured/raw editing, masking, and read-only display. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| </header> | ||
| <div class="grid grid-cols-1 gap-x-6 gap-y-2 text-sm md:grid-cols-2"> | ||
| <div class="md:col-span-2"> | ||
| <EditableField :ptr="p('source')" label="source"> |
Comment on lines
+324
to
+326
| const canManage = computed( | ||
| () => !!ws && ws.ready.value && ws.canConfigure.value, | ||
| ); |
| function undoPlugin() { | ||
| if (!ws) return; | ||
| if (props.removed && !ws.draft.pendingAt(p())) ws.draft.unset(p()); | ||
| else ws.draft.revertPointer(p()); |
gusfcarvalho
force-pushed
the
agent-config/17-plugin-card
branch
from
October 5, 2026 16:32
a7ae772 to
9eb60ad
Compare
This was referenced Oct 6, 2026
Merged
ccf-lisa
Bot
force-pushed
the
agent-config/17-plugin-card
branch
from
October 6, 2026 09:40
9eb60ad to
0fad0b6
Compare
ccf-lisa
Bot
force-pushed
the
agent-config/17-plugin-card
branch
from
October 6, 2026 11:38
0fad0b6 to
e96f68b
Compare
ccf-lisa
Bot
force-pushed
the
agent-config/17-plugin-card
branch
from
October 6, 2026 11:51
e96f68b to
c4ad1cb
Compare
This was referenced Oct 6, 2026
Merged
This was referenced Oct 6, 2026
ccf-lisa
Bot
force-pushed
the
agent-config/17-plugin-card
branch
from
October 6, 2026 13:32
c4ad1cb to
4fe6810
Compare
ccf-lisa
Bot
force-pushed
the
agent-config/17-plugin-card
branch
2 times, most recently
from
October 6, 2026 14:38
7c4dd71 to
6932cff
Compare
Layer 17 of 21 in the stacked split of #318. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ntegers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…is loaded - pendingRemoval reads the draft's plugins as own properties (getOwn): a plugin named "constructor" (a valid name) read Object#constructor, so its removal showed no pending state and no Undo - Remove is disabled, with the workspace's reason, until every reporting instance's file is loaded: removal nulls the plugin where any file has it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gusfcarvalho
force-pushed
the
agent-config/17-plugin-card
branch
from
October 6, 2026 15:14
6932cff to
feadb4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 17 of 21 of the stacked split of #318 (agent remote configuration). Every layer adds the final version of its files from #318, and only imports from layers below it, so each layer passes
make reviewableon its own. Nothing is reachable in the app until layer 20 wires the Configuration tab in.What
The per-plugin summary card that composes the field editors, policy sources and
policy_datasection.Tests
PolicyDataSection.spec.ts, which mounts the card.🤖 Generated with Claude Code