Repository navigation
feat(config): ${env:NAME} placeholders in plugin config; ADR 0003 - #111
Merged
gusfcarvalho merged 1 commit intoOct 6, 2026
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 5, 2026
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-11-env-placeholders
branch
from
October 6, 2026 10:27
1729ce5 to
e40cc99
Compare
Contributor
Author
|
PR approved. Marking ready for e2e. |
- plugins.*.config values may reference environment variables, whole or embedded (R24), in the file and in an overlay. Reports, redaction and the digest keep the unresolved placeholder, so rotating a secret changes none of them. CCF_API_AUTH_* may never be referenced. - An unset variable the file references is a warning and the literal reaches the plugin unchanged, exactly as on main (R60). One an overlay introduces fails the revision with env-missing; the error names the variable, never a value. - ADR 0003 records the remote configuration overlay design; README points to it and to the state directory settings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-11-env-placeholders
branch
from
October 6, 2026 15:59
e40cc99 to
715c268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 11/11 of the split of #95 (agent remote configuration) into a stack. Review it as the diff against its base branch.
embedded (R24), in the file and in an overlay. Reports, redaction and the
digest keep the unresolved placeholder, so rotating a secret changes
none of them. CCF_API_AUTH_ may never be referenced.
reaches the plugin unchanged, exactly as on main (R60). One an overlay
introduces fails the revision with env-missing; the error names the
variable, never a value.
to it and to the state directory settings.
Size: 368 lines changed (go.mod/go.sum excluded). Builds, vets, is gofmt-clean and passes
go test -race ./...on its own; the top of the stack is byte-identical to #95 merged withmain.Stack
🤖 Generated with Claude Code