Repository navigation
refactor(config): adopt api/pkg/agentconfig as the declared config - #103
Merged
gusfcarvalho merged 2 commits intoOct 6, 2026
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 5, 2026
The config file is decoded into agentconfig.Config (the declared form) and
validated with the shared rules, then converted once by toRuntime into the
existing runtime structs, so agentConfigurationHash and evidence identity
stay byte-identical (the golden test from the previous commit proves it).
- loadBase builds a fresh viper per load with viper's weak decoder, exactly
as before (R51); CLI flags and the CCF_API_AUTH_* bindings are unchanged.
- File problems that always loaded stay non-fatal (R34): a bad plugin
schedule skips that plugin, a negative verbosity or a literal ${env:...}
outside plugins.*.config is a warning. Everything else is still fatal.
- Plugins gain `enabled` (default true); a disabled plugin gets no cron,
download or run state.
- IsOCI delegates to agentconfig.IsOCISource so agent and API classify
sources the same way.
- Pin compliance-framework/api b53be8f for pkg/agentconfig.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-03-declared-config
branch
from
October 6, 2026 10:27
dd36c8f to
b3ea689
Compare
Contributor
Author
|
PR approved. Marking ready for e2e. |
….enabled Replace the b53be8f pseudo-version with the released v0.21.0, whose agentconfig.Classify treats re-enabling a disabled plugin as unsafe and counts only enabled plugins' sources as already used. OPA stays v1.14.1 on both sides. Show the optional plugins.<p>.enabled key in the README Basic example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/11 of the split of #95 (agent remote configuration) into a stack. Review it as the diff against its base branch.
The config file is decoded into agentconfig.Config (the declared form) and
validated with the shared rules, then converted once by toRuntime into the
existing runtime structs, so agentConfigurationHash and evidence identity
stay byte-identical (the golden test from the previous commit proves it).
as before (R51); CLI flags and the CCF_API_AUTH_* bindings are unchanged.
schedule skips that plugin, a negative verbosity or a literal ${env:...}
outside plugins.*.config is a warning. Everything else is still fatal.
enabled(default true); a disabled plugin gets no cron,download or run state.
sources the same way.
Size: 919 lines changed (go.mod/go.sum excluded). Builds, vets, is gofmt-clean and passes
go test -race ./...on its own; the top of the stack is byte-identical to #95 merged withmain.Stack
🤖 Generated with Claude Code