Repository navigation
feat(pluginlib): read the agent library version a plugin binary was built with - #107
Merged
gusfcarvalho merged 2 commits intoOct 6, 2026
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 5, 2026
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-07-plugin-lib
branch
from
October 6, 2026 10:27
552042e to
d88a60c
Compare
Contributor
Author
|
PR approved. Marking ready for e2e. |
…uilt with
What a plugin does with a policy depends on the policy-manager compiled into
it, not on the running agent. pluginlib.Version reads the
github.com/compliance-framework/agent version from a plugin binary's Go build
info without starting it ("" for a replace or devel build), and Cache
memoizes it by path, size and modification time. The config report in the
next PR lists it per plugin as diagnostics (R76); nothing is gated on it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Split the lookup into versionFromInfo and table-test it (version, pseudo-version, replace, (devel), absent); test that the cache re-reads a binary whose size or mtime changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-07-plugin-lib
branch
from
October 6, 2026 15:59
d88a60c to
601c490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 7/11 of the split of #95 (agent remote configuration) into a stack. Review it as the diff against its base branch.
What a plugin does with a policy depends on the policy-manager compiled into
it, not on the running agent. pluginlib.Version reads the
github.com/compliance-framework/agent version from a plugin binary's Go build
info without starting it ("" for a replace or devel build), and Cache
memoizes it by path, size and modification time. The config report in the
next PR lists it per plugin as diagnostics (R76); nothing is gated on it.
Size: 114 lines changed (go.mod/go.sum excluded). Builds, vets, is gofmt-clean and passes
go test -race ./...on its own; the top of the stack is byte-identical to #95 merged withmain.Stack
🤖 Generated with Claude Code