Skip to content

feat(pluginlib): read the agent library version a plugin binary was built with - #107

Merged
gusfcarvalho merged 2 commits into
lisa/agent-config-06-reconcilerfrom
lisa/agent-config-07-plugin-lib
Oct 6, 2026
Merged

gusfcarvalho merged 2 commits into
lisa/agent-config-06-reconcilerfrom
lisa/agent-config-07-plugin-lib

Conversation

@ccf-lisa

@ccf-lisa ccf-lisa Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Part 7/11 of the split of #95 (agent remote configuration) into a stack. Review it as the diff against its base branch.

What a plugin does with a policy depends on the policy-manager compiled into
it, not on the running agent. pluginlib.Version reads the
github.com/compliance-framework/agent version from a plugin binary's Go build
info without starting it ("" for a replace or devel build), and Cache
memoizes it by path, size and modification time. The config report in the
next PR lists it per plugin as diagnostics (R76); nothing is gated on it.

Size: 114 lines changed (go.mod/go.sum excluded). Builds, vets, is gofmt-clean and passes go test -race ./... on its own; the top of the stack is byte-identical to #95 merged with main.

Stack
  1. test: pin agent configuration hashes and evidence seeds #101 test: pin agent configuration hashes and evidence seeds
  2. feat(runner): policy source from the _policy_path label; extra evidence props #102 feat(runner): policy source from the _policy_path label; extra evidence props
  3. refactor(config): adopt api/pkg/agentconfig as the declared config #103 refactor(config): adopt api/pkg/agentconfig as the declared config
  4. feat(agent): stable instance ID and per-instance state directory #104 feat(agent): stable instance ID and per-instance state directory
  5. feat(agent): AgentRunner primitives for prepare-then-cancel reloads #105 feat(agent): AgentRunner primitives for prepare-then-cancel reloads
  6. feat(agent): prepare-then-cancel config file reloads #106 feat(agent): prepare-then-cancel config file reloads
  7. 👉 feat(pluginlib): read the agent library version a plugin binary was built with #107 feat(pluginlib): read the agent library version a plugin binary was built with
  8. feat(agent): report the configuration to the API (remote_config off/report) #108 feat(agent): report the configuration to the API (remote_config off/report)
  9. feat(agentstate): persisted cache for the remote configuration overlay #109 feat(agentstate): persisted cache for the remote configuration overlay
  10. feat(agent): pull and apply remote configuration overlays (apply_safe/apply_all) #110 feat(agent): pull and apply remote configuration overlays (apply_safe/apply_all)
  11. feat(config): ${env:NAME} placeholders in plugin config; ADR 0003 #111 feat(config): ${env:NAME} placeholders in plugin config; ADR 0003

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: f80f0433-c111-4688-87c7-320760574cc2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gusfcarvalho gusfcarvalho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ccf-review: REQUEST_CHANGES

1 Must-fix.

Stack (gh stack 112): #101 → #102 → #103 → #104 → #105 → #106 → #107 → #108 → #109 → #110 → #111

Comment thread internal/pluginlib/pluginlib.go
@ccf-lisa
ccf-lisa Bot force-pushed the lisa/agent-config-07-plugin-lib branch from 552042e to d88a60c Compare October 6, 2026 10:27

@gusfcarvalho gusfcarvalho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ccf-review: APPROVE

no findings.

Stack (gh stack 112): #101 → #102 → #103 → #104 → #105 → #106 → #107 → #108 → #109 → #110 → #111

@ccf-lisa

ccf-lisa Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

PR approved. Marking ready for e2e.

ccf-lisa Bot and others added 2 commits October 6, 2026 12:51
…uilt with

What a plugin does with a policy depends on the policy-manager compiled into
it, not on the running agent. pluginlib.Version reads the
github.com/compliance-framework/agent version from a plugin binary's Go build
info without starting it ("" for a replace or devel build), and Cache
memoizes it by path, size and modification time. The config report in the
next PR lists it per plugin as diagnostics (R76); nothing is gated on it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Split the lookup into versionFromInfo and table-test it (version, pseudo-version, replace,
(devel), absent); test that the cache re-reads a binary whose size or mtime changed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ccf-lisa
ccf-lisa Bot force-pushed the lisa/agent-config-07-plugin-lib branch from d88a60c to 601c490 Compare October 6, 2026 15:59
@gusfcarvalho
gusfcarvalho merged commit 9ff9e0f into main Oct 6, 2026
8 of 9 checks passed
@gusfcarvalho
gusfcarvalho deleted the lisa/agent-config-07-plugin-lib branch October 6, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant