Repository navigation
feat(agent): AgentRunner primitives for prepare-then-cancel reloads - #105
Merged
gusfcarvalho merged 1 commit intoOct 6, 2026
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 5, 2026
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-05-runner-reload-primitives
branch
from
October 6, 2026 10:27
2a76a15 to
f5dd098
Compare
Contributor
Author
|
PR approved. Marking ready for e2e. |
The building blocks the reconciler in the next PR drives: - Prefetch downloads every plugin and policy source of a candidate config and resolves plugin protocols without touching the running config's locations, so a download failure never tears a working agent down (R32). ReportStartupFailure keeps main's startup-failure behaviour (plugins marked failed, startup-failure agent evidence) for a failed prefetch. - Plugin protocol versions read from OCI annotations are cached per source and survive reloads, so a registry outage cannot turn a v2 plugin into v1. - runDaemon returns setup errors instead of exiting. On a reload, in-flight plugin runs drain for up to 5 minutes (R33); a SIGINT/SIGTERM during the drain still exits within 30s. Each cron job runs with the config, client and logger of its own setup. - UpdateConfig reuses the SDK client when the api block is unchanged, so its token cache survives reloads. - Plugins get the host environment minus CCF_API_AUTH_* (R26). - make test runs with -race. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-05-runner-reload-primitives
branch
from
October 6, 2026 15:59
f5dd098 to
659f6d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 5/11 of the split of #95 (agent remote configuration) into a stack. Review it as the diff against its base branch.
The building blocks the reconciler in the next PR drives:
and resolves plugin protocols without touching the running config's
locations, so a download failure never tears a working agent down (R32).
ReportStartupFailure keeps main's startup-failure behaviour (plugins
marked failed, startup-failure agent evidence) for a failed prefetch.
and survive reloads, so a registry outage cannot turn a v2 plugin into v1.
plugin runs drain for up to 5 minutes (R33); a SIGINT/SIGTERM during the
drain still exits within 30s. Each cron job runs with the config, client
and logger of its own setup.
its token cache survives reloads.
The agent still uses the old reload loop here; #106 replaces it with the reconciler that drives
Prefetch. Tests live incmd/reconciler_test.go(filled in by #106).Size: 489 lines changed (go.mod/go.sum excluded). Builds, vets, is gofmt-clean and passes
go test -race ./...on its own; the top of the stack is byte-identical to #95 merged withmain.Stack
🤖 Generated with Claude Code