Repository navigation
feat(agent): pull and apply remote configuration overlays (apply_safe/apply_all) - #110
Merged
gusfcarvalho merged 4 commits intoOct 6, 2026
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 5, 2026
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-10-apply-overlays
branch
from
October 6, 2026 10:27
526c787 to
96eef5d
Compare
Contributor
Author
|
PR approved. Marking ready for e2e. |
…/apply_all)
With remote_config.mode apply_safe or apply_all the reconciler polls the API
for the configuration overlay and applies it on top of the file:
- Fetch every poll_interval (±10%) with the cached raw ETag as
If-None-Match; a 304 keeps the cached overlay, and the API's error table
applies to fetches as to reports (R7, R8).
- prepare decodes the overlay strictly (unknown keys and non-string values
reject it, R27), runs the agentconfig Classify + WillApply gate against
the agent's own base and remote_config before anything touches the
network, merges it (RFC 7396) and validates the result. Errors at
pointers the overlay touched are strict; file-origin ones keep the R34
tolerance.
- A rejected revision is remembered per (ETag, base fingerprint), or per
revision + overlay hash without an ETag, with its reason, error and
unsafe changes; it is not re-prepared every poll, is re-reported after a
restart, and a base change re-classifies it. A failed revision (download,
run) is retried with the failed backoff.
- Startup tries the fetched overlay, then the cached applied one, then the
file alone. A no-op revision is recorded as applied without a restart.
- Reports carry the applied and attempted revisions and the unsafe
changes; evidence produced under an overlay carries the
agent-config-revision prop (R38).
${env:NAME} placeholders in plugin config are resolved in the next PR;
until then they reach plugins unchanged, as on main.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nstants The runner drops a plugin's agent-config-revision by these constants, so the agent stamps it with the same ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A rejection of an overlay served without an ETag is keyed by revision and sha256(overlay), and sameOverlay compares overlay bytes. fetch now stores the body in agentstate.CanonicalOverlay form, the form the cache saves and loads, so a remembered no-ETag rejection is still recognised after a restart, on the cached copy and on a fresh 200 body. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Disabling a plugin is safe; re-enabling one the file disables is unsafe
unless its source is trusted, and its kept policies, local source and
${env:} references are classified as new. Only enabled plugins' sources
count as already used.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-10-apply-overlays
branch
from
October 6, 2026 15:59
96eef5d to
ffed654
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 10/11 of the split of #95 (agent remote configuration) into a stack. Review it as the diff against its base branch.
With remote_config.mode apply_safe or apply_all the reconciler polls the API
for the configuration overlay and applies it on top of the file:
If-None-Match; a 304 keeps the cached overlay, and the API's error table
applies to fetches as to reports (R7, R8).
reject it, R27), runs the agentconfig Classify + WillApply gate against
the agent's own base and remote_config before anything touches the
network, merges it (RFC 7396) and validates the result. Errors at
pointers the overlay touched are strict; file-origin ones keep the R34
tolerance.
revision + overlay hash without an ETag, with its reason, error and
unsafe changes; it is not re-prepared every poll, is re-reported after a
restart, and a base change re-classifies it. A failed revision (download,
run) is retried with the failed backoff.
file alone. A no-op revision is recorded as applied without a restart.
changes; evidence produced under an overlay carries the
agent-config-revision prop (R38).
${env:NAME} placeholders in plugin config are resolved in the next PR;
until then they reach plugins unchanged, as on main.
size-exception: 1417 LOC, of which ~780 are tests (cmd/remote_test.go, 700 lines). The production code is ~640 LOC; the overlay cache was already split out into #109.Size: 1417 lines changed (go.mod/go.sum excluded). Builds, vets, is gofmt-clean and passes
go test -race ./...on its own; the top of the stack is byte-identical to #95 merged withmain.Stack
🤖 Generated with Claude Code