Repository navigation
feat(agent): stable instance ID and per-instance state directory - #104
Merged
gusfcarvalho merged 1 commit intoOct 6, 2026
Merged
gusfcarvalho merged 1 commit into
gusfcarvalho merged 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 5, 2026
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-04-instance-id
branch
from
October 6, 2026 10:27
3427759 to
80f0c36
Compare
Contributor
Author
|
PR approved. Marking ready for e2e. |
The heartbeat used a new random UUID every run, so every restart looked like a new agent. Each instance now has a stable ID (R31) kept in a state directory: - internal/agentstate: Store opens the state directory (0700), probes it and keeps working in memory when it is not writable; InstanceID reads, creates or replaces a corrupt instance-id file atomically. - The directory defaults to .compliance-framework/state/<sha256(abs config path)[:16]>; --state-dir / CCF_STATE_DIR pin it, --instance-id / CCF_INSTANCE_ID pin the ID (not persisted). The agent logs where state lives at startup, since moving the config file creates a new instance (R52). - AgentRunner takes the ID (WithInstanceID) and the heartbeat uses it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-04-instance-id
branch
from
October 6, 2026 15:59
80f0c36 to
80ee3e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4/11 of the split of #95 (agent remote configuration) into a stack. Review it as the diff against its base branch.
The heartbeat used a new random UUID every run, so every restart looked
like a new agent. Each instance now has a stable ID (R31) kept in a state
directory:
and keeps working in memory when it is not writable; InstanceID reads,
creates or replaces a corrupt instance-id file atomically.
path)[:16]>; --state-dir / CCF_STATE_DIR pin it, --instance-id /
CCF_INSTANCE_ID pin the ID (not persisted). The agent logs where state
lives at startup, since moving the config file creates a new instance (R52).
The heartbeat test lives in
cmd/reconciler_test.go, the file the reconciler PR (#106) fills in, so the final layout matches.Size: 443 lines changed (go.mod/go.sum excluded). Builds, vets, is gofmt-clean and passes
go test -race ./...on its own; the top of the stack is byte-identical to #95 merged withmain.Stack
🤖 Generated with Claude Code