Skip to content

feat(agent): stable instance ID and per-instance state directory - #104

Merged
gusfcarvalho merged 1 commit into
lisa/agent-config-03-declared-configfrom
lisa/agent-config-04-instance-id
Oct 6, 2026
Merged

gusfcarvalho merged 1 commit into
lisa/agent-config-03-declared-configfrom
lisa/agent-config-04-instance-id

Conversation

@ccf-lisa

@ccf-lisa ccf-lisa Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Part 4/11 of the split of #95 (agent remote configuration) into a stack. Review it as the diff against its base branch.

The heartbeat used a new random UUID every run, so every restart looked
like a new agent. Each instance now has a stable ID (R31) kept in a state
directory:

  • internal/agentstate: Store opens the state directory (0700), probes it
    and keeps working in memory when it is not writable; InstanceID reads,
    creates or replaces a corrupt instance-id file atomically.
  • The directory defaults to .compliance-framework/state/<sha256(abs config
    path)[:16]>; --state-dir / CCF_STATE_DIR pin it, --instance-id /
    CCF_INSTANCE_ID pin the ID (not persisted). The agent logs where state
    lives at startup, since moving the config file creates a new instance (R52).
  • AgentRunner takes the ID (WithInstanceID) and the heartbeat uses it.

The heartbeat test lives in cmd/reconciler_test.go, the file the reconciler PR (#106) fills in, so the final layout matches.

Size: 443 lines changed (go.mod/go.sum excluded). Builds, vets, is gofmt-clean and passes go test -race ./... on its own; the top of the stack is byte-identical to #95 merged with main.

Stack
  1. test: pin agent configuration hashes and evidence seeds #101 test: pin agent configuration hashes and evidence seeds
  2. feat(runner): policy source from the _policy_path label; extra evidence props #102 feat(runner): policy source from the _policy_path label; extra evidence props
  3. refactor(config): adopt api/pkg/agentconfig as the declared config #103 refactor(config): adopt api/pkg/agentconfig as the declared config
  4. 👉 feat(agent): stable instance ID and per-instance state directory #104 feat(agent): stable instance ID and per-instance state directory
  5. feat(agent): AgentRunner primitives for prepare-then-cancel reloads #105 feat(agent): AgentRunner primitives for prepare-then-cancel reloads
  6. feat(agent): prepare-then-cancel config file reloads #106 feat(agent): prepare-then-cancel config file reloads
  7. feat(pluginlib): read the agent library version a plugin binary was built with #107 feat(pluginlib): read the agent library version a plugin binary was built with
  8. feat(agent): report the configuration to the API (remote_config off/report) #108 feat(agent): report the configuration to the API (remote_config off/report)
  9. feat(agentstate): persisted cache for the remote configuration overlay #109 feat(agentstate): persisted cache for the remote configuration overlay
  10. feat(agent): pull and apply remote configuration overlays (apply_safe/apply_all) #110 feat(agent): pull and apply remote configuration overlays (apply_safe/apply_all)
  11. feat(config): ${env:NAME} placeholders in plugin config; ADR 0003 #111 feat(config): ${env:NAME} placeholders in plugin config; ADR 0003

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 528106be-2190-447e-b37e-544bea72f051

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gusfcarvalho gusfcarvalho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ccf-review: APPROVE

no findings.

Stack (gh stack 112): #101 → #102 → #103 → #104 → #105 → #106 → #107 → #108 → #109 → #110 → #111

@ccf-lisa
ccf-lisa Bot force-pushed the lisa/agent-config-04-instance-id branch from 3427759 to 80f0c36 Compare October 6, 2026 10:27
@ccf-lisa

ccf-lisa Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor Author

PR approved. Marking ready for e2e.

The heartbeat used a new random UUID every run, so every restart looked
like a new agent. Each instance now has a stable ID (R31) kept in a state
directory:

- internal/agentstate: Store opens the state directory (0700), probes it
  and keeps working in memory when it is not writable; InstanceID reads,
  creates or replaces a corrupt instance-id file atomically.
- The directory defaults to .compliance-framework/state/<sha256(abs config
  path)[:16]>; --state-dir / CCF_STATE_DIR pin it, --instance-id /
  CCF_INSTANCE_ID pin the ID (not persisted). The agent logs where state
  lives at startup, since moving the config file creates a new instance (R52).
- AgentRunner takes the ID (WithInstanceID) and the heartbeat uses it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ccf-lisa
ccf-lisa Bot force-pushed the lisa/agent-config-04-instance-id branch from 80f0c36 to 80ee3e4 Compare October 6, 2026 15:59
@gusfcarvalho
gusfcarvalho merged commit 3efe7e2 into main Oct 6, 2026
9 checks passed
@gusfcarvalho
gusfcarvalho deleted the lisa/agent-config-04-instance-id branch October 6, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant