Repository navigation
feat(agentstate): persisted cache for the remote configuration overlay - #109
Merged
gusfcarvalho merged 2 commits intoOct 6, 2026
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 5, 2026
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-09-overlay-cache
branch
from
October 6, 2026 10:27
2b90d7e to
c779e2b
Compare
Contributor
Author
|
PR approved. Marking ready for e2e. |
<state>/remote-config.json (0600, written atomically) keeps the last fetched and applied overlay with its raw ETag, and the rejected-revision memory, so the next PR can keep running the last good overlay while the API is unreachable and re-report a rejection after a restart (R7). - The cache is bound to api.url and api.auth.client_id: a mismatch discards it. - A checksum detects corruption; LoadCache returns ErrCacheCorrupt and an empty cache so the agent continues without it. - IfNoneMatch returns the raw ETag the API sent, never one built from a revision number. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
SaveCache wrote the overlay with json.MarshalIndent, which re-indents a json.RawMessage and escapes <, > and &, and LoadCache returned those bytes. Anything hashed from the overlay (the no-ETag rejection key) changed across a restart. CanonicalOverlay gives the compact, HTML-escaped form a round trip yields. SaveCache and LoadCache rewrite the applied and fetched overlays to it; the checksum, computed over the same compact form, is unchanged, so existing caches still load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ccf-lisa
Bot
force-pushed
the
lisa/agent-config-09-overlay-cache
branch
from
October 6, 2026 15:59
c779e2b to
c435ecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 9/11 of the split of #95 (agent remote configuration) into a stack. Review it as the diff against its base branch.
/remote-config.json (0600, written atomically) keeps the last fetched
and applied overlay with its raw ETag, and the rejected-revision memory, so
the next PR can keep running the last good overlay while the API is
unreachable and re-report a rejection after a restart (R7).
discards it.
empty cache so the agent continues without it.
revision number.
Size: 203 lines changed (go.mod/go.sum excluded). Builds, vets, is gofmt-clean and passes
go test -race ./...on its own; the top of the stack is byte-identical to #95 merged withmain.Stack
🤖 Generated with Claude Code