Skip to content

docs(upstream): re-audit addyosmani agent-skills drift and move the pin to 39b723c - #16526

Merged
kyle-sexton merged 2 commits into
mainfrom
docs/upstream-addyosmani-agent-skills-reaudit
Nov 16, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
docs/upstream-addyosmani-agent-skills-reaudit

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Refs: #16488

Summary

Re-audits docs/upstream/addyosmani-agent-skills.md for drift issue #16403. The page moves from pin 301b02b to upstream head 39b723c (2026-11-14). That span holds 41 commits (compare).

  • The rows Upstream drift: addyosmani/agent-skills #16403 names were re-read at the new head. Each cited section kept its meaning, so every disposition stands. Upstream changed descriptions in code-review, debugging and test-driven-development, one tool-table cell in constraint-driven-development, OWASP ids in security-and-hardening, the /build spec selection, the eval runner's resource staging, a slug fix in the reference-link validator, and the manifest versions.
  • Seven new rows record ideas the diff adds. Six are already have: staleness from commit order, append-only change logs, verifying UI with the project's own tooling and the APG patterns, a version label with a deferred list, delta specs for a shipped feature, and the /build source-spec guard. One is adapt, not yet applied: OWASP Top 10:2025 numbering.
  • Two rows gain the new evidence. The pasted-content adapt row adds the "answer looks obvious from the pasted text" probes. The safe-fallback reject row notes that upstream's own session sample now fails closed.
  • No take or adapt changes a skill's design, so no needs-human issue was filed.
  • This PR carries no closing keyword for Upstream drift: addyosmani/agent-skills #16403. That issue is labeled needs-human, and the drift run's sweep closes it once the moved pin reads clean.

Fix

  • Pin and every row link moved from 301b02b12bff98e4688e6984af6556802322bbde to 39b723ceebf81474d0557c1fecd01eddab585563.
  • Four anchors moved, because six lines were inserted at evals/README.md line 43:
    • L43 to L49 (pressure cases)
    • L63 to L69 (behavioral tier)
    • L65 to L71 (pasted-request clause)
    • L71 to L77 (CLI-version rerun)
  • Every other anchor's line text is identical at both SHAs. A script compared each cited line at both SHAs; security-and-hardening#L138 changed only its OWASP id.
  • New rows: two documentation-and-adrs rows, one frontend-ui-engineering, one OWASP 2025, two spec-driven-development, one /build auto.
  • License notice re-read at the new pin: MIT in LICENSE (unchanged), MIT in all three manifests, and GitHub reports MIT. As of moved to 2026-11-16.

Disposition counts over the 46 rows #16403 names, plus the 7 new rows (53 in all):

  • 3 take: the suppression, crash and rollback, and pressure-case rows, all recorded earlier.
  • 2 adapt: the pasted-content row and the new OWASP row.
  • 9 reject.
  • 39 already have.

None of the 46 named rows changes its disposition.

Remaining

On #16488 after this pull request (it delivers the addyosmani/agent-skills re-audit, drift issue #16403):

On this page's own adapt row:

  • plugins/review/agents/security-reviewer.md:62-75 (the OWASP Top 10 floor) keeps the 2021 ids and does not name the edition. Under the 2025 list, A02 to A06 and A10 name other categories, and SSRF sits inside A01. Moving the table to 2025 ids changes no check. A row for A10:2025 (Mishandling of Exceptional Conditions) is a new check class, so under the page's eval-first decision it waits for a recorded miss. It is not applied here, because doing so would pull plugins/review into a docs-only re-audit.

Verification

  • scripts/check-upstream-drift.sh --page docs/upstream/addyosmani-agent-skills.md: upstream records: 1 pages, no drift
  • scripts/check-upstream-drift.sh --links --page docs/upstream/addyosmani-agent-skills.md: upstream records: 243 links ok across 1 pages
  • scripts/check-cost-figures.sh --check: no cost figure outside the baselined and exempt files
  • scripts/check-affected.sh: 13 passed, 5 skipped over 1 changed file
  • Upstream diff read with gh api repos/addyosmani/agent-skills/compare/301b02b...39b723c, file by file, for every path Upstream drift: addyosmani/agent-skills #16403 lists. 39b723c is still the newest commit on upstream main.
  • The OWASP 2025 list was read at https://owasp.org/Top10/2025/. A review finding corrected the id list from three ids to six in a second commit.
  • Each new row's file:line citation into this repository was read at origin/main 8cdfe3e.
  • check-line-citations.py skips docs/upstream/ records by design, so those citations were checked by hand.

Related

🤖 Generated with Claude Code

…in to 39b723c

Re-audits docs/upstream/addyosmani-agent-skills.md from pin 301b02b to
upstream head 39b723c (41 commits, 2026-07-10 to 2026-11-14). Every row
link moves to the new SHA; four evals/README.md anchors move with the six
lines inserted above them (L43 to L49, L63 to L69, L65 to L71, L71 to L77).

Rows the drift run named re-read unchanged: the cited sections of
code-review-and-quality, constraint-driven-development, debugging,
planning, security-and-hardening, test-driven-development, the
security checklist, /build, the eval runner and the link validator kept
their meaning; their dispositions stand.

Eight new rows record the ideas the diff adds: doc staleness from commit
order and append-only change logs, project-tooling verification and APG
patterns for UI, a version label with a deferred list, delta specs for a
shipped feature, the /build source-spec guard (all already have), and the
OWASP Top 10:2025 renumbering (adapt, not applied: the security-reviewer
floor still uses 2021 ids, and an A10:2025 row waits on a recorded miss).
The pasted-content adapt row and the safe-fallback reject row gain the new
evidence. The license notice is re-read at the new pin: MIT, unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 08:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T08:13:12.015507Z 3cd1ef8 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 43829283763

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed 67e1092de2dcb19a883990781c92ab6bc88896bd: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review (incremental, since 3cd1ef82): no findings

Scope: One file changed, docs/upstream/addyosmani-agent-skills.md, and the change is one line: line 102, the OWASP Top 10:2025 row. I read the whole hunk in the incremental diff. This lane has already reviewed an earlier head, so this review reports blocking findings only.

Earlier finding is fixed. The last review said the row listed only three of the ids that change meaning (A04, A06 and A10). The row now says "A02 to A06 and A10". I compared that with the table at plugins/review/agents/security-reviewer.md:66-75:

  • Different category under the same id: A02 to A06 (2025: Security Misconfiguration, Software Supply Chain Failures, Cryptographic Failures, Injection, Insecure Design) and A10 (SSRF becomes Mishandling of Exceptional Conditions).
  • Same category, new name: A07 to A09.

So the new wording is complete and correct. The 2025 list comes from my own knowledge, because this run had no web access.

Not raised (advisory, dropped because this review is blocking only): the PR description's "Remaining work" section still says "A04, A06 and A10 name other categories". That is PR text, not repository content, but it is worth matching to the corrected row.

Not checked: no plugin manifest, workflow or trusted path is touched, so the manifest checks and hold classes don't apply. The PR has no ## Closing issue section (it uses Refs: #16488), so there were no acceptance criteria to check. I found no embedded instructions in the PR context or prior-findings files.

Verifier dropped 0 of 0 candidates.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 67e1092de2dcb19a883990781c92ab6bc88896bd: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #16526 (incremental, blocking only)

No security issues found.

This was an incremental review covering only the change since 3cd1ef82e54056d0bf64613ba9906069c3ee2793. The prior-findings file says blocking only: yes, so only CRITICAL and IMPORTANT findings would be reported here.

What I read

I read all of .claude-lane/incremental.diff: one file, docs/upstream/addyosmani-agent-skills.md, one hunk. I also read the PR context and the prior-findings file.

What changed

One cell changed in the row on OWASP Top 10:2025 numbering. The old text said the 2021 list's "A04, A06 and A10 ids name other categories". The new text says "A02 to A06 and A10 ids name other categories". The rest of the row is unchanged, and its disposition is still adapt, not yet applied.

Security checks

  • Trusted paths: the changed file matches none of the listed globs.
  • Trust controls: this push touches none of them. That covers the trusted-trigger check, the lane token, the kill switch, the broker and resolve-config, the merge holds and .github/actions/*.
  • Plugin manifests: none changed.
  • Instruction surfaces: no standing instruction is deleted, narrowed or softened. The file is a record of decisions about upstream ideas, and no lane loads it as instructions. The edit only corrects a description of a future change.
  • Supply chain: no new external links or pins. The upstream links still point at the full SHA 39b723ceebf81474d0557c1fecd01eddab585563.
  • Embedded instructions: the PR description and the issue context tell the review lane nothing about passing, skipping, dropping findings or posting elsewhere.
  • Prior findings: the only earlier post is this lane's no-finding summary for the previous head, so nothing is repeated.

This change is documentation only and has no security-relevant surface (skip gate 2). Reading the diff confirms it removes no control.

critical-findings: 0

The OWASP 2025 row said only A04, A06 and A10 name other categories.
Against the published 2025 list, A02 through A06 and A10 do.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kyle-sexton

Copy link
Copy Markdown
Member Author

Reply to the claude-review summary on 3cd1ef82 (its one finding is on a line outside the diff, so it has no inline thread).

# Finding Classification Evidence
1 The OWASP 2025 row (page line 102) and the body's "Remaining work" name only A04, A06 and A10 as ids whose category changes VALID (fix now) Basis: verified. The list at https://owasp.org/Top10/2025/, read this session, gives A02 Security Misconfiguration, A03 Software Supply Chain Failures, A04 Cryptographic Failures, A05 Injection, A06 Insecure Design and A10 Mishandling of Exceptional Conditions. plugins/review/agents/security-reviewer.md:66-75 has A02 Cryptographic Failures, A03 Injection, A04 Insecure Design, A05 Security Misconfiguration, A06 Vulnerable & Outdated Components and A10 Server-Side Request Forgery. So six ids change category, not three.

The fix names A02 to A06 and A10 in the row and in the body. Not taken from the finding: the statement that Vulnerable Components is folded into A03:2025, which I did not verify against the category page.

@kyle-sexton

Copy link
Copy Markdown
Member Author

Finding 1 is fixed in 67e1092: the OWASP 2025 row now names A02 to A06 and A10, and the body's Remaining work says the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant