Skip to content

docs(upstream): re-audit emilkowalski/skills drift and move the pin to 64eb3de - #16534

Merged
kyle-sexton merged 2 commits into
mainfrom
docs/upstream-emilkowalski-skills-reaudit
Nov 16, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
docs/upstream-emilkowalski-skills-reaudit

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

No related issue: the drift issue for this upstream is Bot-written, so it cannot be this pull request's spec, and the verifier's drift-issue rule covers only a change confined to the pinned page, which this is not (it applies takes to plugin files). Owner decision, 2026-11-16: link this one without an issue and close the drift issue by hand after merge.

Summary

Re-audits docs/upstream/emilkowalski-skills.md for drift issue #14737. The pin moves from 5206a95 to upstream head 64eb3de (2026-11-15). That span holds 8 commits (compare). Most of the change is upstream's "Fix wrong APIs and cross-skill contradictions" commit, plus two new skills, learn-taste and ask-emil.

The drift issue lists 28 entries: 26 changed paths (23 attribution rows and 3 config-key rows) and 2 new units. Disposition counts over those 28 entries:

  • 3 take: README (the skill list), animation-vocabulary, mobile-native.
  • 3 adapt: choreograph SKILL.md, break-ui SKILL.md, and learn-taste. The learn-taste adapt is not applied: it changes a skill's design, so it is filed as #16532 (needs-human).
  • 5 reject: choreograph RECIPES.md, animate RECIPES.md, improve-animations SKILL.md, PLAN-TEMPLATE.md, pick-ui-library.
  • 17 already-have: the other 13 attribution rows, the 3 config-key rows, and ask-emil.

Three Map units changed upstream: animate-expo, ask-sonner and write-swift. A Map unit counts only when it is removed, so they are not drift and the issue does not list them.

This PR carries no closing keyword for #14737. That issue is labeled needs-human, and the drift run closes it once the moved pin reads clean.

Fix

The page:

  • Moves the pin and every link, ## Map and the compare pointer included, to 64eb3deb9a5fbfa041faf783e0bc3fd635872e9c. No old-SHA link remains (grep -c = 0). The marker date is now 2026-11-15T12:42:50Z. Upstream has no tags and no releases (gh api count 0 each).
  • Updates the README row:
    • upstream's list gains learn-taste and ask-emil and drops write-swift (18 entries before, 19 after);
    • the per-skill site links are rejected along with the newsletter.
  • Choreograph SKILL.md row: rejects the click-gate flag. Upstream removed it, and our stagger rule keeps input open.
  • Choreograph RECIPES.md row: rewrites its "already covered" clause. Upstream replaced the index-variable stagger with hand-set per-item delays. section-entrance keeps index × animation.stagger_ms.section, and the shrinking-gap guidance lives in the catalog's choreography.
  • Gestures row: records the bounce ceiling as already covered, and the CSS-only library release as a run-time lookup.
  • animation-performance row: records the opacity-then-visibility swap as already covered (accessibility.md section 5).
  • break-ui row: takes the suffix-skipping initials and "no limit found", and rejects the fix-by-number replies and the toggle checks.
  • mobile-native row: takes the status-bar keyword fix.
  • Adds a learn-taste row (adapt, not applied, corrections: decide whether to harvest a session's design corrections into DESIGN.md (adapt emilkowalski/skills learn-taste) #16532), and adds ask-emil to ## Map. /session-flow:recommend-skills and user-interface routing.json already route.
  • LICENSE is byte-identical at both SHAs (cmp).

Shipped text the diff showed was wrong or contradictory here:

  • user-interface reference/types/web/theming.md: apple-mobile-web-app-status-bar-style takes a style keyword, not a color. The text points at Apple's Supported Meta Tags entry, which lists default, black and black-translucent. The pointer's As of moves to 2026-11-16 after re-reading each source in its recheck trigger: MDN theme-color, Next.js themeColor, MDN manifest theme_color, and the Apple guide.
  • user-interface reference/animation/catalog.md choreography item 9 drops the input-gate sentence. It now says input is never held until a buildup finishes, matching stagger (catalog.md:376-377) and gestures.md:54.
  • user-interface glossary: the perceptual duration line now reads as a definition.
  • testing run-e2e/context/worst-case.md:
    • the initials fix skips a generational suffix, so the catalog's own … Montgomery III row no longer yields CI;
    • a field with no limit is reported as "no limit found".
  • Changelog fragments for user-interface and testing (patch).

The config-key rows hold: every value behind them is still present at the head. That covers 0.97, 0.95-0.98 and ~0.11 in emil-design-eng, 0.998, 0.55, ~10px and the response table in apple-design, and 10% playback in PLAN-TEMPLATE.md. Each was compared with reference/defaults.yaml.

Verification

  • scripts/check-upstream-drift.sh --page docs/upstream/emilkowalski-skills.md: upstream records: 1 pages, no drift
  • scripts/check-upstream-drift.sh --links --page docs/upstream/emilkowalski-skills.md: upstream records: 37 links ok across 1 pages
  • scripts/check-affected.sh --base origin/main --no-fetch: 16 passed, 2 skipped over 7 changed files
  • scripts/check-cost-figures.sh --check: no cost figure outside the baselined and exempt files
  • scripts/check-changelog-fragments.sh --check: all 6 fragments valid
  • scripts/check-as-of-recheck.sh --check: every as-of date has a recheck trigger
  • Upstream diff read file by file with gh api repos/emilkowalski/skills/compare/5206a95...64eb3de. 64eb3de was still upstream main just before the push.
  • The five-word test was run by script over the added lines against every upstream file at the head. No page cell shares a five-word run. The only matches are in shipped text that predates this change (the reauthor posture allows verbatim wording there) and in tag names.
  • Each phrase changed in shipped text was grepped across plugins/, docs/ and .github/, and no eval grader matches it.
  • check-line-citations.py skips docs/upstream/ records, so the row citations were checked by hand.

Remaining

#16486 is closed and delivered. This pull request applies its rule to drift issue #14737.

On this page:

  • learn-taste waits on the owner's decision in #16532.
  • The gestures row's deferred item stays deferred: dismissing in the direction an element entered.

Nothing else remains on this page.

Related

🤖 Generated with Claude Code

…o 64eb3de

Re-audits the 28 entries the drift issue lists (26 changed paths and two
new units) against upstream 64eb3deb9a5f: 3 take, 3 adapt, 5 reject,
17 already-have.

Shipped fixes the diff surfaced:
- user-interface: the iOS status-bar style tag takes a keyword, not a
  color; choreography no longer describes holding input until a buildup
  ends; the perceptual duration glossary line reads as a definition.
- testing: worst-case initials skip a generational suffix, and a missing
  limit is reported as "no limit found".

learn-taste is an adapt that changes a skill's design, filed as #16532.
ask-emil joins the Map.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 09:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T09:26:00.394903Z 1ccfc4b Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 43839534967

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 6c25ce18e008b2ddb0b9aceacd6eb79e2160c124: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review (incremental): no findings

Since 1ccfc4bc, the only change is to plugins/user-interface/reference/types/web/theming.md. It rewords one recheck-trigger bullet so the trigger also fires when Apple retires the Safari HTML Reference's meta tag page or changes the status-bar style keywords that page lists. The change is documentation prose only:

  • It touches no trusted path.
  • It changes no plugin manifest.
  • It removes or loosens no security, permission or trust instruction.
  • It runs no code and gives untrusted text no new way to reach a lane.

This review was blocking only, because the lane already reviewed an earlier head. I read the whole incremental change (1 of 1 file).

critical-findings: 0

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude-review: 1 inline finding(s) on 1ccfc4bc447764f99534b6cb588533bb9cd49a4b; the summary is in this lane's pull request comment.

claude-lane: claude-review

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed 6c25ce18e008b2ddb0b9aceacd6eb79e2160c124: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review (incremental, blocking only): 1ccfc4b → 6c25ce1

This push changes one file, plugins/user-interface/reference/types/web/theming.md, and I read its whole hunk. Because this lane already reviewed an earlier head, this review reports blocking findings only.

The earlier finding is fixed. The recheck trigger now also names the Safari HTML Reference's meta tag page and a change to the status-bar style keywords that page lists (theming.md:278-281). That covers the Supported Meta Tags pointer at lines 274-276, which the line 257-258 sentence depends on. The suggested wording was applied with "it lists" changed to "that page lists", which keeps the meaning. The owner resolved this thread and marked it fixed, so I am not raising it again.

No new findings. The edit only extends the trigger's text. The As of date and pointer list need no other change.

  • Manifests: this push changes no plugin manifest.
  • Closing issue: none. The PR says Refs: #16486 and has no closing keyword.
  • Paid spend: none.

Verifier dropped 0 of 0 candidates.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

The pr-verify verifier failed head 6c25ce18e008b2ddb0b9aceacd6eb79e2160c124. What it wrote, as data:

What it wrote (28 lines)
Summary: Fail on the spec. The spec is a `Refs: #16486` link, so this pull request has to deliver a
  named part of #16486, stay inside that issue's scope, and say what is left of it. #16486 covers
  the six drift issues #16403-#16408 (addyosmani, cursor, tstack, playwright, firecrawl, context7)
  plus the drift-contract rule. Its trusted record comment says all three of its done-when items are
  already delivered. This pull request re-audits emilkowalski/skills for drift issue #14737, which
  is not one of the six, so the work is outside #16486's scope. Its body also says "#16486 is closed
  and delivered" and names nothing left of that issue: its Remaining section lists only follow-ups
  on this one page. Under the refs rules, both facts are a fail. The content itself looks coherent.
  The pin and every link move to 64eb3de, each changed row gets a take, adapt, reject or
  already-have entry, and the design-changing `learn-taste` adapt is recorded as not applied and
  sent to #16532 (needs-human). The shipped-text fixes in theming.md, catalog.md, worst-case.md and
  the glossary match the row dispositions and come with changelog fragments. Every suite that ran on
  the judged head passed, including Test Bash (0)
  (https://github.com/melodic-software/claude-code-plugins/actions/runs/43841577073/job/133211515190),
  Lint Repo and Check Skills. The skipped Python and Node jobs do not cover these Markdown files.
  The capture is `blocked` (a credit stop), which says nothing for or against the change. The diff
  has no binary files and touches no secrets, settings, takeover-set files or owner holds.
- PR body (Refs: #16486): this re-audit of emilkowalski/skills (drift issue #14737) is outside
  #16486's scope, which covers only drift issues #16403-#16408 and the contract rule. Link a spec
  that covers this page instead: a trusted, human-written issue for the emilkowalski re-audit
  (`Closes` it), or a trusted pull-request-scoped spec.
- PR body, Remaining section: it says "#16486 is closed and delivered" and names no work left on the
  issue it refs. A `Refs:` pull request has to name the part of the issue it delivers and the part
  still owed, so either re-link as above or reword so the delivered part and the remaining work are
  both inside the linked issue's scope.
- PR body: drift issue #14737 is written with a fullwidth '#' everywhere, so GitHub never links it.
  This does not read as an attempt to steer a reviewer, but it hides the real target issue from the
  link-based spec lookup. Name the issue this work delivers with an ordinary link.

This pull request leaves the merge queue, and ci-status holds it out while it carries pr-verify-failed. A pr-verify pass removes the label, at a new commit or at this same head: once a trusted person edits the body, and only trusted people have edited it since the fail, this head is judged again, so a fail on the body or the issues it links needs only the body fixed, no new commit.

@github-actions github-actions Bot added the pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it. label Nov 16, 2026
…recheck trigger

The status-bar style sentence rests on Apple's Supported Meta Tags page,
which the trigger did not name.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@kyle-sexton kyle-sexton added the do-not-merge Hard merge gate: do not merge while applied. label Nov 16, 2026
@kyle-sexton

Copy link
Copy Markdown
Member Author

Waiting on the owner's linkage decision (hub Q193): the drift issue this re-audits was written by the drift bot, so pr-verify finds no trusted spec. Options: Closes the drift issue with the verifier accepting drift issues as specs (recommended), No related issue: naming the contract rule, or an owner line on the issue. ETA: the owner's morning report, about 8:45 AM EST.

@kyle-sexton kyle-sexton removed the do-not-merge Hard merge gate: do not merge while applied. label Nov 16, 2026
@github-actions github-actions Bot removed the pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it. label Nov 16, 2026
@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit f98d6db Nov 16, 2026
99 of 101 checks passed
@kyle-sexton
kyle-sexton deleted the docs/upstream-emilkowalski-skills-reaudit branch November 16, 2026 16:46
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant