Repository navigation
docs(upstream): re-audit emilkowalski/skills drift and move the pin to 64eb3de - #16534
Conversation
…o 64eb3de Re-audits the 28 entries the drift issue lists (26 changed paths and two new units) against upstream 64eb3deb9a5f: 3 take, 3 adapt, 5 reject, 17 already-have. Shipped fixes the diff surfaced: - user-interface: the iOS status-bar style tag takes a keyword, not a color; choreography no longer describes holding input until a buildup ends; the perceptual duration glossary line reads as a definition. - testing: worst-case initials skip a generational suffix, and a missing limit is reported as "no limit found". learn-taste is an adapt that changes a skill's design, filed as #16532. ask-emil joins the Map. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Security review (incremental): no findingsSince
This review was blocking only, because the lane already reviewed an earlier head. I read the whole incremental change (1 of 1 file). critical-findings: 0 |
|
claude-review reviewed Code review (incremental, blocking only): 1ccfc4b → 6c25ce1This push changes one file, The earlier finding is fixed. The recheck trigger now also names the Safari HTML Reference's meta tag page and a change to the status-bar style keywords that page lists (theming.md:278-281). That covers the Supported Meta Tags pointer at lines 274-276, which the line 257-258 sentence depends on. The suggested wording was applied with "it lists" changed to "that page lists", which keeps the meaning. The owner resolved this thread and marked it fixed, so I am not raising it again. No new findings. The edit only extends the trigger's text. The As of date and pointer list need no other change.
Verifier dropped 0 of 0 candidates. |
|
The pr-verify verifier failed head What it wrote (28 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
…recheck trigger The status-bar style sentence rests on Apple's Supported Meta Tags page, which the trigger did not name. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Waiting on the owner's linkage decision (hub Q193): the drift issue this re-audits was written by the drift bot, so pr-verify finds no trusted spec. Options: |
No related issue: the drift issue for this upstream is Bot-written, so it cannot be this pull request's spec, and the verifier's drift-issue rule covers only a change confined to the pinned page, which this is not (it applies takes to plugin files). Owner decision, 2026-11-16: link this one without an issue and close the drift issue by hand after merge.
Summary
Re-audits
docs/upstream/emilkowalski-skills.mdfor drift issue #14737. The pin moves from5206a95to upstream head64eb3de(2026-11-15). That span holds 8 commits (compare). Most of the change is upstream's "Fix wrong APIs and cross-skill contradictions" commit, plus two new skills,learn-tasteandask-emil.The drift issue lists 28 entries: 26 changed paths (23 attribution rows and 3 config-key rows) and 2 new units. Disposition counts over those 28 entries:
SKILL.md, break-uiSKILL.md, andlearn-taste. Thelearn-tasteadapt is not applied: it changes a skill's design, so it is filed as #16532 (needs-human).RECIPES.md, animateRECIPES.md, improve-animationsSKILL.md,PLAN-TEMPLATE.md, pick-ui-library.ask-emil.Three Map units changed upstream:
animate-expo,ask-sonnerandwrite-swift. A Map unit counts only when it is removed, so they are not drift and the issue does not list them.This PR carries no closing keyword for #14737. That issue is labeled
needs-human, and the drift run closes it once the moved pin reads clean.Fix
The page:
## Mapand the compare pointer included, to64eb3deb9a5fbfa041faf783e0bc3fd635872e9c. No old-SHA link remains (grep -c= 0). The marker date is now 2026-11-15T12:42:50Z. Upstream has no tags and no releases (gh apicount 0 each).learn-tasteandask-emiland dropswrite-swift(18 entries before, 19 after);SKILL.mdrow: rejects the click-gate flag. Upstream removed it, and ourstaggerrule keeps input open.RECIPES.mdrow: rewrites its "already covered" clause. Upstream replaced the index-variable stagger with hand-set per-item delays.section-entrancekeeps index ×animation.stagger_ms.section, and the shrinking-gap guidance lives in the catalog'schoreography.visibilityswap as already covered (accessibility.mdsection 5).learn-tasterow (adapt, not applied, corrections: decide whether to harvest a session's design corrections into DESIGN.md (adapt emilkowalski/skills learn-taste) #16532), and addsask-emilto## Map./session-flow:recommend-skillsanduser-interfacerouting.jsonalready route.cmp).Shipped text the diff showed was wrong or contradictory here:
user-interfacereference/types/web/theming.md:apple-mobile-web-app-status-bar-styletakes a style keyword, not a color. The text points at Apple's Supported Meta Tags entry, which listsdefault,blackandblack-translucent. The pointer's As of moves to 2026-11-16 after re-reading each source in its recheck trigger: MDN theme-color, Next.jsthemeColor, MDN manifesttheme_color, and the Apple guide.user-interfacereference/animation/catalog.mdchoreographyitem 9 drops the input-gate sentence. It now says input is never held until a buildup finishes, matchingstagger(catalog.md:376-377) andgestures.md:54.user-interfaceglossary: the perceptual duration line now reads as a definition.testingrun-e2e/context/worst-case.md:… Montgomery IIIrow no longer yieldsCI;user-interfaceandtesting(patch).The config-key rows hold: every value behind them is still present at the head. That covers
0.97,0.95-0.98and~0.11in emil-design-eng,0.998,0.55,~10pxand the response table in apple-design, and 10% playback inPLAN-TEMPLATE.md. Each was compared withreference/defaults.yaml.Verification
scripts/check-upstream-drift.sh --page docs/upstream/emilkowalski-skills.md:upstream records: 1 pages, no driftscripts/check-upstream-drift.sh --links --page docs/upstream/emilkowalski-skills.md:upstream records: 37 links ok across 1 pagesscripts/check-affected.sh --base origin/main --no-fetch: 16 passed, 2 skipped over 7 changed filesscripts/check-cost-figures.sh --check: no cost figure outside the baselined and exempt filesscripts/check-changelog-fragments.sh --check: all 6 fragments validscripts/check-as-of-recheck.sh --check: every as-of date has a recheck triggergh api repos/emilkowalski/skills/compare/5206a95...64eb3de.64eb3dewas still upstreammainjust before the push.plugins/,docs/and.github/, and no eval grader matches it.check-line-citations.pyskipsdocs/upstream/records, so the row citations were checked by hand.Remaining
#16486 is closed and delivered. This pull request applies its rule to drift issue #14737.
On this page:
learn-tastewaits on the owner's decision in #16532.Nothing else remains on this page.
Related
learn-taste, needs-human)🤖 Generated with Claude Code