Repository navigation
fix(review): cite the OWASP Top 10:2025 in the security reviewer's floor - #16536
Conversation
The OWASP floor in security-reviewer listed 2021 ids without naming the edition, so six of its ten ids named other categories under the 2025 list. The table now names the 2025 edition, links each id to its category page, and files every existing check under its 2025 id: SSRF joins A01:2025, outdated components become A03:2025, TLS misuse (CWE-295) moves to A07:2025 and verbose errors (CWE-209) to A10:2025, where the 2025 pages map them. No check is added or dropped. The tier-less design-review row is now A06:2025, here and in the findings-normalization crosswalk, so a crypto finding (A04:2025) is never read as tier-less. Missing CSP (CWE-1021) stays under A02:2025 because OWASP maps it to the tier-less A06:2025: #16535. The upstream record's OWASP Top 10:2025 numbering row is marked applied. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lane run report
Failed GitHub API calls
|
|
claude-review reviewed Code review: no findingsThe PR moves the What I checked (read in the diff and at head):
Closing issue: none. The PR says it closes no issue, so there are no acceptance criteria to check. The verification commands in the PR description are the author's claims. This lane has no shell, so I did not run them. Security review of this change belongs to the separate security lane. Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review: PR #16536, OWASP Top 10:2025 numberingNo security issues found. What changed. The PR renumbers the OWASP floor table in Instruction-surface check. The agent body is a standing instruction, so I compared every check in the old table with the new one. Each check is still present with the same wording, only filed under a new id:
No rule was deleted, narrowed or softened. The tier-less design-review row (now A06:2025) is still SUGGESTION plus Trusted paths. None of the four changed files match a TRUSTED PATHS glob. The diff touches no trust control, merge hold, token scope, kill switch or plugin manifest. PR context. It contains no embedded directives aimed at this lane. Spend. None: the change only edits documentation and agent text. critical-findings: 0 |
No related issue: a reference correction recorded as an adapt in the upstream record for addyosmani/agent-skills (#16526) and requested by the hub session; no human-written issue exists for it
Summary
The
security-revieweragent's OWASP floor listed 2021 ids without naming the edition, so under the OWASP Top 10:2025 six of its ten ids (A02 to A06, A10) named other categories. The table now names the 2025 edition, links each id to its category page, and files every existing check under its 2025 id. No check is added, dropped or reworded. The tier-less design-review row moves from A04 to A06:2025, andfindings-normalization.mdfollows it, so a crypto finding (A04:2025) is never read as tier-less.Fix
Category moves follow the 2025 introduction, which states that SSRF "has been rolled into" A01:2025 and that A03:2025 "is an expansion of A06:2021-Vulnerable and Outdated Components". Single-check moves follow each 2025 category page's mapped-CWE list.
Not moved, on purpose:
The upstream record row "OWASP Top 10:2025 numbering" in
docs/upstream/addyosmani-agent-skills.mdturns from "adapt, not yet applied" to "adapt, applied". A10:2025 holds an existing check (verbose errors), so no "no check recorded yet" row was needed and no new check class lands.Verification
scripts/check-changed-skills.sh origin/main: no changed skills, exit 0.markdownlint-cli2on the four changed files: 0 issues.scripts/check-affected.sh --base origin/main --no-fetch: 15 passed, 3 skipped over 4 changed files.scripts/check-upstream-drift.sh --page docs/upstream/addyosmani-agent-skills.md: no drift.--links: 638 links ok across 10 pages.scripts/check-as-of-recheck.sh --checkandscripts/check-cost-figures.sh --check: pass.scripts/check-changelog-fragments.sh --checkand--check-required origin/main,scripts/check-changelog-parity.sh --check-bump origin/main: pass.plugins/review/tests/turn-budget.test.sh,standards-binding.test.sh,change-set-block.test.sh: all pass.plugins/reviewquotes an OWASP id (git grepforA01-A10overplugins/review), so no case text changed.docs/review/skills-and-agents.md:7-11andskill-criteria.md:25-26require it for a cut to an existing skill; this change cuts no check and adds no standing instruction.Related
docs/upstream/addyosmani-agent-skills.md, row "OWASP Top 10:2025 numbering", and docs(upstream): re-audit addyosmani agent-skills drift and move the pin to 39b723c #16526.🤖 Generated with Claude Code