Skip to content

fix(review): cite the OWASP Top 10:2025 in the security reviewer's floor - #16536

Merged
kyle-sexton merged 1 commit into
mainfrom
fix/review-owasp-2025-numbering
Nov 16, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
fix/review-owasp-2025-numbering

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: a reference correction recorded as an adapt in the upstream record for addyosmani/agent-skills (#16526) and requested by the hub session; no human-written issue exists for it

Summary

The security-reviewer agent's OWASP floor listed 2021 ids without naming the edition, so under the OWASP Top 10:2025 six of its ten ids (A02 to A06, A10) named other categories. The table now names the 2025 edition, links each id to its category page, and files every existing check under its 2025 id. No check is added, dropped or reworded. The tier-less design-review row moves from A04 to A06:2025, and findings-normalization.md follows it, so a crypto finding (A04:2025) is never read as tier-less.

Fix

Category moves follow the 2025 introduction, which states that SSRF "has been rolled into" A01:2025 and that A03:2025 "is an expansion of A06:2021-Vulnerable and Outdated Components". Single-check moves follow each 2025 category page's mapped-CWE list.

2021 id (old row) Check 2025 id Source
A01 Broken Access Control IDOR (CWE-639), path traversal (CWE-22), missing authorization, opt-in authorization A01:2025 A01:2025
A02 Cryptographic Failures Weak crypto (CWE-326/327), JWT signing/validation, secrets in code A04:2025 A04:2025
A02 Cryptographic Failures TLS misuse (CWE-295) A07:2025 A07:2025 lists CWE-295
A03 Injection SQL (CWE-89), command (CWE-77/78), XSS (CWE-79) A05:2025 A05:2025
A04 Insecure Design Threat modeling, flag for design review, do not tier A06:2025 A06:2025
A05 Security Misconfiguration CORS (CWE-942), missing CSP (CWE-1021), cookie config (CWE-614/1004), debug endpoints (CWE-489) A02:2025 A02:2025; CWE-1021 see below
A05 Security Misconfiguration Verbose errors (CWE-209) A10:2025 A10:2025 lists CWE-209
A06 Vulnerable & Outdated Components Manifests and lockfiles, no audit command (CWE-1104) A03:2025 A03:2025, introduction
A07 Identification & Authentication Failures Session fixation (CWE-384), weak session IDs, JWT alg=none (CWE-345/347) A07:2025 A07:2025
A08 Software & Data Integrity Failures Insecure deserialization (CWE-502) A08:2025 A08:2025
A09 Security Logging & Monitoring Failures PII in logs, missing audit trail A09:2025 A09:2025
A10 Server-Side Request Forgery User-controlled URLs in HTTP clients (CWE-918), allowlist and private-IP block A01:2025 A01:2025 lists CWE-918; introduction

Not moved, on purpose:

The upstream record row "OWASP Top 10:2025 numbering" in docs/upstream/addyosmani-agent-skills.md turns from "adapt, not yet applied" to "adapt, applied". A10:2025 holds an existing check (verbose errors), so no "no check recorded yet" row was needed and no new check class lands.

Verification

  • scripts/check-changed-skills.sh origin/main: no changed skills, exit 0.
  • markdownlint-cli2 on the four changed files: 0 issues.
  • scripts/check-affected.sh --base origin/main --no-fetch: 15 passed, 3 skipped over 4 changed files.
  • scripts/check-upstream-drift.sh --page docs/upstream/addyosmani-agent-skills.md: no drift. --links: 638 links ok across 10 pages.
  • scripts/check-as-of-recheck.sh --check and scripts/check-cost-figures.sh --check: pass.
  • scripts/check-changelog-fragments.sh --check and --check-required origin/main, scripts/check-changelog-parity.sh --check-bump origin/main: pass.
  • plugins/review/tests/turn-budget.test.sh, standards-binding.test.sh, change-set-block.test.sh: all pass.
  • No eval case or grader in plugins/review quotes an OWASP id (git grep for A01-A10 over plugins/review), so no case text changed.
  • Eval evidence before merge: not required. docs/review/skills-and-agents.md:7-11 and skill-criteria.md:25-26 require it for a cut to an existing skill; this change cuts no check and adds no standing instruction.

Related

🤖 Generated with Claude Code

The OWASP floor in security-reviewer listed 2021 ids without naming the
edition, so six of its ten ids named other categories under the 2025
list. The table now names the 2025 edition, links each id to its
category page, and files every existing check under its 2025 id: SSRF
joins A01:2025, outdated components become A03:2025, TLS misuse
(CWE-295) moves to A07:2025 and verbose errors (CWE-209) to A10:2025,
where the 2025 pages map them. No check is added or dropped.

The tier-less design-review row is now A06:2025, here and in the
findings-normalization crosswalk, so a crypto finding (A04:2025) is
never read as tier-less. Missing CSP (CWE-1021) stays under A02:2025
because OWASP maps it to the tier-less A06:2025: #16535.

The upstream record's OWASP Top 10:2025 numbering row is marked applied.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 09:36
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T09:38:21.609537Z 0bffacd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 43841397286

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 0bffacd4af2b9d62f6e4aa7aa5ecf295b8931f25: read 4 of 4 changed file(s); 0 finding(s), 0 as inline comments.

Code review: no findings

The PR moves the security-reviewer agent's OWASP floor from the unnamed 2021 ids to the OWASP Top 10:2025. It also updates the two places in findings-normalization.md that name the tier-less row, and the matching row in the upstream record.

What I checked (read in the diff and at head):

  • The new table. In plugins/review/agents/security-reviewer.md lines 64–77, all ten 2025 ids have the right category names: A01 Broken Access Control, A02 Security Misconfiguration, A03 Software Supply Chain Failures, A04 Cryptographic Failures, A05 Injection, A06 Insecure Design, A07 Authentication Failures, A08 Software or Data Integrity Failures, A09 Security Logging and Alerting Failures, A10 Mishandling of Exceptional Conditions.
  • No check lost or added. I compared the base and head rows check by check:
    • SSRF (CWE-918) moved into A01.
    • TLS misuse (CWE-295) moved to A07.
    • Verbose errors (CWE-209) moved to A10.
    • Supply chain (CWE-1104) moved to A03.
    • Missing CSP stays tiered under A02, as the PR says it should.
    • No check text was reworded.
  • Tier-less row. The design-review row moved from A04 to A06:2025. Both findings-normalization.md references (lines 12 and 56) now say A06:2025, so a Cryptographic Failures finding (A04:2025) is no longer mistaken for tier-less.
  • Leftover 2021 ids. I searched plugins/ for bare A01–A10 ids. Apart from the changed files, the only hits are an old CHANGELOG entry and unrelated upstream-row ids in morning-brief. No other reviewer, skill or context file still uses an OWASP id that this change makes stale.
  • Changelog fragment. The bump: patch level fits a reference correction that adds no check. No plugin manifest changed, so the manifest checks don't apply.

Closing issue: none. The PR says it closes no issue, so there are no acceptance criteria to check.

The verification commands in the PR description are the author's claims. This lane has no shell, so I did not run them.

Security review of this change belongs to the separate security lane.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 0bffacd4af2b9d62f6e4aa7aa5ecf295b8931f25: read 4 of 4 changed file(s); 0 finding(s), 0 as inline comments.

Security review: PR #16536, OWASP Top 10:2025 numbering

No security issues found.

What changed. The PR renumbers the OWASP floor table in plugins/review/agents/security-reviewer.md from the 2021 ids to the 2025 ids and states which edition it uses. It updates the tier-less crosswalk entry in plugins/review/reference/findings-normalization.md from A04 to A06:2025, flips one row in the upstream record, and adds a changelog fragment.

Instruction-surface check. The agent body is a standing instruction, so I compared every check in the old table with the new one. Each check is still present with the same wording, only filed under a new id:

  • Moved to a new category:
    • SSRF (CWE-918) with the allowlist and private-IP block now sits in A01:2025.
    • TLS misuse (CWE-295) is now in A07:2025.
    • Verbose errors (CWE-209) are now in A10:2025.
    • The manifest and lockfile check with the run-no-audit-command rule (CWE-1104) is now in A03:2025.
  • Unchanged:
    • Weak crypto, JWT signing and validation, and secrets in code.
    • SQL injection, command injection and XSS.
    • CORS, CSP, cookie config and debug endpoints.
    • Session fixation, weak session IDs and JWT alg=none.
    • Deserialization.
    • PII in logs and the missing audit trail.

No rule was deleted, narrowed or softened. The tier-less design-review row (now A06:2025) is still SUGGESTION plus forward-flag: design-review in the crosswalk, and the two files agree. I did not consult the protected-class register because no rule was removed.

Trusted paths. None of the four changed files match a TRUSTED PATHS glob. The diff touches no trust control, merge hold, token scope, kill switch or plugin manifest.

PR context. It contains no embedded directives aimed at this lane.

Spend. None: the change only edits documentation and agent text.

critical-findings: 0

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 22e6084 Nov 16, 2026
79 checks passed
@kyle-sexton
kyle-sexton deleted the fix/review-owasp-2025-numbering branch November 16, 2026 09:55
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant