Skip to content

docs(upstream): re-audit cursor pstack drift and move the pin to bf0c7cd - #16525

Merged
kyle-sexton merged 1 commit into
mainfrom
docs/upstream-cursor-plugins-reaudit
Nov 16, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
docs/upstream-cursor-plugins-reaudit

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Refs: #16488

Summary

Re-audits the cursor/plugins pstack record for drift issue #16404. One upstream commit touched pstack/ since the pin (cursor/plugins#1236, 2026-11-15): it cut why to one paragraph and deleted its reference files, cut how to one subagent and deleted its prompts, replaced every other skill's call to how with an inline trace, changed the default models and setup-pstack's handling of old defaults, reworded sharpen's last sentence, and fixed statechart's Mermaid renderer. The pin moves to bf0c7cd80abdbf7fe47b634978a7d1b4071f71a7 (pstack 0.15.42), and each of the 20 drifted rows gets a Re-checked at bf0c7cd80a entry with its disposition.

No take or adapt changes a skill's design, so no needs-human issue was filed. The PR carries no closing keyword for #16404: that issue is labeled needs-human, and the weekly drift run closes it once the moved pin reads clean (scripts/check-upstream-drift.sh already reports this page clean).

Fix

docs/upstream/cursor-pstack.md:

  • Pin and all 180 upstream links moved from ec569379616a to bf0c7cd80abd; the intro paragraph records what the new commit changed.
  • why: already have (every rule we took is now ours alone in discovery:trace-intent); reject upstream's "commits and PRs first, other sources only when thin", because trace-intent decides no source is empty in advance (plugins/discovery/skills/trace-intent/SKILL.md:169-171). "The one deliberate departure" now records that upstream also answers from the record, not the code.
  • recall: already have; upstream's shared-record sweep now spawns its own per-source investigators, which is our 2026-11-12 decision.
  • how / investigation: already have; discovery:explore already runs in one fresh-context subagent.
  • setup-pstack: already have; its new # defaults: 2 marker solves stale defaults in a full-file rule, and /multi-agent:setup apply writes only the keys the user changes (plugins/multi-agent/skills/setup/SKILL.md:60-62).
  • sharpen: reject; the new sentence (prototype what an experiment can settle, leave only product and preference calls to the user) is recorded, and the deferral under discipline: sharpen skill #7566 stands because its reopen trigger has not fired.
  • teach, reflect, arena, blast-radius, autopilot-full/swarm, poteto-mode, hillclimb, perf-issue, multi-phase-plan, architect, no-comments/comment-sicko, refactoring, feature/bug-fix, poteto-help, docs/harness/claude-code.md: holds; the only changes are how replaced by an inline trace or default-model changes (machinery this record drops), and nothing we took moved.

Counts over upstream changes: take 0, adapt 0, reject 2, already-have 4; 15 rows hold with no new idea.

Verification

Run in the worktree against the commit on this branch:

  • scripts/check-upstream-drift.sh --links --page docs/upstream/cursor-pstack.md: upstream records: 179 links ok across 1 pages
  • scripts/check-upstream-drift.sh --page docs/upstream/cursor-pstack.md: upstream records: 1 pages, no drift
  • scripts/check-affected.sh --base origin/main --no-fetch: 13 passed, 5 skipped over 1 changed file
  • scripts/check-cost-figures.sh --check: no cost figure outside baselined and exempt files
  • python3 -I scripts/check-line-citations.py: no findings
  • scripts/check-purged-em-dashes.sh: no em dashes
  • scripts/check-changelog-fragments.sh --check: valid (docs/upstream is not a plugin, so no fragment is owed)

Upstream read with gh api repos/cursor/plugins/compare/ec569379616a4826b98f0f0a205dd3411b573611...bf0c7cd80abd: 9 commits, one touching pstack/; every changed pstack/ file's patch was read except the statechart scripts and tests.

Not verified: statechart's renderer and test changes were listed, not read. No row links them; its adoption (#15648) reads the skill at its then-current head.

Remaining

On #16488 after this pull request (it delivers the cursor/plugins re-audit, drift issue #16404):

Related

🤖 Generated with Claude Code

Re-audits docs/upstream/cursor-pstack.md from ec56937961 to bf0c7cd80a,
the one pstack commit since the pin (cursor/plugins#1236). Every row the
drift report named gets a bf0c7cd80a re-check with its disposition: why
and how were cut to one paragraph each, so the rules we took are now ours
alone; recall now matches our 2026-11-12 decision; setup-pstack's
defaults marker is already covered by multi-agent setup writing only
changed keys; sharpen stays deferred. No take or adapt changes a skill's
design.

Refs: #16488

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 08:08
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T08:10:16.298238Z 71495a6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 43828947919

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/apply-patch
Model rung 0
Leg base
Run job success
Activity step success
Commits pushed none recorded
Run 43828947919

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 71495a66213097cef26830508d41fbec866c68bb: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Chunk 1 of 2 (0 files)

Security review: chunk 1 of 2 (piece 1 of 2 of docs/upstream/cursor-pstack.md)

No security issues in this chunk.

I read all 8 hunks of this piece, from @@ -7,18 +7,27 @@ to @@ -344,19 +356,21 @@.

What the change does

This is a documentation-only edit to the record of what this repository took from cursor/plugins (pstack). It makes three kinds of change:

  • New pin: the "Last audited upstream state" line moves from cursor/plugins@ec569379616a… to cursor/plugins@bf0c7cd80abdbf7fe47b634978a7d1b4071f71a7.
  • Links: every upstream tree/ and blob/ link now points at the new full-length commit SHA.
  • Audit notes: the drifted table rows gain Re-checked at bf0c7cd80a notes, and the prose for "The one deliberate departure", arena and sharpen is updated to match.

What I checked

  • Trust controls and trusted paths: docs/upstream/** matches no TRUSTED PATHS: glob. The file is not part of the trusted-trigger check, the lane token broker, the kill switch, a merge hold or any .github/actions/ control, so it widens nothing.
  • Supply chain: the "pin" is a recorded upstream commit, not a dependency. Nothing is installed or run from it. Every upstream link uses a full 40-character immutable SHA rather than a branch name, so the record does not point at moving content.
  • Instruction surface: this file is not a standing instruction (it is not CLAUDE.md, AGENTS.md, a rules file, a skill or agent body, or a hook list). The diff deletes or softens no guardrail. The prose that changed records adoption decisions and grants no authority to any lane.
  • Manifests: no plugin.json or marketplace.json change in this chunk.
  • PR context: the description matches the diff. It contains no embedded directive aimed at the review lane.
  • Prior findings: none. blocking only: no, so this was a full review.

The protected-class list in the instruction-exception register was not needed: no standing instruction was removed or narrowed.

Spend: none. This is a docs-only change that turns on no billed resource and changes no lane behaviour.

Chunk 2 of 2 (1 files)

Security review, chunk 2 of 2: no security issues found.

This chunk is the single hunk @@ -393,88 +407,88 @@ of docs/upstream/cursor-pstack.md, the ## Map section. I read all of it.

  • What changed. Each of the 85 removed and 85 added lines is a Markdown link to github.com/cursor/plugins. Every link swaps the pinned commit ec569379616a4826b98f0f0a205dd3411b573611 for bf0c7cd80abdbf7fe47b634978a7d1b4071f71a7, and nothing else on the line changes: the unit names, owner lists and relative in-repo links are byte-identical. The new links still pin a full 40-character commit SHA, never a branch or tag. This matches the PR description, which says the pin moved to bf0c7cd (pstack 0.15.42).
  • Trusted paths. docs/upstream/** matches none of the listed globs.
  • Trust controls. The file is not a trust control, merge hold, workflow, action or plugin manifest. Nothing in this hunk changes who or what the automation trusts.
  • Instruction surface. No standing instruction is deleted, narrowed or softened. The file is an audit record of upstream drift, not a rules file, skill body, agent body or hook list.
  • Embedded text. The PR context file contains no directive aimed at the review lane.
  • Prior findings. None on record (earlier heads this lane reviewed: 0, blocking only: no), so this was a full review.

critical-findings: 0

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 71495a66213097cef26830508d41fbec866c68bb: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Chunk 1 of 2 (0 files)

Code review: chunk 1 of 2 (docs/upstream/cursor-pstack.md, piece 1 of 2)

No findings in this chunk.

I read all eight hunks in the chunk, from @@ -7,18 +7,27 @@ to @@ -344,19 +356,21 @@:

  • the intro paragraph that moves the pin
  • the 68-row attribution table
  • "The one deliberate departure"
  • the arena, tdd, bro and show-me-your-work sections
  • the sharpen / formal-verification section

What I checked

  • Pin swap. Every upstream link in these hunks moves from ec569379616a… to bf0c7cd80abd…. No link is left on the old pin.
  • Row tally. I counted 20 rows with a new Re-checked at bf0c7cd80a entry. That matches the PR body's 20 drifted rows. The PR body's counts also add up: 2 rejects (why, sharpen), 4 already-haves (why, recall, how, setup-pstack) and 15 holds.
  • Our own line citations. I opened the cited files at head and checked the lines against what the rows say:
    • plugins/discovery/skills/trace-intent/SKILL.md: the tier table at :96-109, the categories and skip rules at :136-171, the "deciding in advance that a source is empty" rule at :169-171, the three categories at :138-145 and the Sources consulted line at :184-186.
    • plugins/multi-agent/skills/setup/SKILL.md:60-62: setup writes only the keys the user asks to change and keeps the rest.
  • Consistency. The rewritten departure paragraph agrees with the new why row: upstream now answers from the record, not the code. The reworded sharpen bullet agrees with its row's new entry.

Not verified

  • I did not read upstream cursor/plugins at bf0c7cd80a. What each row says upstream changed is the author's claim.
  • The verification commands in the PR body (drift check, link check, citation check) are also the author's claim. I did not run them.

No closing issue states acceptance criteria. The PR refs #16488 and the drift issue but closes neither. The PR context and prior-findings files contain no embedded instructions. No manifest, userConfig or cost-bearing change is in scope.

Verifier dropped 0 of 0 candidates.

Chunk 2 of 2 (1 files)

Chunk 2 of 2: docs/upstream/cursor-pstack.md, hunk @@ -393,88 +407,88 @@ (the ## Map list)

I read the whole hunk. It only moves the pin. Each of the 85 removed map entries comes back as an added entry with the same unit name, the same link kind (tree/blob), the same upstream path and the same owner text. The only difference is the commit SHA, which goes from ec569379616a4826b98f0f0a205dd3411b573611 to bf0c7cd80abdbf7fe47b634978a7d1b4071f71a7. Every added line uses the full new SHA, so no link still points at the old pin and none has a truncated SHA. No owner disposition changed in this section. The relative links to in-repo skills (session-flow:recall, planning:draft-goal-condition, implementation:implement-dispatch, planning:plan, source-control:pull-request merge, testing:check-visual-parity) are the same as on the base branch.

The upstream change deleted the reference files under why and the prompts under how. The map links only to those skills' directories, which still exist according to the PR description, so it is not affected. The PR description says the link checker reported 179 links ok. That claim is the author's and I have not verified it: I have no shell or network access in this run.

  • Closing issue: the PR closes no issue (it says Refs: #16488 and has no closing keyword), so there are no acceptance criteria to check.
  • Embedded text: none found in the PR context.
  • Prior findings: none (0 earlier heads), and this was not a blocking-only review.
  • Spend: none. This is a docs-only change.

Findings in this chunk: none.

Verifier dropped 0 of 0 candidates.

critical-findings: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant