Repository navigation
docs(upstream): re-audit mattpocock sandcastle drift and move the pin to 0ed674e - #16533
kyle-sexton wants to merge 2 commits into
Conversation
… to 0ed674e Re-audits docs/upstream/mattpocock-sandcastle.md for drift issue #14738 and moves the pin from 3b7aa79 to 0ed674e (107 commits). The four drifted rows keep their dispositions: the cloud providers row (reject), run-with-extraction (already have; a lint-only change), .out-of-scope/ (already have; a prior request added and a stale escape hatch dropped) and .factory/ (reject; the task script now fails fast on a missing variable). Three new rows record ideas the provider diff adds: the engine exit status wrapper (reject), credential stripping from exec connection errors (already have) and container memory and process caps (reject). Two citations into this repository are re-pointed to their current lines, and the license notice is re-read at the new pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review (incremental, blocking only): no findingsScope. I read every hunk of the one file in the incremental scope, What changed. One table row changed: "Container memory and process caps". Its mechanism column used to say the memory limit comes "with swap set to the same value". It now says "a memory limit that allows no swap beyond it". The source link, the disposition (reject), the recheck trigger and the in-repository citations are all unchanged. Security surface.
Prior findings. This lane reviewed an earlier head ( No security issues found. critical-findings: 0 |
…anism The memory and process caps row shared a five-word run with the upstream docker.ts comment. Reworded it from the mechanism, and checked the cells of the four rows this re-audit wrote against the eight upstream provider files it cites with a 5-gram comparison: no other shared run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
claude-review reviewed Code review (incremental, blocking only): no findings. Since I read the whole incremental diff (1 of 1 files).
Verifier dropped 0 of 0 candidates. |
Lane run report
Failed GitHub API calls
|
|
The pr-verify verifier failed head What it wrote (26 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
Lane run report
Failed GitHub API calls
|
|
Waiting on the owner's linkage decision (hub Q193): the drift issue this re-audits was written by the drift bot, so pr-verify finds no trusted spec. Options: |
Refs: #16486
Summary
Re-audits
docs/upstream/mattpocock-sandcastle.mdfor drift issue #14738. The page moves from pin3b7aa79to upstream head0ed674e(2026-11-13), 107 commits (compare).src/sandboxes/), reject. The span fixes provider behavior and splits files for line limits; none of it is a reason to adopt a hosted vendor.run-with-extraction.ts, already have. The change is lint-only (a function rewritten as an arrow const)..out-of-scope/, already have. One prior request was appended, and a mention of a provider that does not exist was dropped..factory/, reject. The task script now fails fast when an environment variable is missing, and the daemon is still outside the repository.dockerorpodman.L2substrate is picked.needs-humanissue was filed.needs-human, and the drift run closes it once the moved pin reads clean.Fix
3b7aa7990dd0985139a6f667fcb62c35f2b38ba2to0ed674e5195b200d34bc4128eec33409f2952dcf. None of the files behind a line anchor changed in the span: of the compare's 163 changed files, 0 match an anchored path.engineExitStatus.ts,spritesExec.tsand thedocker.tsandpodman.tsresource options.collect-base-activity/action.yml:931to:936, the--json-schemaflag.triage/SKILL.md:386to:415, the rejected-concept ledger.LICENSEand inpackage.json, and GitHub reports MIT. As of moved to 2026-11-16.package.jsonstill says 0.14.0, so the page's 1.0.0 trigger has not fired.Disposition counts over the 7 rows this re-audit touches (the 4 named rows plus 3 new):
Across the whole page (25 rows): 3 adapt, 9 reject, 13 already have.
Verification
scripts/check-upstream-drift.sh --page docs/upstream/mattpocock-sandcastle.md:upstream records: 1 pages, no driftscripts/check-upstream-drift.sh --links --page docs/upstream/mattpocock-sandcastle.md:upstream records: 64 links ok across 1 pagesscripts/check-affected.sh --base origin/main --no-fetch: 13 passed, 5 skipped over 1 changed filescripts/check-cost-figures.sh --check: no cost figure outside the baselined and exempt filesscripts/check-changelog-fragments.sh --check: 4 fragments valid. This PR needs none, since no plugin file changes.gh api repos/mattpocock/sandcastle/compare/3b7aa79...0ed674e, patch by patch, for every path #14738 lists.0ed674ewas still the newest commit on upstreammainwhen this was committed.0ed674e.file:linecitation into this repository in the touched rows was read atorigin/main7019719822.check-line-citations.pyskipsdocs/upstream/records, so these were checked by hand..github/,plugins/andscripts/(notnode_modules) for an exit code or status defaulted to 0. It found one test stub; the other two hits are HTTP status reads..githubsuite and model-graded evals, since this is a docs-only change.Remaining
#16486 is closed and delivered. This PR applies its rule to drift issue #14738.
This page's earlier
adaptrows are unchanged by this re-audit and still owe their work:envLeaks.tsbehavior probe (ci(harness-ops): run the env-scrub probe cases once per Claude Code release from release intake #12836);protectGitMounts.tsacceptance tests, which wait for anL2substrate;agent-exploreone-off run, which is done by hand when the backlog grows.Related
🤖 Generated with Claude Code