Skip to content

chore(firecrawl): re-sync the update record with upstream SKILL.md b4d49850 - #16529

Merged
kyle-sexton merged 1 commit into
mainfrom
docs/upstream-firecrawl-revendor
Nov 16, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
docs/upstream-firecrawl-revendor

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Refs: #16488

Summary

Works drift issue #16407 (firecrawl/update), a pin=unknown vendored-skill row. Its check script, plugins/firecrawl/skills/update/scripts/update.sh --check, exited 1 because the upstream SKILL.md at https://www.firecrawl.dev/agent-onboarding/SKILL.md now hashes to b4d49850 against the recorded 646709de. The CLI half is clean: 1.29.0 is installed and is npm latest.

The skill keeps no copy of upstream (only its hash), so the re-audit read the whole current upstream page against /firecrawl:firecrawl and its context/ files, with the last sync's decisions (#13993) as the baseline. No skill text changes, and no take or adapt changes a skill's design, so no needs-human issue was filed. The PR carries no closing keyword for #16407: that issue is labeled needs-human, and the weekly drift run closes it once the row reads clean.

Fix

  • plugins/firecrawl/skills/update/upstream.md: written by update.sh --record-upstream (installs nothing): upstream SHA256 b4d49850499b9e55357a895be2292c6df8a51fee1f25a9e7536588160bb120a1, last sync 2026-11-16, CLI 1.29.0 and rollback target 1.26.24 unchanged.
  • .changes/firecrawl/docs-upstream-firecrawl-revendor-07f91827.md (patch): records the re-audit outcome.

Dispositions over the upstream page's ideas:

  • Already-have (6): parse -S (the --format summary shortcut) and parse -Q, doctor <job-id>, monitor, developer, the research index. The CLI-facing items were checked against the installed 1.29.0 firecrawl --help and firecrawl parse --help, not upstream's prose.
  • Reject (1 new): the experimental firecrawl x download. crawl and scrape with -o already save pages to disk, and the command is marked experimental.
  • Reject, as at the last sync (chore(firecrawl): re-sync with upstream SKILL.md and CLI 1.29.0 #13993): MCP-first install order, ChatGPT/Claude/Grok connectors (Path G), the keyless tier, Alexandria, workflow and build skills (setup build), init and its flags, the support endpoints, the official Claude Code plugin, and the AgentID, WorkOS ID-JAG and Stripe Projects credential paths. The wrapper uses the CLI with FIRECRAWL_API_KEY auth.

Counts: take 0, adapt 0, already-have 6, reject 1 new plus the carried-over set.

Verification

Run in the worktree on the pushed head:

  • update.sh --check before the re-pin: exit 1, upstream content changed since last sync; after it: exit 0, No drift. CLI and skill are in sync with upstream.
  • update.test.sh: All 95 checks passed.
  • scripts/check-affected.sh --base origin/main --no-fetch: 16 passed, 2 skipped over 2 changed files.
  • scripts/check-changelog-fragments.sh --check and --check-required origin/main: valid, the one changed plugin has a fragment.
  • scripts/check-cost-figures.sh --check: no cost figure outside baselined and exempt files. scripts/check-purged-em-dashes.sh: no em dashes.

Not verified:

  • An exact line diff of upstream from 646709de to b4d49850: the skill stores only the hash, and no archive copy was fetched. Ideas upstream added and later removed in that window are invisible to this audit.
  • scripts/check-upstream-drift.sh --page and --links: this row has no docs/upstream/ page to target; the row's own check is update.sh --check, run above.

Remaining

On #16488 after this pull request (it delivers the firecrawl/update re-audit, drift issue #16407):

Related

🤖 Generated with Claude Code

…d49850

The upstream-drift run flagged firecrawl/update: upstream SKILL.md hashes
to b4d49850 against the recorded 646709de. The CLI half is clean (1.29.0
is npm latest). update.sh --record-upstream moves the record; --check now
exits 0.

The re-audit of the upstream page changes no skill text: what it adds for
the CLI is already covered or, for the experimental x download, not
needed; its MCP-first, connector, Alexandria, workflow-skill and
credential paths stay out as at the last sync. The changelog fragment
records each disposition.

Refs: #16488

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 08:25
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T08:26:46.153112Z 89c7155 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 89c71550fd38073d0dbe2ab1dfa64b302224ea02: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

No security issues found.

I read both changed files in full:

  • plugins/firecrawl/skills/update/upstream.md changes two values in the sync record: the last-sync date and the recorded upstream SKILL.md SHA256 (646709de… becomes b4d49850…).
  • .changes/firecrawl/docs-upstream-firecrawl-revendor-07f91827.md is a new changelog fragment written only as prose.

update.sh uses the recorded hash only to detect drift: it compares the hash it fetches against the recorded one (update.sh#L124, #L160-L164). No vendored copy of upstream is kept or installed against that hash. The pinned CLI version (1.29.0) and the rollback target (1.26.24) are unchanged. As a result:

  • No dependency pin is loosened.
  • No plugin manifest is touched.
  • No trust control or trusted path is touched.
  • No standing instruction is deleted or softened.

The PR context file holds no embedded instructions aimed at this lane. This was a full first review, not a blocking-only one.

critical-findings: 0

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 89c71550fd38073d0dbe2ab1dfa64b302224ea02: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Code review: no findings

This PR updates the firecrawl sync record and adds a changelog fragment:

  • plugins/firecrawl/skills/update/upstream.md: the upstream SHA256 is now b4d49850…. The last-sync date moves to 2026-11-16. CLI 1.29.0 and rollback target 1.26.24 stay the same. The file is consistent with its header, which says it is written by update.sh --record-upstream.
  • .changes/firecrawl/docs-upstream-firecrawl-revendor-07f91827.md: a bump: patch fragment with a ### Changed entry. Patch is the right level: no skill text, behavior or manifest changes.

Checks:

  • Covered commands. The fragment says parse -S/-Q, doctor, monitor and developer are already covered. I searched plugins/firecrawl/skills/firecrawl/ for these terms and found matches in SKILL.md and context/commands.md. That supports the claim, but I did not check each item one by one.
  • Linked issue. The PR only refs docs(upstream): re-audit the six drifted upstream pages by agent, owner only for design changes - part 2 of 2 #16488 and closes no issue, so there are no acceptance criteria to check.
  • Manifests and rules. No plugin manifest changed. No path-scoped rule or paved-path check applies.
  • Author's verification, not checked by me. I ran none of it: update.sh --check passing after the re-pin, update.test.sh (95 checks) and the fragment checks. The PR also says the new upstream hash is not compared line by line against the old one, because no archive copy is kept.
  • Instructions in PR text. None found in the PR context.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown
Contributor

The pr-verify verifier failed head 89c71550fd38073d0dbe2ab1dfa64b302224ea02. What it wrote, as data:

What it wrote (24 lines)
Summary: This PR refs #16488 (part 2 of #16486). That issue asks for one merged PR per drift issue
  among #16403-#16408, each moving its pin and recording a take, adapt or reject for every changed
  row. The PR delivers one of those parts, the firecrawl/update drift (#16407). It re-pins
  plugins/firecrawl/skills/update/upstream.md to upstream SHA256 b4d49850 and moves the last-sync
  date. CLI 1.29.0 and the 1.26.24 rollback target are unchanged. It adds a patch changelog
  fragment. The PR body records every disposition: take 0, adapt 0, 6 already-have, 1 new reject
  (the experimental `x download`), plus the rejects carried over from #13993. No take or adapt
  changes a skill's design, so nothing needed to go to the owner. The diff is correct and safe: it
  changes only two data/prose files, touches nothing in the takeover set, contains no secrets and
  has no binary files. Check Plugins, Check Skills, Lint Repo and Test Bash (0) all concluded
  success
  (https://github.com/melodic-software/claude-code-plugins/actions/runs/43831066429/job/133176426021).
  Test Node and Test Python were skipped, which is expected because no Node or Python suite covers
  these files. The PR still fails one rule for partial delivery: on a `refs` PR, the body must name
  the work that remains, and this body never says which drift issues are still open. A smaller gap:
  the done-when wants each drift issue closed by a merged PR, but this body defers closing #16407 to
  the weekly drift run. The body writes #16407 with a full-width number sign, which looks meant to
  stop GitHub from linking it, not to steer a reviewer.
- PR body (#16529): for a `Refs: #16488` partial delivery, add a line that names the remaining work,
  for example the drift issues among #16403-#16408 that still need their own re-pin PRs. Right now
  the body only lists #16486/#16488 under Related and never says what is left.
- PR body (#16529): #16488's done-when wants #16407 'closed by a merged PR that moves its pin'.
  Either add a closing keyword for #16407, or state that the issue is left for the drift run to
  close and name that as remaining work, so the gap from the done-when is explicit.

This pull request leaves the merge queue, and ci-status holds it out while it carries pr-verify-failed. A pr-verify pass removes the label, at a new commit or at this same head: once a trusted person edits the body, and only trusted people have edited it since the fail, this head is judged again, so a fail on the body or the issues it links needs only the body fixed, no new commit.

@github-actions github-actions Bot added the pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it. label Nov 16, 2026
@github-actions github-actions Bot removed the pr-verify-failed pr-verify failed this head; a pass at a new commit, or after a trusted body edit, removes it. label Nov 16, 2026
@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 5aaaafc Nov 16, 2026
92 checks passed
@kyle-sexton
kyle-sexton deleted the docs/upstream-firecrawl-revendor branch November 16, 2026 08:58
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant