Repository navigation
chore(firecrawl): re-sync the update record with upstream SKILL.md b4d49850 - #16529
Conversation
…d49850 The upstream-drift run flagged firecrawl/update: upstream SKILL.md hashes to b4d49850 against the recorded 646709de. The CLI half is clean (1.29.0 is npm latest). update.sh --record-upstream moves the record; --check now exits 0. The re-audit of the upstream page changes no skill text: what it adds for the CLI is already covered or, for the experimental x download, not needed; its MCP-first, connector, Alexandria, workflow-skill and credential paths stay out as at the last sync. The changelog fragment records each disposition. Refs: #16488 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed No security issues found. I read both changed files in full:
The PR context file holds no embedded instructions aimed at this lane. This was a full first review, not a blocking-only one. critical-findings: 0 |
|
claude-review reviewed Code review: no findingsThis PR updates the firecrawl sync record and adds a changelog fragment:
Checks:
Verifier dropped 0 of 0 candidates. |
|
The pr-verify verifier failed head What it wrote (24 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
Refs: #16488
Summary
Works drift issue #16407 (
firecrawl/update), apin=unknownvendored-skill row. Its check script,plugins/firecrawl/skills/update/scripts/update.sh --check, exited 1 because the upstreamSKILL.mdathttps://www.firecrawl.dev/agent-onboarding/SKILL.mdnow hashes tob4d49850against the recorded646709de. The CLI half is clean: 1.29.0 is installed and is npm latest.The skill keeps no copy of upstream (only its hash), so the re-audit read the whole current upstream page against
/firecrawl:firecrawland itscontext/files, with the last sync's decisions (#13993) as the baseline. No skill text changes, and no take or adapt changes a skill's design, so no needs-human issue was filed. The PR carries no closing keyword for #16407: that issue is labeled needs-human, and the weekly drift run closes it once the row reads clean.Fix
plugins/firecrawl/skills/update/upstream.md: written byupdate.sh --record-upstream(installs nothing): upstream SHA256b4d49850499b9e55357a895be2292c6df8a51fee1f25a9e7536588160bb120a1, last sync 2026-11-16, CLI 1.29.0 and rollback target 1.26.24 unchanged..changes/firecrawl/docs-upstream-firecrawl-revendor-07f91827.md(patch): records the re-audit outcome.Dispositions over the upstream page's ideas:
parse -S(the--format summaryshortcut) andparse -Q,doctor <job-id>,monitor,developer, the research index. The CLI-facing items were checked against the installed 1.29.0firecrawl --helpandfirecrawl parse --help, not upstream's prose.firecrawl x download.crawlandscrapewith-oalready save pages to disk, and the command is marked experimental.setup build),initand its flags, the support endpoints, the official Claude Code plugin, and the AgentID, WorkOS ID-JAG and Stripe Projects credential paths. The wrapper uses the CLI withFIRECRAWL_API_KEYauth.Counts: take 0, adapt 0, already-have 6, reject 1 new plus the carried-over set.
Verification
Run in the worktree on the pushed head:
update.sh --checkbefore the re-pin: exit 1,upstream content changed since last sync; after it: exit 0,No drift. CLI and skill are in sync with upstream.update.test.sh:All 95 checks passed.scripts/check-affected.sh --base origin/main --no-fetch: 16 passed, 2 skipped over 2 changed files.scripts/check-changelog-fragments.sh --checkand--check-required origin/main: valid, the one changed plugin has a fragment.scripts/check-cost-figures.sh --check: no cost figure outside baselined and exempt files.scripts/check-purged-em-dashes.sh: no em dashes.Not verified:
646709detob4d49850: the skill stores only the hash, and no archive copy was fetched. Ideas upstream added and later removed in that window are invisible to this audit.scripts/check-upstream-drift.sh --pageand--links: this row has nodocs/upstream/page to target; the row's own check isupdate.sh --check, run above.Remaining
On #16488 after this pull request (it delivers the firecrawl/update re-audit, drift issue #16407):
Related
🤖 Generated with Claude Code