Skip to content

chore(playwright): sync to upstream v0.1.24 - #16527

Merged
kyle-sexton merged 1 commit into
mainfrom
docs/upstream-playwright-revendor
Nov 16, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
docs/upstream-playwright-revendor

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Refs: #16488

Summary

Re-vendors /playwright:playwright for drift issue #16406. The row is a pin=unknown vendored-copy row whose check is plugins/playwright/skills/playwright/scripts/update.sh: --check reported version drift: 0.1.23 → 0.1.24 (npm @playwright/cli latest is 0.1.24, release notes). update.sh --apply replaced vendor/ and moved the frontmatter pin to upstream-version: 0.1.24, upstream-sha: 51879b34702b683e25be6abd824c66f54a664b9c, synced: 2026-11-16.

The only vendored content change is one line in vendor/references/running-code.md ("Error Handling"): event listener errors are reported as console errors. Disposition: take, ported to reference/running-code.md as our decision plus a pointer. It changes no skill's design, so no needs-human issue was filed.

The PR carries no closing keyword for #16406: that issue is labeled needs-human, and the weekly drift run closes it once update.sh --check reads clean, which it now does.

Fix

  • vendor/: wholesale replacement by update.sh --apply. Content diff is the one added line above; vendor/LICENSE differed only in line endings and normalizes to no change.
  • SKILL.md frontmatter: the pin above.
  • reference/running-code.md: after a run-code body that registers page or context listeners, read console for errors they threw, with a pointer to the vendored section and the v0.1.24 notes.
  • Records whose recheck trigger is "the frontmatter upstream-version moves" and that rest on text only were re-derived from the v0.1.24 notes and re-dated 2026-11-16: the run-code sandbox globals pointer (running-code.md; the notes list no sandbox change) and the idle-shutdown pointer (sessions.md; the notes list no idle-timeout change).
  • README.md wrapper verdict rechecked at 0.1.24: the vendored SKILL.md is unchanged (493 lines, same description, same reference layout), so the verdict stands. The count of vendored reference files over 100 lines is corrected from seven to six (wc -l over vendor/references/; it was already six at 0.1.23).
  • Changelog fragment for playwright (patch).

Release-note features with no vendored counterpart (PLAYWRIGHT_MCP_BACKGROUND for extension sessions, locateOnlyVisible, tabGroup: false, ordinal download filenames, --json error objects) are not ported: the vendored skill does not document them, and each would need a --help or live check under 0.1.24 first. None changes this skill's design; force-chrome-foreground.ps1 handles headed browsers on Windows, which the extension background mode does not replace.

Verification

Run in the worktree:

  • update.sh --check after the sync: No drift. Vendored baseline tracks upstream v0.1.24., exit 0.
  • update.test.sh: all 33 checks passed.
  • scripts/check-affected.sh --base origin/main --no-fetch: 16 passed, 2 skipped over 6 changed files.
  • scripts/check-changelog-fragments.sh --check: 1 fragment valid.
  • scripts/check-vendor-version-bump.sh --check-bump origin/main: passed.
  • scripts/check-cost-figures.sh --check: no cost figure outside baselined and exempt files.
  • scripts/check-as-of-recheck.sh --check: every as-of date has a recheck trigger.
  • scripts/check-upstream-drift.sh --page: not applicable; this row has no docs/upstream/ page, its record is the skill frontmatter.

Not re-run (needs a 0.1.24 playwright-cli; the local CLI is 0.1.23 and this run installs nothing globally). These records keep their dates and their "under 0.1.2x" wording:

  • The video frame-size table in reference/tracing-and-video.md (ffprobe-measured). The v0.1.24 notes say video-start no longer loses the bottom of the viewport in headless Chrome and Edge, so the measured sizes may now differ.
  • The animation-capture probe in reference/running-code.md (dated 0.1.22). The v0.1.24 notes bound settle waits on pages with paused clocks, which may change the recorded "a call that left the clock paused never returned".
  • The probes in commands.md (--raw), storage-and-auth.md (redactUrlParams), running-code.md (goto file:///) and the video-flags pointer in tracing-and-video.md.

The plugin's model-graded evals were not run.

Remaining

On #16488 after this pull request (it delivers the playwright/playwright re-vendor, drift issue #16406):

Related

🤖 Generated with Claude Code

update.sh --apply replaced vendor/ with the skill bundled in
@playwright/cli 0.1.24 and moved the frontmatter pin. The one vendored
change, run-code listener exceptions reported as console errors, is
ported to reference/running-code.md as a decision plus pointer.

Records whose recheck trigger is the upstream version and that rest on
text were re-derived from the v0.1.24 release notes and re-dated. The
README's wrapper verdict is rechecked against 0.1.24, with the count of
vendored reference files over 100 lines corrected to six.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 08:22
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T08:24:31.116358Z 9df17d5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 43830786111

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed 9df17d53a6c4d04bd90201fc6bf53e62e0331b19: read 6 of 6 changed file(s); 0 finding(s), 0 as inline comments.

I found nothing to flag in this review of the /playwright:playwright re-vendor to @playwright/cli 0.1.24. I read every hunk of all 6 changed files.

What changes

  • Version pin: the SKILL.md frontmatter now reads version 0.1.24, the new upstream SHA and sync date 2026-11-16. The three lines are swapped one for one, so the README's "163-line hub" count still holds.
  • Vendored file: one upstream line is added to the "Error Handling" section of vendor/references/running-code.md. It says event listener errors show up as console errors.
  • Ported guidance: reference/running-code.md gains a matching line telling readers to check console after a body that registers listeners. I confirmed that playwright-cli console is a documented command (reference/commands.md:192, vendor/SKILL.md:181) and that the "Error Handling" heading the pointer names exists (vendor/references/running-code.md:207).
  • Re-dated pointers: two pointers whose recheck trigger is "upstream-version moves" get new dates, which matches that trigger.
  • README: the verdict is rechecked and the count of long reference files goes from seven to six. I didn't re-run wc -l over the vendored references, so the six count is the author's claim and unverified. Ten reference files do exist, which matches "ten".
  • Changelog fragment: marked bump: patch, which fits a documentation-only re-vendor.

Other checks

No hold applies: nothing here can cause a charge.

Verifier dropped 0 of 0 candidates.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 9df17d53a6c4d04bd90201fc6bf53e62e0331b19: read 6 of 6 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues found

I read every hunk of all 6 changed files. The pull request re-vendors /playwright:playwright to @playwright/cli 0.1.24, and every change is documentation:

  • .changes/playwright/...md: a new changelog fragment with a patch bump.
  • plugins/playwright/README.md: the upstream version and check date are updated, and the count of long reference files is corrected from seven to six.
  • plugins/playwright/skills/playwright/SKILL.md: only the upstream-version, upstream-sha and synced metadata in the frontmatter changed. No allowed-tools, hooks or other fields that run code changed.
  • reference/running-code.md and reference/sessions.md: two "As of" dates are moved to the new date, and one line is added telling the reader to check console for errors thrown by listeners.
  • vendor/references/running-code.md: one upstream line is added ("Event listener errors are reported as console errors.").

What I checked:

  • Instructions removed or weakened: none. The existing sandbox guidance, including passing secrets in as JSON-encoded literals and never through process.env, is unchanged.
  • Plugin manifests: no plugin.json or marketplace.json was changed.
  • Trust controls: none touched, and no changed file matches a trusted path.
  • Pull request text: it contains no embedded instructions aimed at the review lane.
  • Code the skill runs: the vendored content added is one line of prose, with no command or script.

critical-findings: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant