Repository navigation
chore(playwright): sync to upstream v0.1.24 - #16527
Conversation
update.sh --apply replaced vendor/ with the skill bundled in @playwright/cli 0.1.24 and moved the frontmatter pin. The one vendored change, run-code listener exceptions reported as console errors, is ported to reference/running-code.md as a decision plus pointer. Records whose recheck trigger is the upstream version and that rest on text were re-derived from the v0.1.24 release notes and re-dated. The README's wrapper verdict is rechecked against 0.1.24, with the count of vendored reference files over 100 lines corrected to six. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lane run report
Failed GitHub API calls
|
|
claude-review reviewed I found nothing to flag in this review of the What changes
Other checks
No hold applies: nothing here can cause a charge. Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review: no security issues foundI read every hunk of all 6 changed files. The pull request re-vendors
What I checked:
critical-findings: 0 |
Refs: #16488
Summary
Re-vendors
/playwright:playwrightfor drift issue #16406. The row is apin=unknownvendored-copy row whose check isplugins/playwright/skills/playwright/scripts/update.sh:--checkreportedversion drift: 0.1.23 → 0.1.24(npm@playwright/clilatest is 0.1.24, release notes).update.sh --applyreplacedvendor/and moved the frontmatter pin toupstream-version: 0.1.24,upstream-sha: 51879b34702b683e25be6abd824c66f54a664b9c,synced: 2026-11-16.The only vendored content change is one line in
vendor/references/running-code.md("Error Handling"): event listener errors are reported as console errors. Disposition: take, ported toreference/running-code.mdas our decision plus a pointer. It changes no skill's design, so no needs-human issue was filed.The PR carries no closing keyword for #16406: that issue is labeled needs-human, and the weekly drift run closes it once
update.sh --checkreads clean, which it now does.Fix
vendor/: wholesale replacement byupdate.sh --apply. Content diff is the one added line above;vendor/LICENSEdiffered only in line endings and normalizes to no change.SKILL.mdfrontmatter: the pin above.reference/running-code.md: after arun-codebody that registers page or context listeners, readconsolefor errors they threw, with a pointer to the vendored section and the v0.1.24 notes.upstream-versionmoves" and that rest on text only were re-derived from the v0.1.24 notes and re-dated 2026-11-16: therun-codesandbox globals pointer (running-code.md; the notes list no sandbox change) and the idle-shutdown pointer (sessions.md; the notes list no idle-timeout change).README.mdwrapper verdict rechecked at 0.1.24: the vendoredSKILL.mdis unchanged (493 lines, same description, same reference layout), so the verdict stands. The count of vendored reference files over 100 lines is corrected from seven to six (wc -lovervendor/references/; it was already six at 0.1.23).playwright(patch).Release-note features with no vendored counterpart (
PLAYWRIGHT_MCP_BACKGROUNDfor extension sessions,locateOnlyVisible,tabGroup: false, ordinal download filenames,--jsonerror objects) are not ported: the vendored skill does not document them, and each would need a--helpor live check under 0.1.24 first. None changes this skill's design;force-chrome-foreground.ps1handles headed browsers on Windows, which the extension background mode does not replace.Verification
Run in the worktree:
update.sh --checkafter the sync:No drift. Vendored baseline tracks upstream v0.1.24., exit 0.update.test.sh: all 33 checks passed.scripts/check-affected.sh --base origin/main --no-fetch: 16 passed, 2 skipped over 6 changed files.scripts/check-changelog-fragments.sh --check: 1 fragment valid.scripts/check-vendor-version-bump.sh --check-bump origin/main: passed.scripts/check-cost-figures.sh --check: no cost figure outside baselined and exempt files.scripts/check-as-of-recheck.sh --check: every as-of date has a recheck trigger.scripts/check-upstream-drift.sh --page: not applicable; this row has nodocs/upstream/page, its record is the skill frontmatter.Not re-run (needs a 0.1.24
playwright-cli; the local CLI is 0.1.23 and this run installs nothing globally). These records keep their dates and their "under 0.1.2x" wording:reference/tracing-and-video.md(ffprobe-measured). The v0.1.24 notes sayvideo-startno longer loses the bottom of the viewport in headless Chrome and Edge, so the measured sizes may now differ.reference/running-code.md(dated 0.1.22). The v0.1.24 notes bound settle waits on pages with paused clocks, which may change the recorded "a call that left the clock paused never returned".commands.md(--raw),storage-and-auth.md(redactUrlParams),running-code.md(goto file:///) and the video-flags pointer intracing-and-video.md.The plugin's model-graded evals were not run.
Remaining
On #16488 after this pull request (it delivers the playwright/playwright re-vendor, drift issue #16406):
playwright-cli0.1.24.Related
@playwright/cliv0.1.24 release notes🤖 Generated with Claude Code