Skip to content

fix(enrichment): bound EOL runtime lookups#1546

Open
JSONbored wants to merge 1 commit into
mainfrom
codex/fix-unbounded-eol-lookups-vulnerability
Open

fix(enrichment): bound EOL runtime lookups#1546
JSONbored wants to merge 1 commit into
mainfrom
codex/fix-unbounded-eol-lookups-vulnerability

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • The EOL analyzer could extract an unbounded number of runtime pins from attacker-controlled patches and performed one endoflife.date fetch per distinct product:version, which allowed request amplification against the third‑party calendar API and risked degrading enrichment availability.
  • The intent is to limit per-request work and ensure product-level caching so identical product calendars are fetched at most once per enrichment request.

Description

  • Add per-request caps MAX_EOL_FILES, MAX_EOL_PATCH_LINES, and MAX_EOL_PINS and enforce them in extractVersionPins to bound files scanned, patch lines scanned, and pins returned in a single request (review-enrichment/src/analyzers/eol-check.ts).
  • Introduce a cyclesByProduct cache inside scanEol so fetchCycles(product) is invoked at most once per product per request and repeated version lookups reuse the cached calendar.
  • Add regression tests to review-enrichment/test/enrichment.test.ts that assert extraction is capped and that scanEol issues only one fetch per product (tests: extractVersionPins: caps attacker-controlled EOL scan input and scanEol: caches endoflife.date cycles per product).
  • Change is limited to the review-enrichment EOL analyzer and its tests and preserves existing EOL finding semantics for pins within the new budgets.

Testing

  • Ran the package-local tests with cd review-enrichment && npm test, and the review-enrichment test suite passed (all tests in that package succeeded).
  • Attempted the full repo gate npm run test:ci locally, but the run could not be completed in this environment due to unrelated tooling/coverage failures (TypeError: jsTokens is not a function in the coverage tooling), so the full CI gate was not verified here.
  • Attempted npm audit --audit-level=moderate, but the npm audit endpoint returned 403 Forbidden and the audit check could not be completed in this environment.

Codex Task

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 26, 2026
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@gittensory-orb

gittensory-orb Bot commented Jun 27, 2026

Copy link
Copy Markdown

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review — safe to merge

2 files · 1 AI reviewers · no blockers · readiness 48/100 · CI green · blocked

✅ Approved — safe to merge

Signal Result Evidence
Code review ✅ No blockers 1 reviewers, synthesized
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Review load ❌ 8/20 Readiness component derived from cached public PR metadata and labels; size label size:S.
Validation evidence ❌ 5/25 Cached preflight status is hold.
Open PR queue ❌ 3/10 48 open PR(s), 9 likely reviewable, 39 unlinked.
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 81 PR(s), 261 issue(s).
Gate result ✅ Passing No configured blocker found.
Nits — 2 non-blocking
  • Repository config was not parsed
  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 81 PR(s), 261 issue(s).
  • Related work: Titles/paths share 7 meaningful terms. (PR #1537)
  • Related work: Titles/paths share 6 meaningful terms. (PR #1396)
  • Related work: Titles/paths share 6 meaningful terms. (PR #1535)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Review top overlaps.
  • Add scope summary.
  • Fix blocker.
  • Expect slower review.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark codex gittensor:bug Gittensor-scored bug fix - worth 0.5x multiplier. gittensor Gittensor contributor context size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant