fix(enrichment): detect quoted workflow uses keys#1542
Open
JSONbored wants to merge 1 commit into
Open
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review — safe to merge
✅ Approved — safe to merge
Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
uses:token and failed to detect valid YAML variants likeuses :or quoted keys, allowing bypasses of the unpinned-action check.Description
USES_REto accept optional key quotes and optional whitespace before the colon so YAML-equivalentuses,uses :,"uses":, and'uses' :forms are detected (review-enrichment/src/analyzers/actions-pin.ts).uses :,"uses":, and'uses' :forms to ensure detection and line-citing remain correct (review-enrichment/test/enrichment.test.ts).Testing
npm --prefix review-enrichment test, which passed all tests.git diff --check && npm run test:ci; earlier checks completed but thetest:coveragestage hung in this environment and the run was terminated (partial progress observed before termination).npm audit --audit-level=moderate, which failed due to the npm registry audit endpoint returning403 Forbiddenin this environment.Codex Task