fix(selfhost): remove grafana database access#1553
Merged
Conversation
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review — safe to merge
✅ Approved — safe to merge
Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
This was referenced Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
frser-sqlite-datasourceplugin fromdocker-compose.ymlso Grafana no longer receives/appdbaccess.grafana/provisioning/datasources/sqlite.ymlwith an intentionally emptydatasources: []and a comment explaining that direct DB access is not allowed.grafana/dashboards/maintainer-reviews.jsonwith a disabled/notice text panel and updatedgrafana/dashboards/resource-hub.jsonwording to no longer claim the DB is surfaced via Grafana.docker-compose.yml,grafana/provisioning/datasources/sqlite.yml,grafana/dashboards/maintainer-reviews.json, andgrafana/dashboards/resource-hub.json.Testing
git diff --checkand it passed.nodeand validated changed YAML files parse (via Ruby), both checks succeeded.npm run test:cicould not be completed in this environment due to external network/DNS issues and an actionlint fallback that rejected a custom self-hosted runner label, so the full CI gate was blocked rather than failing.npm audit --audit-level=moderatecould not be completed due to the npm audit endpoint returning403 Forbidden, so dependency-audit steps were blocked.Codex Task