Skip to content

fix(migrations): report all grandfathered duplicate numbers in checker summary#1561

Merged
JSONbored merged 1 commit into
mainfrom
codex/fix-migration-check-output-message
Jun 27, 2026
Merged

fix(migrations): report all grandfathered duplicate numbers in checker summary#1561
JSONbored merged 1 commit into
mainfrom
codex/fix-migration-check-output-message

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • The migration checker printed a hard-coded success message that listed only two grandfathered duplicate numbers (0015, 0017) despite KNOWN_DUPLICATES including 0074, producing a stale/incorrect diagnostic line in CI output.

Description

  • Update scripts/check-migrations.mjs to derive grandfatheredNumbers from KNOWN_DUPLICATES and print the computed count and zero-padded list in the success summary instead of a hard-coded message.
  • Preserve the existing duplicate-enforcement logic so grandfathering remains an exact-filename match and no enforcement behavior changed.
  • Add test/unit/check-migrations-script.test.ts which runs the checker and asserts the success summary contains (3 grandfathered duplicates: 0015, 0017, 0074).
  • Change scope is limited to scripts/ and test/ and does not require regenerating artifacts.

Testing

  • Ran npm run db:migrations:check and it exited successfully while printing the corrected summary including 0074.
  • Ran the new unit test with npx vitest run test/unit/check-migrations-script.test.ts and it passed.
  • Ran git diff --check with no issues reported.
  • Full npm run test:ci was not completed due to an unrelated @sentry/node type resolution error during typecheck, and npm audit --audit-level=moderate was blocked by an npm registry audit endpoint 403 error.

Codex Task

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 26, 2026
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.37%. Comparing base (9de2106) to head (436460b).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1561   +/-   ##
=======================================
  Coverage   95.37%   95.37%           
=======================================
  Files         198      198           
  Lines       21514    21514           
  Branches     7776     7776           
=======================================
  Hits        20520    20520           
  Misses        416      416           
  Partials      578      578           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb

gittensory-orb Bot commented Jun 27, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review — held for maintainer review

2 files · 1 AI reviewers · no blockers · readiness 48/100 · CI green · blocked

⏸️ Held for maintainer review

Signal Result Evidence
Code review ✅ No blockers 1 reviewers, synthesized
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Review load ❌ 8/20 Readiness component derived from cached public PR metadata and labels; size label size:XS.
Validation evidence ❌ 5/25 Cached preflight status is hold.
Open PR queue ❌ 3/10 48 open PR(s), 9 likely reviewable, 39 unlinked.
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 81 PR(s), 261 issue(s).
Gate result ✅ Passing No configured blocker found.
Nits — 2 non-blocking
  • Repository config was not parsed
  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 81 PR(s), 261 issue(s).
  • Related work: Titles/paths share 8 meaningful terms. (PR #1427, PR #1489)
  • Related work: Titles/paths share 7 meaningful terms. (PR #1537, PR #1546)
  • Related work: Titles/paths share 6 meaningful terms. (PR #1391, PR #1392)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Review top overlaps.
  • Add scope summary.
  • Fix blocker.
  • Expect slower review.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot added gittensor Gittensor contributor context gittensor:bug Gittensor-scored bug fix - worth 0.5x multiplier. labels Jun 27, 2026
@JSONbored JSONbored merged commit 2b79db7 into main Jun 27, 2026
19 checks passed
@JSONbored JSONbored deleted the codex/fix-migration-check-output-message branch June 27, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark codex gittensor:bug Gittensor-scored bug fix - worth 0.5x multiplier. gittensor Gittensor contributor context size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant