fix(migrations): report all grandfathered duplicate numbers in checker summary#1561
Merged
Merged
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1561 +/- ##
=======================================
Coverage 95.37% 95.37%
=======================================
Files 198 198
Lines 21514 21514
Branches 7776 7776
=======================================
Hits 20520 20520
Misses 416 416
Partials 578 578 🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review — held for maintainer review
⏸️ Held for maintainer review
Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
KNOWN_DUPLICATESincluding 0074, producing a stale/incorrect diagnostic line in CI output.Description
scripts/check-migrations.mjsto derivegrandfatheredNumbersfromKNOWN_DUPLICATESand print the computed count and zero-padded list in the success summary instead of a hard-coded message.test/unit/check-migrations-script.test.tswhich runs the checker and asserts the success summary contains(3 grandfathered duplicates: 0015, 0017, 0074).scripts/andtest/and does not require regenerating artifacts.Testing
npm run db:migrations:checkand it exited successfully while printing the corrected summary including0074.npx vitest run test/unit/check-migrations-script.test.tsand it passed.git diff --checkwith no issues reported.npm run test:ciwas not completed due to an unrelated@sentry/nodetype resolution error duringtypecheck, andnpm audit --audit-level=moderatewas blocked by an npm registry audit endpoint403error.Codex Task