fix(api): include blacklistLabel in settings-preview#1540
Merged
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1540 +/- ##
=======================================
Coverage 95.43% 95.43%
=======================================
Files 193 193
Lines 21043 21044 +1
Branches 7618 7619 +1
=======================================
+ Hits 20083 20084 +1
Misses 383 383
Partials 577 577
🚀 New features to boost your workflow:
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review — safe to merge
✅ Approved — safe to merge
Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
settings.blacklistLabelas required in theRepoSettingsPreviewresponse but thebuildRepoSettingsPreview()implementation omitted that field, causing schema validation failures for generated clients and tests.Description
blacklistLabel: stringto theRepoSettingsPreviewtype so the response shape includes the field.blacklistLabelfrombuildRepoSettingsPreview(), defaulting to"slop"when the repository settings omit it to preserve backward compatibility.blacklistLabelproduceRepoSettingsPreviewobjects that parse successfully withRepoSettingsPreviewSchema.Testing
npx vitest run test/unit/settings-preview.test.tsand it passed.npm run typecheck, which completed successfully.npm run test:ci; the run reached the coverage stage but failed due to an unrelated coverage remapping error (TypeError: jsTokens is not a function) in the environment rather than this change.Codex Task