Skip to content

fix(api): include blacklistLabel in settings-preview#1540

Merged
JSONbored merged 1 commit into
mainfrom
codex/fix-settings-preview-schema-omission
Jun 27, 2026
Merged

fix(api): include blacklistLabel in settings-preview#1540
JSONbored merged 1 commit into
mainfrom
codex/fix-settings-preview-schema-omission

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • The published OpenAPI/Zod contract declares settings.blacklistLabel as required in the RepoSettingsPreview response but the buildRepoSettingsPreview() implementation omitted that field, causing schema validation failures for generated clients and tests.

Description

  • Add blacklistLabel: string to the RepoSettingsPreview type so the response shape includes the field.
  • Return blacklistLabel from buildRepoSettingsPreview(), defaulting to "slop" when the repository settings omit it to preserve backward compatibility.
  • Add regression tests that assert both the default and a configured blacklistLabel produce RepoSettingsPreview objects that parse successfully with RepoSettingsPreviewSchema.

Testing

  • Ran the unit file covering these changes with npx vitest run test/unit/settings-preview.test.ts and it passed.
  • Verified type checking with npm run typecheck, which completed successfully.
  • Attempted the full local gate npm run test:ci; the run reached the coverage stage but failed due to an unrelated coverage remapping error (TypeError: jsTokens is not a function) in the environment rather than this change.

Codex Task

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 26, 2026
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.43%. Comparing base (372acb6) to head (31b62bb).
⚠️ Report is 50 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1540   +/-   ##
=======================================
  Coverage   95.43%   95.43%           
=======================================
  Files         193      193           
  Lines       21043    21044    +1     
  Branches     7618     7619    +1     
=======================================
+ Hits        20083    20084    +1     
  Misses        383      383           
  Partials      577      577           
Files with missing lines Coverage Δ
src/signals/settings-preview.ts 99.23% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JSONbored JSONbored self-assigned this Jun 26, 2026
@JSONbored JSONbored added the gittensor:bug Gittensor-scored bug fix - worth 0.5x multiplier. label Jun 26, 2026
@gittensory-orb

gittensory-orb Bot commented Jun 27, 2026

Copy link
Copy Markdown

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review — safe to merge

2 files · 1 AI reviewers · no blockers · readiness 48/100 · CI green · blocked

✅ Approved — safe to merge

Signal Result Evidence
Code review ✅ No blockers 1 reviewers, synthesized
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Review load ❌ 8/20 Readiness component derived from cached public PR metadata and labels; size label size:XS.
Validation evidence ❌ 5/25 Cached preflight status is hold.
Open PR queue ❌ 3/10 48 open PR(s), 9 likely reviewable, 39 unlinked.
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 81 PR(s), 261 issue(s).
Gate result ✅ Passing No configured blocker found.
Nits — 2 non-blocking
  • Repository config was not parsed
  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 81 PR(s), 261 issue(s).
  • Related work: Titles/paths share 7 meaningful terms. (PR #1564)
  • Related work: Titles/paths share 8 meaningful terms. (PR #1427, PR #1489)
  • Related work: Titles/paths share 7 meaningful terms. (PR #1537, PR #1546)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Review top overlaps.
  • Add scope summary.
  • Fix blocker.
  • Expect slower review.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot added the gittensor Gittensor contributor context label Jun 27, 2026
@JSONbored JSONbored merged commit 5566d0c into main Jun 27, 2026
19 checks passed
@JSONbored JSONbored deleted the codex/fix-settings-preview-schema-omission branch June 27, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark codex gittensor:bug Gittensor-scored bug fix - worth 0.5x multiplier. gittensor Gittensor contributor context size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant