Skip to content

fix(github): skip caching permission lookups#1559

Merged
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-github-get-cache-vulnerability
Jun 27, 2026
Merged

fix(github): skip caching permission lookups#1559
JSONbored merged 1 commit into
mainfrom
codex/propose-fix-for-github-get-cache-vulnerability

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Motivation

  • The shared GitHub GET response cache was keyed only by URL and could serve cached collaborator permission responses, allowing stale authorization decisions to gate sensitive repo operations.
  • Permission/authorization endpoints must reflect the live caller context and must not be served from a URL-only shared cache.

Description

  • Tighten isCacheableGithubUrl to exclude repository collaborator permission endpoints in addition to access-token and rate-limit URLs so permission checks bypass the shared response cache.
  • Keep existing safe GETs cacheable (app install/PR/files/org reads) while explicitly treating authorization endpoints as non-cacheable via a regex guard in src/github/app.ts.
  • Add regression unit tests in test/unit/github-app.test.ts that assert collaborator-permission URLs are not cacheable and that repeated getRepositoryCollaboratorPermission calls do live fetches (do not hit the shared cache).

Testing

  • Ran targeted unit tests with npx vitest run test/unit/github-app.test.ts and the added tests passed (all tests in that file succeeded).
  • Ran the focused vitest invocation for the cache/permission tests and it passed (npx vitest run test/unit/github-app.test.ts -t "cacheable|shared response cache|repository collaborator permissions").
  • npm run typecheck failed due to a pre-existing missing @sentry/node module/types referenced in src/selfhost/sentry.ts that is unrelated to this change.
  • npm run test:coverage and npm audit --audit-level=moderate were attempted but failed due to unrelated environment/coverage tooling issues (TypeError: jsTokens is not a function) and an npm registry audit 403, respectively.

Codex Task

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 26, 2026
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.38%. Comparing base (9e1c351) to head (62790ef).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1559   +/-   ##
=======================================
  Coverage   95.38%   95.38%           
=======================================
  Files         201      201           
  Lines       21598    21600    +2     
  Branches     7807     7807           
=======================================
+ Hits        20601    20603    +2     
  Misses        416      416           
  Partials      581      581           
Files with missing lines Coverage Δ
src/github/app.ts 97.29% <100.00%> (+0.03%) ⬆️
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb

gittensory-orb Bot commented Jun 27, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review — held for maintainer review

2 files · 1 AI reviewers · no blockers · readiness 48/100 · CI green · blocked

⏸️ Held for maintainer review

Signal Result Evidence
Code review ✅ No blockers 1 reviewers, synthesized
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Review load ❌ 8/20 Readiness component derived from cached public PR metadata and labels; size label size:S.
Validation evidence ❌ 5/25 Cached preflight status is hold.
Open PR queue ❌ 3/10 48 open PR(s), 9 likely reviewable, 39 unlinked.
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 81 PR(s), 261 issue(s).
Gate result ✅ Passing No configured blocker found.
Nits — 2 non-blocking
  • Repository config was not parsed
  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 81 PR(s), 261 issue(s).
  • Related work: Titles/paths share 6 meaningful terms. (PR #1393)
  • Related work: Titles/paths share 6 meaningful terms. (PR #1546)
  • Related work: Titles/paths share 8 meaningful terms. (PR #1427, PR #1489)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Review top overlaps.
  • Add scope summary.
  • Fix blocker.
  • Expect slower review.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot added gittensor Gittensor contributor context gittensor:bug Gittensor-scored bug fix - worth 0.5x multiplier. labels Jun 27, 2026
@JSONbored JSONbored merged commit 038e814 into main Jun 27, 2026
19 checks passed
@JSONbored JSONbored deleted the codex/propose-fix-for-github-get-cache-vulnerability branch June 27, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark codex gittensor:bug Gittensor-scored bug fix - worth 0.5x multiplier. gittensor Gittensor contributor context size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant