fix(github): skip caching permission lookups#1559
Merged
JSONbored merged 1 commit intoJun 27, 2026
Merged
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
=======================================
Coverage 95.38% 95.38%
=======================================
Files 201 201
Lines 21598 21600 +2
Branches 7807 7807
=======================================
+ Hits 20601 20603 +2
Misses 416 416
Partials 581 581
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review — held for maintainer review
⏸️ Held for maintainer review
Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
isCacheableGithubUrlto exclude repository collaborator permission endpoints in addition to access-token and rate-limit URLs so permission checks bypass the shared response cache.src/github/app.ts.test/unit/github-app.test.tsthat assert collaborator-permission URLs are not cacheable and that repeatedgetRepositoryCollaboratorPermissioncalls do live fetches (do not hit the shared cache).Testing
npx vitest run test/unit/github-app.test.tsand the added tests passed (all tests in that file succeeded).vitestinvocation for the cache/permission tests and it passed (npx vitest run test/unit/github-app.test.ts -t "cacheable|shared response cache|repository collaborator permissions").npm run typecheckfailed due to a pre-existing missing@sentry/nodemodule/types referenced insrc/selfhost/sentry.tsthat is unrelated to this change.npm run test:coverageandnpm audit --audit-level=moderatewere attempted but failed due to unrelated environment/coverage tooling issues (TypeError: jsTokens is not a function) and an npm registry audit 403, respectively.Codex Task