Repository navigation
Conversation
…ecret helpers
lib-auth's declaration.WireFromEnv reads IDP_DECLARATION_ENABLED and
IDP_HOST from the ConfigMap and the IDP_M2M_CLIENT_ID/_SECRET pair from
the Secret. Each consumer chart wires these by hand today, and some do
not render them at all.
- lerian-common.idp.env emits IDP_DECLARATION_ENABLED (always, default
"false") and IDP_HOST (only when non-empty), resolved as configmap >
extraEnvVars (legacy) > global.idp.{declarationEnabled,host} > default.
- lerian-common.idp.secret emits the client pair from the component's
secrets map, each key only when set, in data or stringData mode, and
nothing with useExistingSecret.
- lerian-common.idp.keys lists the keys the helpers own (env, secret or
all) so charts can skip them in their generic ranges.
- Document global.idp in values.yaml and the README.
Additive: no existing helper changes, and nothing renders until a chart
includes the new helpers.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
Pull Request Type
O que muda
Adiciona ao
lerian-commonos helpers da declaração de permissões do Access Manager (as quatro envs que odeclaration.WireFromEnvdo lib-auth lê), emcharts/lerian-common/templates/_idp.tpl:lerian-common.idp.envIDP_DECLARATION_ENABLED(sempre, default"false") eIDP_HOST(só se não vazio)configmap.<KEY>>extraEnvVars.<KEY>(legado) >global.idp.{declarationEnabled,host}> defaultlerian-common.idp.secretIDP_M2M_CLIENT_ID/IDP_M2M_CLIENT_SECRET, cada um só se setadodata(base64) oustringData; nada comuseExistingSecretlerian-common.idp.keyskind: env,secretou todas)extraEnvVarsentra como override de compatibilidade: ambientes que hoje passam o gate e o host porextraEnvVars(PRs abertos no gitops) continuam funcionando quando o chart adotar o helper.global.idpdocumentado emvalues.yamle no README (seção "Permission declaration (IDP_*)"), com o aviso de queglobal.idp.declarationEnabledliga o gate em todos os componentes do release, e cada um precisa do seu par de credenciais.Compatibilidade
Aditivo. Nenhum helper existente muda, e nada renderiza até um chart incluir os novos helpers. Release esperado: minor (
2.4.0).Teste local
helm v3.16.4, chart fixture consumindo o
lerian-commonlocal viafile://:IDP_DECLARATION_ENABLED: "false"no ConfigMap, nada no Secret;global.idp.host+declarationEnabled=true+ par em secrets:"true", host, e ID/SECRET emdata(base64) estringData;configmap.IDP_DECLARATION_ENABLED=falsevenceglobaltrue(false explícito respeitado);extraEnvVars.IDP_HOSTvenceglobal;configmapvenceextraEnvVars;useExistingSecret=true: nenhuma chave no Secret; secret vazio não é emitido.go run ./validate-helm-charts --root ../.. --strict: 0 violações.Próximo passo (depende deste release)
PRs draft em
plugin-br-bank-transfer,reporterefetcheradotam os helpers; eles só saem do draft depois que olerian-common-helm2.4.0 for publicado e a dependência (hoje pinada em2.3.0) for trocada.🤖 Generated with Claude Code