Repository navigation
Conversation
values.schema.json restricts every configmap to the allowlist in config/schema-keys.txt (plus the open DATASOURCE_ family). Neither IDP_DECLARATION_ENABLED nor IDP_HOST is on it, so setting them in manager.configmap - the keys lib-auth's declaration.WireFromEnv reads to publish the permission manifest - fails the render with "manager.configmap: Property name of IDP_DECLARATION_ENABLED does not match". Add both keys to the allowlist and to the three generated enums (manager, worker and common, which share the list), and document them under manager.configmap. The manager ConfigMap already ranges over manager.configmap, so the keys reach the pod with no template change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ➖ Normal Merge Risk: ⚪ Minimal · up to
|
Chart image referencesEvery image referenced by 1 chart(s) in this pull request exists in its registry.
Every reference checked
|
Pull Request Type
Problema
O
values.schema.jsondo reporter (4.x) restringemanager.configmap,worker.configmapecommon.configmapà allowlist deconfig/schema-keys.txt(mais a família abertaDATASOURCE_*).IDP_DECLARATION_ENABLEDeIDP_HOST, as envs que odeclaration.WireFromEnvdo lib-auth lê para publicar o manifesto de permissões, não estão na lista. Com elas emmanager.configmap, o render falha:É o que quebra hoje o render do reporter nos dev-st do PR do gitops
lerian-internal-gitops#3458(chart 4.3.13-alpha, mesmo schema).O que muda
config/schema-keys.txt: +IDP_DECLARATION_ENABLED,IDP_HOST.values.schema.json: as duas chaves nos três enums gerados (manager, worker, common compartilham a lista; fica igual ao que o gerador produz).values.yaml: documenta as chaves emmanager.configmape onde vai o par de credenciais (secrets.IDP_M2M_*).Nenhuma mudança de template: o ConfigMap do manager já faz range em
manager.configmap, então as chaves chegam ao pod.Compatibilidade
Aditivo: o schema só passa a aceitar duas chaves a mais. Release esperado: patch.
Não depende do PR do
lerian-common(#2543). A adoção do helperlerian-common.idp.*(que também tira o parIDP_M2M_*do Secret do worker) vem num PR separado, em draft até olerian-common2.4.0 sair.Teste local (helm v3.16.4)
IDP_DECLARATION_ENABLED/IDP_HOST; par no Secrethelm lint: 0 falhas.python3 tests/test_crm_config.py: passa.🤖 Generated with Claude Code