Repository navigation
Conversation
…mmon
IDP_DECLARATION_ENABLED/IDP_HOST reached the manager only through the
generic manager.configmap range, with no default and no env-wide value,
and the client pair only through the manager.secrets range.
- Manager ConfigMap: include lerian-common.idp.env next to the auth
mask, resolved as manager.configmap > manager.extraEnvVars (legacy) >
global.idp.{declarationEnabled,host}. IDP_DECLARATION_ENABLED is
always rendered (default "false"), IDP_HOST only when set. Both the
manager.configmap range and the extraEnvVars passthrough skip the two
keys, so no key is emitted twice.
- Manager Secret: the IDP_M2M_CLIENT_ID/_SECRET pair comes from
lerian-common.idp.secret (data mode, each key only when set, same as
the range did); the range skips it.
- Document global.idp, the ConfigMap keys and manager.secrets.IDP_M2M_*.
Requires the lerian-common release that ships lerian-common.idp.*; the
lerian-common-helm dependency must move from 2.3.0 to it before merge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
Chart image references1 of 1 chart(s) did not pass. A chart published while it points at an image that does not exist installs into
Every reference checked
no image references |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
O que muda
templates/manager/configmap.yaml: incluilerian-common.idp.envao lado dolerian-common.auth.env. Precedência:manager.configmap>manager.extraEnvVars(legado, mesmo padrão doPLUGIN_AUTH_*) >global.idp.{declarationEnabled,host}.IDP_DECLARATION_ENABLEDsempre sai (default"false");IDP_HOSTsó quando setado. O range demanager.configmape o deextraEnvVarspulam as duas chaves.templates/manager/secrets.yaml: o parIDP_M2M_*sai do range demanager.secretse vem delerian-common.idp.secret(mododata, cada chave só quando setada, igual ao range). Escolhi o helper, e não deixar o range cobrir, para ficar igual ao bank-transfer (feat(plugin-br-bank-transfer): render the IDP_* permission declaration from lerian-common #2545) e ao reporter (feat(reporter): render the IDP_* permission declaration from lerian-common, manager only #2546).values.yaml/ README:global.idp, as chaves do ConfigMap emanager.secrets.IDP_M2M_*(com o aviso de que osecretsde topo vai também para o worker).Compatibilidade
Aditivo. Render sem valores novos: só aparece
IDP_DECLARATION_ENABLED: "false"no ConfigMap do manager. Quem já passa as chaves pormanager.configmap/manager.secrets(olerian-internal-gitops#3457) mantém os mesmos valores, que só mudam de posição no objeto. Release esperado: minor.Teste local
helm v3.16.4, cópia do chart com
lerian-common-helmapontando para olerian-commondo #2543 viafile://(só para teste, não commitado), comparada com o chart damain(OCI 2.3.0):IDP_DECLARATION_ENABLED: "false"no ConfigMap do managerextraEnvVars.IDP_*+FOOFOOno passthrough, sem duplicataconfigmap.IDP_HOST+extraEnvVars.IDP_HOSTconfigmapvenceglobal.idp.host+ sóIDP_M2M_CLIENT_ID(secret vazio)helm lint: 0 falhas.validate-helm-charts --strict: 0 violações.🤖 Generated with Claude Code