Repository navigation
Conversation
…ommon, manager only
The manager ConfigMap ranged IDP_DECLARATION_ENABLED/IDP_HOST straight
from manager.configmap, and the top-level secrets range wrote the
IDP_M2M_CLIENT_ID/_SECRET pair into BOTH the manager and the worker
Secret, although only the manager declares.
- Manager ConfigMap: include lerian-common.idp.env, resolved as
manager.configmap > manager.extraEnvVars (legacy) > common.configmap
> global.idp.{declarationEnabled,host}. IDP_DECLARATION_ENABLED is
always rendered (default "false"), IDP_HOST only when set. The
manager.configmap range and the extraEnvVars passthrough skip both
keys, and reporter.commonConfigmapData lists them as explicit so
common.configmap never emits them (nor reaches the worker).
- Manager Secret: the pair comes from lerian-common.idp.secret (data
mode, each key only when set); the top-level range skips it.
- Worker Secret: skip the pair, so the declaration credentials no
longer reach the worker.
- Document global.idp and the contract; add tests/test_idp_declaration.py.
Requires the lerian-common release that ships lerian-common.idp.*; the
lerian-common-helm dependency must move from 2.3.0 to it before merge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
Chart image references1 of 1 chart(s) did not pass. A chart published while it points at an image that does not exist installs into
Every reference checked
no image references |
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Problema
IDP_*pelo range genérico demanager.configmap, sem default nemglobal.secretsde topo escreveIDP_M2M_CLIENT_ID/_SECRETno Secret do manager e no do worker (worker/secrets.yaml:36). Só o manager declara, então a credencial vai para um pod que não a usa.O que muda
templates/manager/configmap.yaml: incluilerian-common.idp.env. Precedência:manager.configmap>manager.extraEnvVars(legado) >common.configmap>global.idp.{declarationEnabled,host}.IDP_DECLARATION_ENABLEDsempre sai (default"false");IDP_HOSTsó quando setado. O range demanager.configmape o passthrough deextraEnvVarspulam as duas chaves.templates/_helpers.tpl:IDP_DECLARATION_ENABLED/IDP_HOSTentram na lista$explicitdoreporter.commonConfigmapData, paracommon.configmapnunca as emitir (o que duplicaria a chave no manager e as levaria ao worker).templates/manager/secrets.yaml: o par sai do range e vem delerian-common.idp.secret(mododata, cada chave só quando setada).templates/worker/secrets.yaml: o range pula o par, que deixa de chegar ao worker.values.yaml/ README:global.idpe a seção "Access Manager Permission Declaration (manager)".tests/test_idp_declaration.py: defaults, gate ligado (só manager, worker limpo),extraEnvVarslegado eglobal.idp.host. Falha no chart atual (verificado) e passa com a mudança.Compatibilidade
IDP_DECLARATION_ENABLED: "false"no ConfigMap do manager.manager.configmap(olerian-internal-gitops#3458) oumanager.extraEnvVarsmantém os mesmos valores, sem chave duplicada.IDP_M2M_*. O worker não lê essas chaves, porque não declara permissões. Mesmo assim, é a única remoção, e fica aqui para a revisão confirmar. Release esperado: minor.Teste local
helm v3.16.4, cópia do chart com
lerian-common-helmapontando para olerian-commondo #2543 viafile://(só para teste, não commitado), comparada com o chart do #2544:helm-render-values/reporter.yaml)IDP_DECLARATION_ENABLED: "false"no ConfigMap do managerIDP_M2M_*manager.extraEnvVars.IDP_HOST+FOOFOOno passthrough, sem duplicatacommon.configmap.IDP_HOST+manager.configmap.IDP_DECLARATION_ENABLED=true"true"e o host de common; worker sem IDPglobal.idp.host+manager.extraEnvVars.IDP_HOSTextraEnvVarsvencehelm lint: 0 falhas.tests/test_idp_declaration.pyetests/test_crm_config.py: passam.validate-helm-charts --strict: 0 violações.🤖 Generated with Claude Code