Repository navigation
Conversation
…n from lerian-common
The ConfigMap is an allowlist and never rendered IDP_DECLARATION_ENABLED
or IDP_HOST from bankTransfer.configmap, although the README and
values.yaml said it did; they only reached the pod through extraEnvVars.
- ConfigMap: include lerian-common.idp.env next to the inbound auth
block. IDP_DECLARATION_ENABLED is always rendered (default "false")
and IDP_HOST only when set, resolved as bankTransfer.configmap >
bankTransfer.extraEnvVars (legacy) > global.idp.{declarationEnabled,host}.
The extraEnvVars passthrough skips both keys, so environments that set
them there keep the same values with no duplicate key.
- Secret: replace the hand-written IDP_M2M_CLIENT_ID/_SECRET block with
lerian-common.idp.secret (same output: stringData, each key only when
set).
- Document global.idp and the two ConfigMap keys; fix the README and
values.yaml that said "configmap or extraEnvVars".
Requires the lerian-common release that ships lerian-common.idp.*; the
lerian-common-helm dependency must move from 2.3.0 to it before merge.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
Chart image references1 of 1 chart(s) did not pass. A chart published while it points at an image that does not exist installs into
Every reference checked
no image references |
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
O que muda
templates/configmap.yaml: incluilerian-common.idp.envlogo depois do bloco de auth (inbound).IDP_DECLARATION_ENABLEDsempre sai (default"false");IDP_HOSTsó quando setado. Precedência:bankTransfer.configmap>bankTransfer.extraEnvVars(legado) >global.idp.{declarationEnabled,host}.templates/configmap.yaml(passthrough deextraEnvVars): pulaIDP_DECLARATION_ENABLED/IDP_HOST, que agora alimentam o helper. Quem passa essas chaves porextraEnvVars(olerian-internal-gitops#3454) mantém exatamente os mesmos valores, sem chave duplicada.templates/secrets.yaml: o bloco manualIDP_M2M_CLIENT_ID/_SECRETviralerian-common.idp.secret(mesma saída:stringData, cada chave só quando setada).values.yaml: corrige o "configmap or extraEnvVars" (o caminho por configmap não renderizava antes), documenta as duas chaves do ConfigMap eglobal.idp.Compatibilidade
Aditivo. Única diferença num render sem valores novos:
IDP_DECLARATION_ENABLED: "false"passa a aparecer no ConfigMap (o mesmo valor que o app assume quando a chave falta). Release esperado: minor.Teste local
helm v3.16.4, cópia do chart com
lerian-common-helmapontando para olerian-commondo #2543 viafile://(só para teste, não commitado), comparado com o chart damain(OCI 2.3.0):helm-render-values/plugin-br-bank-transfer.yaml), sem IDPIDP_DECLARATION_ENABLED: "false"no ConfigMap (e as senhas aleatórias dos subcharts/checksum)extraEnvVars)configmap.IDP_DECLARATION_ENABLED=true+IDP_HOST+ par emsecrets"true"e host no ConfigMap (antes não renderizavam); par no Secret idêntico ao de antesglobal.idp.host+extraEnvVars.IDP_DECLARATION_ENABLED=true"true"e o host global, sem duplicar a chaveuseExistingSecret=truehelm lint(com a fixture de CI): 0 falhas.validate-helm-charts --strict: 0 violações.🤖 Generated with Claude Code