Repository navigation
feat: build shared HA components, framework adapters and catalog - #10
Conversation
|
To preview the documentation for this pull request, visit the following URL:
|
Copilot approval · Human review neededStatus: This pull request is outside the configured approval scope. Technical evidenceRevision: |
vypbot
added
the
state:ai-processing
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on63331e4. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 2fd60c6 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Reject C1 control characters in labels —
packages/core/src/contracts.ts:29
Bugbot: 1 finding needs attention
Findings |
vypbot
added
state:changes-requested
vypbot
removed
the
state:ai-processing
vypbot
added
state:ai-processing
vypbot
added
state:ai-processing
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on63331e4. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit 41b84aa was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- medium: Tab commits the first option without user selection —
packages/core/src/components/select.ts:143 - low: Implicit form submission crashes after hiding the submit button —
tests/consumers/fixtures/react/client.ts:35
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on63331e4. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit fbab810 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: The stale-event test emits a valid request during its first proposal —
tests/browser/select.test.ts:78
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on63331e4. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit 0c72565 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- medium: Disabled controls are incorrectly expected to block implicit submission —
tests/browser/implicit-submit-native.test.ts:5 - low: Close the preview server when browser setup fails —
tests/storybook/static.test.ts:42
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on63331e4. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit 4e65277 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- medium: Nested tabs trigger the parent selection callback —
packages/react/src/index.ts:17 - medium: Nested buttons trigger the parent press callbacks —
packages/react/src/button.ts:18
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on63331e4. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 539017b was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- medium: Use an imported CSSProperties type —
tests/browser/react.test.ts:13
There was a problem hiding this comment.
Current status: All findings originating in this review are resolved.
Last reconciled on63331e4. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 2 potential problems when commit 7ee7082 was analyzed. This snapshot is historical; use the status block above for current state. 2 findings are linked to changed code.
Findings
- medium: Ignore request events originating from nested controls —
packages/angular/src/checkbox.ts:13 - low: Arabic RTL stories inherit the wrong language —
stories/feedback.example.ts:21
There was a problem hiding this comment.
Current status: 1 finding originating in this review requires attention.
Last reconciled on63331e4. See aggregate Bugbot status.
🤖 Bugbot review snapshot
Bugbot reported 1 potential problem when commit 63331e4 was analyzed. This snapshot is historical; use the status block above for current state. 1 finding is linked to changed code.
Findings
- low: Clear drag click suppression when no click follows the drag —
packages/core/src/components/navigation-overflow.ts:107
|
/copilot dismiss navigation-overflow:107:stale-drag-click-suppression |
|
1 finding was dismissed. |
Gateway and Domus need one shared Home Assistant renderer with React, Vue, Angular and Svelte bindings. Refs #7.
The catalog covers navigation and local panels, text fields, native-form buttons, checkboxes, typed single/multiple selects and lists, native dialogs, cards, passive rows, responsive grids, notices, errors, empty states and loading. Application-owned projected controls retain native keyboard and form behavior. Nested tabs and commands keep DOM delegation while invoking only the originating adapter's callback.
Verification for
7ee7082:f5da97564a5d7e032e087116c0a07b846c948f211012ddf5c9c197fbbc125584. Core archive SHA-256:d283dd58522560cf320341f9a00eb8ccddb9217d263865aada2d847421bf5e46. No package has been published.Remaining scope: complete the exact hosted and native review gates, exercise the same candidate in the owning Gateway and Domus work, and verify the publication and public catalog gates.