Skip to content

πŸ›πŸ§‘β€πŸ’» - Bugbot stops at 1000 changed files while GitHub still serves the remaining PR diffΒ #899

Closed

Description

@efraespada

Is there an existing issue for this?

  • I have searched the existing issues.

Which actions are affected?

Pull Request

Which platforms are affected?

No response

Description

ha-ui #10 has 1,090 changed files at head e3f49b5c540771caf68ef2f3afca799cff26f389. The native review reads 1,000, then labels coverage partial with β€œprovider page limit reached.” Authenticated GitHub REST returns the remaining 90 entries normally. This is the Action’s local bound, and the current wording attributes it to the provider. For this repository it blocks the required complete-review signal even when CI passes. Expected: use a bounded, truthful review path for all exact-head changes the provider can supply, or state the actual local capacity limit and provide a supported complete-review route. Keep partial coverage fail-closed whenever files are genuinely omitted.

Reproducing the issue

  1. Inspect the exact-head aggregate: diff: partial; retained=1,000 with the provider-limit reason.
  2. gh api repos/vypdev/ha-ui/pulls/10 --jq .changed_files returns 1090 at the head above.
  3. gh api 'repos/vypdev/ha-ui/pulls/10/files?per_page=100&page=11' --jq length returns 90, including 15 non-PNG files.
  4. The reviewer log says diff files=1000, diff partitions=33. PullRequestChangesRepository.getBoundedBugbotReviewDiffSnapshot stops after ten full pages and reports providerLimitReached without checking whether GitHub has another page.

copilot Version

v3 (3e7ceea)

Relevant Log Output

Additional context and comments

The omitted files are legitimate product and test evidence. Regression cases should include exactly 1,000 files, more than 1,000 provider-available files, actual provider truncation, a later-page failure, a changing head and binary/reference paths. Do not mark omitted files reviewed or weaken the approval gate. This is separate from #724 and #843, which concern different context sources or limits.

Activity

  1. added
    bugSomething isn't working
    bugfixSomething isn't working
    priority: highCritical issue, needs immediate attention.
    on Nov 5, 2026
  2. added theissue type on Nov 5, 2026
  3. moved this to Todo in vypdevon Nov 5, 2026
  4. changed the title [-]Bugbot stops at 1,000 changed files while GitHub still serves the remaining PR diff[/-] [+]πŸ› - Bugbot stops at 1000 changed files while GitHub still serves the remaining PR diff[/+] on Nov 5, 2026
  5. vypbot commented on Nov 5, 2026

    @vypbot
    Contributor

    Hi! I’m @vypbot, the Copilot assistant for this repository.

    I can answer questions, explain the codebase, propose implementation and test plans, review issues and pull requests for potential bugs or security problems, and help authorized maintainers apply changes.

    Try /copilot help to see the available commands, or mention @vypbot with your question.

  6. moved this from Todo to In Progress in vypdevon Nov 5, 2026
  7. added
    branchedIndicates that a branch has been created for this issue.
    on Nov 5, 2026
  8. changed the title [-]πŸ› - Bugbot stops at 1000 changed files while GitHub still serves the remaining PR diff[/-] [+]πŸ›πŸ§‘β€πŸ’» - Bugbot stops at 1000 changed files while GitHub still serves the remaining PR diff[/+] on Nov 5, 2026
  9. added
    state:workingWork can proceed on the verified branch or without a branch.
    on Nov 5, 2026
  10. vypbot commented on Nov 5, 2026

    @vypbot
    Contributor

    Implementation plan

    Current status: Ready to start. No action is required from maintainers before implementation.

    1. Review repository guidance and current diff-loading flow
      • Read the README, documentation, and project contribution rules relevant to the Action.
      • Trace getBoundedBugbotReviewDiffSnapshot and how coverage status reaches the approval gate.
    2. Define truthful bounded coverage behavior
      • Distinguish an exact 1,000-file result from provider truncation, page-fetch failure, or head changes.
      • Use provider-supplied exact-head pages within a documented local capacity; report the actual limiting cause when coverage is incomplete.
    3. Load and validate exact-head pages
      • Continue pagination while pages contain files, with a bounded capacity and checks that the pull request head remains unchanged.
      • Preserve binary and reference-path entries; never count omitted files as reviewed.
    4. Keep incomplete coverage fail-closed
      • Ensure genuine omissions, provider truncation, later-page errors, or head changes yield partial coverage and cannot satisfy the complete-review approval gate.
      • Provide a supported route to complete review when the local capacity is reached.
    5. Add regression coverage and update documentation
      • Cover exactly 1,000 files, more than 1,000 available files, provider truncation, later-page failure, changing heads, and binary/reference paths.
      • Document the capacity, coverage reasons, and supported complete-review route.

    Acceptance: Regression tests demonstrate that all provider-available exact-head files within capacity are represented, while truncation, page failure, head changes, and capacity omissions remain partial and cannot pass the complete-review approval gate.

    Need something else? Mention the bot with a question or use /copilot help.

  11. added
    size: XXLIndicates an extremely large task or issue that requires significant time and effort to complete.
    on Nov 5, 2026
  12. added a commit that references this issue on Nov 5, 2026
  13. vypbot commented on Nov 5, 2026

    @vypbot
    Contributor

    Issue closed: synchronization recommendation retired

    No branch synchronization is required for this closed issue.

    The previous recommendation is historical. Issue closure does not certify that the branches are synchronized.

  14. moved this from In Progress to Done in vypdevon Nov 5, 2026
  15. added
    100%Progress: 100%
    and removed
    state:workingWork can proceed on the verified branch or without a branch.
    on Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

100%Progress: 100%branchedIndicates that a branch has been created for this issue.bugSomething isn't workingbugfixSomething isn't workingpriority: highCritical issue, needs immediate attention.size: XXLIndicates an extremely large task or issue that requires significant time and effort to complete.

Type

Projects

  • Status
    Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions