Repository navigation
ci(rust): run the Rust test suite on Windows - #1178
Merged
Merged
Conversation
thekevinscott
enabled auto-merge
September 24, 2026 11:40
This was referenced Sep 24, 2026
thekevinbot
force-pushed
the
claude/1175-windows-ci
branch
from
October 2, 2026 10:55
0cc3b1b to
8d38b87
Compare
Red: non_verbatim is still the identity, so verbatim Windows paths reach the hook unchanged.
{path} and {root} drop the \\?\ and \\?\UNC\ prefixes when the plain spelling names the same file.
This was referenced Oct 2, 2026
thekevinbot
force-pushed
the
claude/1175-windows-ci
branch
from
October 2, 2026 11:34
254e520 to
8d38b87
Compare
skip-changelog: test-only change, no observable behavior
Gate the chmod-and-exec parser fixture to unix and let the unreadable-file helper report 'cannot enforce' off unix, which the tests already treat as a skip.
thekevinbot
force-pushed
the
claude/1175-windows-ci
branch
from
October 2, 2026 11:45
8d38b87 to
08f5e30
Compare
6 of 8 tasks
MSYS sh collapses a leading \\ even when quoted; UNC conversion stays covered by the non_verbatim unit tests.
…origin/claude/1208-win-nonverbatim-paths' and 'origin/claude/1213-win-test-fixtures' into claude/1175-windows-ci
thekevinbot
force-pushed
the
claude/1175-windows-ci
branch
from
October 2, 2026 15:10
a9feff3 to
462b478
Compare
skip-changelog: README only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1175
Adds a
Windows testsjob todirsql-rust-ci.yml: the Rust unit and integration suites (cargo test --features cli --tests --no-fail-fast) onwindows-latest.Also makes the integration suite compile on Windows:
path_table_on_file_e2e.rs(chmod + shebang parser fixture) is gated to unix like its siblings, andvtab.rs's unreadable-file helper reports "cannot enforce" off unix, which its tests already treat as a skip.States the support level in the README: Linux, macOS, and Windows (x64); the Rust suite is tested in CI on Linux and Windows, the macOS artifacts are built but not tested.
Status
The job first went red on real product bugs: #1184, #1185, #1186 (fixed, merged) and #1207, #1208, #1213 (open as #1209, #1211, #1218). This branch carries a merge of those three fix branches so the job can prove green: https://github.com/thekevinscott/dirsql/actions/runs/37025082593 (Windows tests: pass). Merge #1209, #1211 and #1218 first; this PR is then rebased onto main to drop the merge commit.
E2E Verification
packages/rust/srcchange.Changelog / Migrations
skip-changelogon the commits: CI, tests, README