Repository navigation
fix(rust): MS-quote every argv element on Windows - #1209
Merged
6 commits merged intoOct 2, 2026
Merged
6 commits merged into
6 commits merged into
Conversation
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1207
Part of #1191
On Windows,
run_commandnow pushes every argv element throughCommandExt::raw_arg, quoted by the MS C-runtime rules (always wrapped in", backslashes before a"or the closing quote doubled, embedded"escaped). MSYS/Cygwin children no longer glob or brace-expand on-file argv; MSVCRT children parse the same values as before. The quoting is a pure function, unit-tested on every platform; only theraw_argwiring iscfg(windows).Not covered here: inside quotes MSYS still collapses
\\to\, so a verbatim\\?\path differs between runtimes. That is #1208.Windows compile: the crate cannot be cross-checked locally (bundled SQLite needs
x86_64-w64-mingw32-gcc), so the exactquote_windows_arg/push_argssource was extracted into a scratch crate and passescargo clippy --target x86_64-pc-windows-gnu -- -D warnings. The Windows CI job (#1178) is not onmainyet.E2E Verification
packages/python/e2e-attestations/<branch>.jsonreceipt written ifpackages/pythonchanged (just e2e-attest-python)packages/ts/e2e-attestations/<branch>.jsonreceipt written ifpackages/tschanged (just e2e-attest-ts)cargo test --workspace --features cli -- --test-threads=2,just e2e-attest-python,just e2e-attest-ts,just preflightcli_e2ewatcher tests failed withToo many open files(host inotify instances at 111/128 from other processes); both pass at--test-threads=2and in isolation. Hand check on Linux: anon-filehook passing'a?b*{}'receives it verbatim.Changelog / Migrations
packages/rust/changelog.d/packages/rust/migrations.d/(Windows MSYS children no longer expand argv)