Skip to content

Windows: absolute path-table names are not recognized #1185

Closed

Description

@thekevinbot

Found by the Windows CI job added in #1178 (run https://github.com/thekevinscott/dirsql/actions/runs/35995035941).

A path-table name that is a Windows absolute path is not recognized:

dirsql query: no such table: C:\Users\...\Temp\.tmpPBvbMe/*.md; did you mean './C:\Users\...\Temp\.tmpPBvbMe/*.md'?

path_table parsing assumes /-rooted absolute paths (drive letters and \ are not handled), and its normalization turns /x/a into \x\a on Windows (path_table::tests::an_absolute_*, a_parent_relative_path_*, a_home_relative_path_*; path_table_globs.rs an_absolute_*; path_table_cli_e2e.rs).

Done when absolute and ~/ path-tables resolve on the Windows tests job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions