Repository navigation
test(rust): platform-native paths in two Unix-assuming unit tests - #1218
Merged
2 commits merged intoOct 2, 2026
Merged
2 commits merged into
2 commits merged into
Conversation
skip-changelog: test-only change, no observable behavior
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1213
Part of #1175
Test-only. Two Rust unit tests hard-coded Unix paths:
extension_resolution::tests::select_loadable_rejects_an_ambiguous_package_in_sorted_orderbuilds the expected message from the samedir.join(..).display()the error uses (/pkg/a.soon Unix,/pkg\a.soon Windows).internal_tests::relative_root_canonicalizes_watch_root_onlyusesC:\ws\canonicalon Windows,/ws/canonicalelsewhere.Linux assertions are unchanged in value. No product code touched.
Red/green: the red for both tests is on the Windows job in #1178, which is not on
main(run https://github.com/thekevinscott/dirsql/actions/runs/37000025579). No Windows cross-compile check was possible locally (no mingw toolchain); the Windows job in #1178 is the verification.E2E Verification
use_case_notebook_test::it_matches_native_rows_within_the_barpasses on this machine though marked strict xfail (perf: on-file row ingestion is slower than a second interpreter's json.load + sort #1202). Unrelated to this diff (only#[cfg(test)]code changed); no receipt written yet.cargo test --lib --features clifor both tests: passpackages/python/e2e-attestations/<branch>.jsonreceipt -- blocked by the XPASS abovepackages/ts/e2e-attestations/<branch>.jsonreceipt written (just e2e-attest-ts)just preflight,just e2e-attest-python(3x, same XPASS),just e2e-attest-tse2e-verifypairs before receipts; TS receipt now committed.Changelog / Migrations
skip-changelogon the commit: test-only