[raft/memstore] Add scd memstore#1542
Open
the-glu wants to merge 9 commits into
Open
Conversation
| return nil, stacktrace.NewErrorWithCode(dsserr.NotImplemented, "GetUssAvailability not implemented for memstore") | ||
| rec, ok := r.state.Availabilities[id] | ||
| if !ok { | ||
| return nil, pgx.ErrNoRows |
Contributor
There was a problem hiding this comment.
Why do we return pgx.ErrNoRows instead of empty or a custom error and add this check in the handler ? Having pgx leak in the memstore feels odd.
Member
Author
There was a problem hiding this comment.
That was to avoid changes in callers, since they use that to detect no row, but that should be improved yes. I propose to do that in a follow up PR.
This was referenced Jun 17, 2026
barroco
added
the
dss-raft
This was referenced Jun 18, 2026
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a new chain, implementing memstore.
#1525 (Generic raftstore) -> #1527 (Base memstore) -> #1529 (Aux memstore) -> #1530 (Snapshots) -> #1534 (Rid memstore) -> #1535 (Correct use of now) -> #1539 (Checkpoint) -> #1542 (Scd memstore) -> #1528 (First PR with raft using memstore)
It does add SCD memstore.
PR is quite big, as it's the whole SCD memstore. However individual files can be checked individually.
There was no tests compared to RID, except for expired operational intents / subscriptions. The two ones have been copied, the rest is new.