[raft/memstore] Add rid memstore #1534
Open
the-glu wants to merge 6 commits into
Open
Conversation
the-glu
force-pushed
the
memstore_rid
branch
2 times, most recently
from
ac14b59 to
f6a1b38
Compare
barroco
added
the
dss-raft
This was referenced Jun 18, 2026
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a new chain, implementing memstore.
#1525 (Generic raftstore) -> #1527 (Base memstore) -> #1529 (Aux memstore) -> #1530 (Snapshots) -> #1534 (Rid memstore) -> #1535 (Correct use of now) -> #1539 (Checkpoint) -> #1542 (Scd memstore) -> #1528 (First PR with raft using memstore)
It does add rid memstore, with snapshots.
Tests (minus snapshots & transaction & initialization) are identical to SQL tests and a big part of this PR. They can be checked locally with e.g.
diff pkg/rid/store/memstore/identification_service_area_test.go pkg/rid/store/sqlstore/identification_service_area_test.go'Strange' behavior with limits has been implemented as-is.
Cell index/optimization is for a future PR to keep that one as simple as possible.