[raft/rid] Add rid raftstore ISAs#1540
Open
MariemBaccari wants to merge 11 commits into
Open
Conversation
the-glu
reviewed
Jun 16, 2026
| return nil | ||
| } | ||
|
|
||
| parsed, err := VersionFromString(s) |
Member
There was a problem hiding this comment.
this will strip time field, is that correct?
Contributor
Author
There was a problem hiding this comment.
VersionFromString repopulates the time field
| var sub *ridmodels.Subscription | ||
|
|
||
| _, err := a.store.Transact(ctx, "", nil, func(ctx context.Context, repo repos.Repository) error { | ||
| raftResult, err := a.store.Transact(ctx, ridraftstore.UpdateSubscriptionTransaction, s, func(ctx context.Context, repo repos.Repository) error { |
Member
There was a problem hiding this comment.
for the future, but having raft directly as a consquence is not great for isolation :/
Contributor
Author
There was a problem hiding this comment.
I agree, I'm open to any recommendation regarding this design.
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
from
05a7e39 to
0d8d295
Compare
This was referenced Jun 17, 2026
barroco
added
the
dss-raft
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
9 times, most recently
from
ddd6502 to
dd32866
Compare
MariemBaccari
commented
Jun 18, 2026
| var sub *ridmodels.Subscription | ||
|
|
||
| _, err := a.store.Transact(ctx, "", nil, func(ctx context.Context, repo repos.Repository) error { | ||
| raftResult, err := a.store.Transact(ctx, ridraftstore.UpdateSubscriptionTransaction, s, func(ctx context.Context, repo repos.Repository) error { |
Contributor
Author
There was a problem hiding this comment.
I agree, I'm open to any recommendation regarding this design.
MariemBaccari
changed the title
This was referenced Jun 18, 2026
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
from
dd32866 to
467aff9
Compare
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
2 times, most recently
from
d243a12 to
a295157
Compare
MariemBaccari
force-pushed
the
add_rid_raftstore
branch
from
a295157 to
873cca9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1525 (Generic raftstore) -> #1527 (Base memstore) -> #1529 (Aux memstore) -> #1530 (Snapshots) -> #1534 (Rid memstore) -> #1535 (Correct use of now) -> #1539 (Checkpoint) -> #1542 (Scd memstore) -> #1528 (Add aux Raftstore) ->
#1540 (Add rid Raftstore ISAs)
Implements the rid raftstore ISAs. A follow-up PR will implement subscriptions.
All transaction implementations in
identification_service_area_appliers.goare copied from the existing implementation underrid/application/isa.go.