ref(ui): replace ansi-to-react with shared AnsiText component - #126237
Open
JoshuaKGoldberg wants to merge 5 commits into
Open
JoshuaKGoldberg wants to merge 5 commits into
JoshuaKGoldberg wants to merge 5 commits into
Conversation
Moves the ansi-sequence-parser rendering from logs into a shared component so .log attachment previews use it too, and drops the ansi-to-react dependency. Fixes DE-1651
github-actions
Bot
added
the
Scope: Frontend
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ce3ac45. Configure here.
JoshuaKGoldberg
changed the title
ansi-to-react collapsed carriage-return overwrites before rendering, so progress-style lines showed only their final write. Restore that in LogFileViewer. Refs DE-1651
scttcper
approved these changes
Oct 1, 2026
scttcper
left a comment
scttcper
left a comment
Member
There was a problem hiding this comment.
good cleanup, that package was actually very unsafe
Only log messages want ANSI output's whitespace preserved. Other callers render it in single-line, truncated containers where preserved newlines would break the layout. Refs DE-1651
The dark green ANSI color had noticeably more chroma than the other ANSI hues, so move green and bright green one step lighter. Refs DE-1651
This was referenced Oct 1, 2026
This reverts commit 2250b86.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the
ansi-sequence-parserrendering added for log messages in #126206 into a sharedAnsiTextcomponent. This is then used in the.logattachment preview instead ofansi-to-react. 🔪This also fixes long-standing design issues in that preview by aligning them to #126206's designs: bright colors were nearly invisible, black or white text vanished depending on theme, and bold, underline, dim, 256-color, and truecolor codes were ignored.
Closes DE-1651.