feat(issues): Render ANSI colors in breadcrumb messages - #126289
Closed
JoshuaKGoldberg wants to merge 6 commits into
Closed
JoshuaKGoldberg wants to merge 6 commits into
JoshuaKGoldberg wants to merge 6 commits into
Conversation
Moves the ansi-sequence-parser rendering from logs into a shared component so .log attachment previews use it too, and drops the ansi-to-react dependency. Fixes DE-1651
ansi-to-react collapsed carriage-return overwrites before rendering, so progress-style lines showed only their final write. Restore that in LogFileViewer. Refs DE-1651
Only log messages want ANSI output's whitespace preserved. Other callers render it in single-line, truncated containers where preserved newlines would break the layout. Refs DE-1651
The dark green ANSI color had noticeably more chroma than the other ANSI hues, so move green and bright green one step lighter. Refs DE-1651
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introduced
This is informational only and does not block the PR. |
This reverts commit 2250b86.
Breadcrumb messages on issue details showed raw ANSI escape codes. Render them with the shared AnsiText component when they have no meta, and strip escape codes before matching breadcrumb search terms. Fixes LOGS-1019
JoshuaKGoldberg
force-pushed
the
joshgoldberg/logs-1019-render-ansi-colors-in-breadcrumb-messages
branch
from
October 2, 2026 00:23
8149f6f to
3c8e8b8
Compare
Base automatically changed from
joshgoldberg/de-1651-remove-ansi-to-react-in-favor-of-ansi-sequence-parser
to
master
October 2, 2026 13:45
Member
Author
|
Combined into #126286. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breadcrumb messages and exception crumb values on issue details now render ANSI colors with #126237's shared
AnsiTextcomponent, instead of showing raw escape codes. Breadcrumb search also matches against the visible text, so a search likefailed tofinds a message whose words are separated by escape codes.Stacked on #126237. Fixes LOGS-1019.