chore(deps): Update NitroSQLite to 9.8.2

[chrispader]

NitroSQLite 9.6.0 still needs local fixes for rollback errors and iOS database storage. The published 9.8.2 release includes those fixes and works with NitroModules 0.37.1, which is now on main. This PR upgrades SQLite and removes both local SQLite patches; the NitroModules and NitroFetch updates are already on main. NewDot and the companion HybridApp PR opt into the upstream Application Support location in their respective Info.plist files.

@NicolasBonet

Explanation of Change

The published NitroSQLite 9.8.2 package replaces the temporary archive built from an upstream commit. The dependency now resolves from the package registry, so the vendored archive and its provenance note are removed.

The upstream batch executor preserves the original error when rollback also fails. Its per-database migration replaces the old OnyxDB-specific patch. NewDot and HybridApp each set RNNitroSQLite_DatabaseLocation to ApplicationSupport in their host Info.plist, so NitroSQLite needs no local patch. The separate Nitro runtime PR is now on main. It upgraded NitroModules to 0.37.1 and NitroFetch to 1.6.2; this PR changes neither dependency.

ios/Podfile.lock changes only the RNNitroSQLite version and checksum. The companion HybridApp lockfile pins NitroSQLite 9.8.2 while retaining NitroModules 0.36.3 and NitroFetch 1.5.4.

Fixed Issues

$ #101448

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14129

No separate approved proposal applies to this dependency update.

Tests

Manual device verification is pending.

1. Upgrade an iOS installation that has existing Onyx data. Open a chat, send a message, force-close and reopen the app, and verify that the message and sign-in state persist.
2. In the iOS Files app, open the New Expensify folder. Verify that OnyxDB and its journal files are absent while a downloaded attachment remains visible. Repeat the upgrade and Files check in a hybrid iOS build using the companion Mobile-Expensify PR.
3. Repeat the chat and relaunch check on Android. Verify that the message and sign-in state persist.
4. On a disposable iOS simulator with a full test volume, trigger a failed batch write. Verify that the original SQLite storage error appears instead of a secondary rollback error, then free space and verify that the app resumes writing.
5. Verify that no errors appear in the JS console during the normal flows above.

Offline tests

1. Sign in while online, switch to airplane mode, compose a chat message, and relaunch the native app. Verify that the pending message and sign-in state remain available from local storage.
2. Reconnect and verify that the message sends once without a duplicate. On iOS, repeat the offline relaunch after upgrading an installation whose database previously lived in Documents.

QA Steps

Manual device verification is pending.

1. On iOS, start with an installation from before this PR that has chat history and a user document in the Expensify folder in Files. Upgrade to a staging build. Verify the sign-in state and chat history persist and the user document remains in Files.
2. Send a chat message, force-close and reopen the app, and verify the message persists. In Files, verify that OnyxDB and its journal files are absent from the Expensify folder while the user document remains.
3. Download a PDF attachment in a chat. Verify the download success message and that the PDF appears in Files. Download an image and a video; verify both save to Photos and no temporary video copy remains in the Expensify folder in Files.
4. In the Spend tab, select a small number of expenses, open the "x selected" menu, then choose Export > Basic export. Verify the share sheet opens and Save to Files saves the CSV at the chosen location without removing the pre-existing user document or leaving a temporary file in the Expensify folder.
5. Download an attachment named only with digits, such as 2024.pdf. Relaunch the app and verify it is still visible in Files.
6. Repeat steps 1-5 in a hybrid build using the companion Mobile-Expensify PR.
7. On a fresh iOS installation, verify the app starts and signs in when the migration flag and attachment collection are absent. Verify no database files appear in the app's Files folder.
8. On Android staging, upgrade an installation with existing chat history, send a message, force-close and reopen, and verify the message and sign-in state persist.
9. On each native platform, go offline, compose a message, and reopen the app. Verify it remains pending; reconnect and verify it sends once without an error banner.
10. Verify that no errors appear in the JS console throughout these flows.

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

No screenshots or videos are included because this dependency and plist change has no visible UI.

[github-actions]

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

[chrispader]

@MelvinBot please create an Expensify/App issue to track updating NitroSQLite from 9.6.0 to the latest upstream code, packaged in this PR as an unreleased 9.8.0 snapshot at 4f95bbe. Assign the issue to @chrispader and add its full URL to this PR's ### Fixed Issues section. The existing patch-tracking issue is context; the new issue should track the dependency update.

Please include the main reasons for the update:

• Upstream's Application Support option and safe migration replace our local iOS database-location patch, keeping the database and journals out of the user-visible Documents folder.
• Upstream batch error handling no longer masks the original SQLite failure when rollback also fails, replacing our other local patch.
• Query results are materialized once, avoiding repeated copies of the native result vector when callers traverse rows.
• SQLite operations are serialized per connection, preventing unrelated writes from joining another caller's transaction and protecting against close/reopen races.
• Upstream also adds iOS SQLite performance-mode configuration and memory-management fixes.

Answered by Codex, instructed by Chris.

[MelvinBot]

Created chore(deps): Update NitroSQLite from 9.6.0 to 9.8.0 and assigned it to chrispader.

The issue tracks the dependency update itself: the 9.8.0 snapshot from 4f95bbe, the two local patches upstream now replaces (Application Support location + safe migration and the batch rollback error handling), the single-materialization and per-connection serialization improvements, plus iOS performance mode and memory management. [Patch Tracking] react-native-nitro-sqlite+9.6.0+001+store-database-outside-documents is referenced as context, and a follow-up note covers swapping the vendored tarball for the published release.

I also updated this PR's ### Fixed Issues section: the $ link now points at the new issue, and the old patch-tracking issue stays listed as context alongside the Mobile-Expensify link.

[melvin-bot]

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chrispader]

@MelvinBot can you please request review from @NicolasBonet 🙌🏼

[MelvinBot]

Requested a review from NicolasBonet 🙌🏼

Current reviewers on this PR: ikevin127, NicolasBonet.

[NicolasBonet]

@ikevin127 could you please follow the steps in here: #96531 (Tests A, B and C)? 🙏

[chrispader]

I've just noticed that i've unnecessarily bumped the peer dependency range for NitroModules in the last NitroSQLite release, i'm going to lower that again in 9.8.1, to avoid scope creep in this PR by bumping NitroModules + NitroFetch.

I'll ping @ikevin127 once i've updated the PR!

[ikevin127]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

screen-20260929-204838-1790739961078.1.mp4

iOS: Native

ios.mp4

[ikevin127]

I'll ping @ikevin127 once i've updated the PR!

I'll hold on reviewing until you give the green light 🙌

[NicolasBonet]

I think we need to append the steps outlined in here: #100531 for the QA testing, so they can check how this behaves @chrispader, @ikevin127 could you please attach the video to close this one?

[fabioh8010]

@chrispader Do we also plan to bump react-native-nitro-sqlite in Onyx repo too?

[chrispader]

@NicolasBonet I added the applicable QA steps from #100531: preserving existing files, checking PDF/image/video downloads, CSV export, digits-only filenames, and fresh installs. Native QA and the video requested from @ikevin127 are still pending, so I left this PR WIP and did not mark either as complete.

Answered by Codex, instructed by Chris.

[chrispader]

@chrispader Do we also plan to bump react-native-nitro-sqlite in Onyx repo too?

@fabioh8010 yes, let's do that too. I'm planning a separate PR to update NitroSQLite to latest major release 10.0.0, which got some new features and more performance improvements, so i'll bump the peer dependency range there.

• [WIP] feat(storage): use NitroSQLite 10.1 connections and statements react-native-onyx#851

v9.8.2 still suffices the peer dependency range in Onyx, which currently is ^9.6.0

[NicolasBonet]

@ikevin127 could you please help us with the remaining part?

[ikevin127]

🟢 LGTM - Done, completed checklist - tests well

[NicolasBonet]

Feel free to merge afterwards.

[NicolasBonet]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If the PR adds or modifies the UI:
  • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
  • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
  • I verified all new/changed elements have meaningful accessible names and roles.
  • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

[NicolasBonet]

Unblocking with my checklist, but it was done here: #101437 (comment)

[github-actions]

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #101437.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-cdc03d5-7c7a6d7-968289cc6b9b84b65ea87ee887ec600416e54ea9/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-cdc03d5-7c7a6d7-2e274ba3788a035d1185ca133ebe235d0f2cf44a/index.html

Web 🕸️
https://101437.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.5.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[jponikarchuk]

Deploy Blocker #102728 was identified to be related to this PR.

[chrispader]

Chris's AI code gremlin checking in. 🤖

NitroSQLite 9.8.3 is published with the database connection-lifetime fix for deploy blocker #102728. The dependency-only follow-up PRs are ready for review:

• App PR #102751
• Mobile-Expensify PR #14149

Both descriptions include the deploy blocker's test and QA steps. Manual native and staging QA remain pending.

[unzig21]

Deploy Blocker #102798 was identified to be related to this PR.

[OSBotify]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

• Android