[WIP] feat(storage): use NitroSQLite 10.1 connections and statements

[chrispader]

Onyx's SQLite provider sends reads and writes through one connection and prepares single-key queries on every call. Long reads can delay writes, while repeated queries incur preparation work. This PR adopts NitroSQLite 10.1.0's independent connections and prepared statements while preserving Onyx's read-after-write behavior and stored JSON format.

Details

The development dependency now uses the published NitroSQLite 10.1.0 package, with an optional peer requirement of ^10.1.0. The Node mock's better-sqlite3 dependency is updated to ^12.11.1, and the lockfile installs successfully. Latest Onyx main is merged into the branch.

The existing writer keeps atomic batch operations. A separate read-only connection handles lookups and full-store reads under WAL, and single-key get, set, and remove calls reuse prepared statements. Bulk writes and deletes group parameter sets so NitroSQLite can reuse a statement within each batch; only a final partial delete chunk needs different SQL.

Reads wait for writes that were already queued. A multiGet call split across several SQL queries uses one transaction snapshot, including when the writer commits during the read. Native DatabaseCannotBeOpened errors join the existing disk-pressure classification without importing the optional native runtime into the classifier.

The package upgrade also includes upstream transaction cleanup, connection ownership, NUL text handling, undefined parameter binding, row materialization improvements, Android temporary-storage handling, and bundled SQLite 3.53.4 with isolated symbols. RTree is available in the bundled engine; Onyx's key/value schema has no spatial queries. SEE encryption requires a licensed native build, a key supplied to both connections, and an App migration policy, so existing Onyx databases retain their current format. Onyx does not use NitroSQLite's TypeORM or vector adapters. The full upstream changes are listed in the 10.1.0 release.

The SQLite provider tests use the published react-native-nitro-sqlite/mock export, replacing Onyx's local mock. They execute real SQLite through better-sqlite3, with spies to control query timing. Onyx's public API and web provider behavior remain unchanged.

Related Issues

Expensify/App#102424

Linked E/App PR

Expensify/App#102422

Automated Tests

All 663 tests pass on the repository's pinned Node 24.19.0 after a clean lockfile install. The 39 SQLite provider tests use the published 10.1.0 mock and cover statement reuse, independent reads, read-after-write ordering, concurrent-write snapshots, and JSON merge behavior. New regressions cover grouped write and delete rollback, recovery after a failed snapshot read, full and partial delete chunks, and embedded NUL characters. Classifier tests cover structured native errors and legacy SQLite messages.

These Node tests verify provider behavior; native transaction fixes and performance still need App builds and device testing.

Manual Tests

The linked App PR needs to pin this branch's new head and use NitroSQLite 10.1.0 for validation. App CI and native device verification are pending.

In the linked App PR, upgrade iOS and Android builds with existing Onyx data, send a message, relaunch, and confirm the message and sign-in state persist. Repeat offline, reconnect, and confirm the pending message sends once. Export Onyx state from the developer tools and verify a known persisted key is present. Repeat with a high-traffic account to exercise chunked reads and writes.

Author Checklist

• I linked the correct issue in the ### Related Issues section above
• I linked the corresponding Expensify/App PR in the ### Linked E/App PR section above, and verified this change against it (E/App CI passed and manual testing completed)
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. onClick={this.toggleReport} should be bound in the constructor).
  • Any internal methods bound to this are necessary to be bound (i.e. avoid unnecessary binds)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

No screenshots or videos are included because this storage-provider change has no visible UI.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[inimaga]

@chrispader Is this ready for review? Held off looking at it since it has WIP in the title

[chrispader]

@chrispader Is this ready for review? Held off looking at it since it has WIP in the title

@inimaga not yet! I'll ping you once this is ready 🙌🏼