Repository navigation
[Due for payment 2026-10-07] Payment issue for E/App PR#101568 #102591
Description
Activity
@ikevin127 The PR you reviewed has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
BugZero Checklist;
-
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A - Result of the original design
-
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
-
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
-
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
- In an Android, iOS, or web staging build containing this PR, open Settings → Troubleshoot and export Onyx state. Verify the file is available to share or download and its sensitive fields are masked.
- Repeat while offline. Verify the export still works and no JS console error appears.
- After chore(deps): Update NitroSQLite to 9.8.2 #101437 includes this prerequisite, repeat the native export and verify there is no duplicate-connection error.
Do we agree 👍 or 👎.
-
- @NicolasBonet Requesting payment review for the 7th when payment is due, for reviewing the following PRs part of the main issue chore(deps): Update NitroSQLite from 9.6.0 to 9.8.0 #101448:
- [Payment due @ikevin127] fix: export Onyx state through Onyx #101568 (PR for this issue) - $250 (review requested on 18th Sep, before standard bounty was lowered to $175)
- chore(deps): Update NitroSQLite to 9.8.2 #101437 (PR part of main issue) - $250 (review requested on 17th Sep, before standard bounty was lowered to $175)
- feat: export persisted Onyx state through active provider react-native-onyx#848 (
react-native-onyxPR part of main issue) - $250 (review requested on 18th Sep, before standard bounty was lowered to $175)
Could you please confirm agree/disagree on payment total of $750 for reviewing the 3 PRs (no regressions) ? Thanks 🙌
We actually had a regression @ikevin127: #102728, but I do agree with the rest
@mallenexpensify One regression confirmed in the comment below, so total payment summary should be $625 🙌
We actually had a regression @ikevin127: #102728, but I do agree with the rest
Reacted by Kevin Brian BaderTriggered auto assignment to @mallenexpensify (
Awaiting Payment)Payment Summary
- Reviewer: @ikevin127 owed $175 via NewDot
BugZero Checklist (@mallenexpensify)
- I have confirmed assignees, roles, and Upwork contracts look correct
- I have paid out Upwork contracts / manual NewDot requests
- [BugZero Assignee] I have created a GH issue for creating/updating the regression test once above steps have been agreed upon
Note
One regression confirmed 3 comments above, so total payment summary should be $625. See breakdown here.
@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Issue created to compensate the Contributor+ member for their work on #101568
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @ikevin127.
Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.
Issue Owner
Current Issue Owner: @mallenexpensify