fix: zip-slip + i18n 缺口 + updater 结果契约 DRY（审查 8d206ff） - #52
Merged
Tanya7z merged 2 commits intoJul 23, 2026
Conversation
审查 main@8d206ff（i18n/updater/docs）与遗留 #51： - BLOCKER(DRY): zipx 安全解压，world-packs/check-update 共用 - BLOCKER: installPackDirectory 残缺 manifest 同名不再静默覆盖 - MAJOR(LSP/Demeter): enabledMap 统一；doctor 经 listWorldEnableEntries - MAJOR(DRY): SFMC_UPDATE_RESULT / stripTaskbarOsc 抽到 bds-tools 权威模块 - MAJOR(i18n/LSP): postModuleToggle 与 packs list 头/开关走 t()；补全 zh-CN 收件箱文案 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
4 tasks
Tanya7z
marked this pull request as ready for review
July 23, 2026 15:58
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This was referenced Jul 23, 2026
cursor Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
审查 main@e95d81e ootb 红（#51+#52 合并残留）后 #54 已修 TS2300； 本补丁收敛遗留 SOLID 债： - MAJOR(DRY): tools/fetch-module 解压委托 @sfmc-bds/bds-tools/zipx - MAJOR(LSP): readWorldPackListResult 恢复 doctor parseFail 信号 - MINOR(DRY): cmdUpdate 直接 stripTaskbarOsc，去掉无用 stripOsc 别名 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
审查
main@8d206ff（多语言 / updater 进度条 / docs）与遗留 #51（与 updater 改动冲突）。ootb 绿；本 PR 直接修可验证问题并合入 #51 安全修复。BLOCKER — zip-slip / 静默覆盖（DRY）
bds-tools/src/zipx.ts：world-packs.extractArchiveToTemp与check-update.extractZipToBds共用安全解压installPackDirectory：残缺 manifest 同名目录也必须 conflict，禁止静默rm+覆盖MAJOR — LSP / Demeter
listInstalledWorldPacksfallback 与正常路径统一用enabledMap.haspacks doctor经listWorldEnableEntries→readWorldPackList，不再硬编码world_*_packs.jsonMAJOR — DRY / DIP（本轮 i18n+updater）
SFMC_UPDATE_RESULT=*→bds-tools/update-result（emitUpdateResult/didUpdateDeploy）taskbar.stripTaskbarOsc（与写入侧同一权威）postModuleToggle成功/失败文案走t()；packs list头与 on/off 本地化；补全 zh-CNinstallInbox/scanResultMINOR
resolveSdkPackageRoot优先@sfmc-bds/sdk/package.jsonexport取代 冲突中的 #51（同安全修复已 rebase 到当前 main）。
Test plan
npm run build --workspaces --if-presentcd bds-tools && npm test→ 18/18cd sfmc && npm run typecheckSFMC_ROOT=$PWD node tools/check-ootb.mjs→ 12/12