fix: ootb TS2300 + wizard→zipx DRY + README.en 对齐 - #54
Merged
Tanya7z merged 2 commits intoJul 23, 2026
Conversation
Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
Tanya7z
marked this pull request as ready for review
July 23, 2026 16:06
Contributor
Author
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
cursor Bot
pushed a commit
that referenced
this pull request
Jul 23, 2026
审查 main@e95d81e ootb 红（#51+#52 合并残留）后 #54 已修 TS2300； 本补丁收敛遗留 SOLID 债： - MAJOR(DRY): tools/fetch-module 解压委托 @sfmc-bds/bds-tools/zipx - MAJOR(LSP): readWorldPackListResult 恢复 doctor parseFail 信号 - MINOR(DRY): cmdUpdate 直接 stripTaskbarOsc，去掉无用 stripOsc 别名 Co-authored-by: Shiroha <Tanya7z@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
审查
main@e95d81e（README AI 声明 push）。该提交本身为文档；但 main 上 ootb 仍因 #51+#52 合并残留而红（run30023292009/30023000049）。本 PR 直接修 CI，并收敛相关 DRY/LSP 债。BLOCKER — DRY（修 ootb）
bds-tools/src/check-update.ts双份import { extractZipFileToDir } from "./zipx.js"→TS2300MAJOR — DRY / DIP
@sfmc-bds/bds-tools/zipxsfmc/wizardSEA 资产解压改走extractZipBufferToDir，删除本地 JSZip/safeJoin副本与jszip直接依赖MAJOR — LSP（文档契约）
README.en.mdLicense 误写 MIT，与LICENSE（AGPL-3.0）及中文 README 不一致 → 改为 AGPL-3.0 并补条款摘要Test plan
npm run build --workspaces --if-presentcd bds-tools && npm test→ 18/18cd sfmc && npm run typecheckSFMC_ROOT=$PWD node tools/check-ootb.mjs→ 12/12